[go] cmd/compile: fix an error in comments

1 view
Skip to first unread message

Wanbiao Ye (Gerrit)

unread,
Oct 14, 2025, 11:04:34 PM (yesterday) Oct 14
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Wanbiao Ye has uploaded the change for review

Commit message

cmd/compile: fix an error in comments

Remove the redundant only.
Change-Id: I9cf2d84ae080a567ad45a2d0ef002c7c89395479

Change diff

diff --git a/src/cmd/compile/internal/types2/instantiate.go b/src/cmd/compile/internal/types2/instantiate.go
index 1c8c12d..8b24f2f 100644
--- a/src/cmd/compile/internal/types2/instantiate.go
+++ b/src/cmd/compile/internal/types2/instantiate.go
@@ -83,7 +83,7 @@
 //
 // For Named types the resulting instance may be unexpanded.
 //
-// check may be nil (when not type-checking syntax); pos is used only only if check is non-nil.
+// check may be nil (when not type-checking syntax); pos is used only if check is non-nil.
 func (check *Checker) instance(pos syntax.Pos, orig genericType, targs []Type, expanding *Named, ctxt *Context) (res Type) {
 	// The order of the contexts below matters: we always prefer instances in the
 	// expanding instance context in order to preserve reference cycles.
diff --git a/src/go/types/instantiate.go b/src/go/types/instantiate.go
index eef4734..0bccd3d 100644
--- a/src/go/types/instantiate.go
+++ b/src/go/types/instantiate.go
@@ -86,7 +86,7 @@
 //
 // For Named types the resulting instance may be unexpanded.
 //
-// check may be nil (when not type-checking syntax); pos is used only only if check is non-nil.
+// check may be nil (when not type-checking syntax); pos is used only if check is non-nil.
 func (check *Checker) instance(pos token.Pos, orig genericType, targs []Type, expanding *Named, ctxt *Context) (res Type) {
 	// The order of the contexts below matters: we always prefer instances in the
 	// expanding instance context in order to preserve reference cycles.

Change information

Files:
  • M src/cmd/compile/internal/types2/instantiate.go
  • M src/go/types/instantiate.go
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I9cf2d84ae080a567ad45a2d0ef002c7c89395479
Gerrit-Change-Number: 711960
Gerrit-PatchSet: 1
Gerrit-Owner: Wanbiao Ye <lacew...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Robert Findley (Gerrit)

unread,
Oct 14, 2025, 11:16:46 PM (yesterday) Oct 14
to Wanbiao Ye, goph...@pubsubhelper.golang.org, Robert Griesemer, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Robert Griesemer and Wanbiao Ye

Robert Findley voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Robert Griesemer
  • Wanbiao Ye
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I9cf2d84ae080a567ad45a2d0ef002c7c89395479
Gerrit-Change-Number: 711960
Gerrit-PatchSet: 1
Gerrit-Owner: Wanbiao Ye <lacew...@gmail.com>
Gerrit-Reviewer: Robert Findley <rfin...@google.com>
Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Attention: Wanbiao Ye <lacew...@gmail.com>
Gerrit-Attention: Robert Griesemer <g...@golang.org>
Gerrit-Comment-Date: Wed, 15 Oct 2025 03:16:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Robert Findley (Gerrit)

unread,
Oct 14, 2025, 11:16:52 PM (yesterday) Oct 14
to Wanbiao Ye, goph...@pubsubhelper.golang.org, Robert Griesemer, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Robert Griesemer and Wanbiao Ye

Robert Findley voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Robert Griesemer
  • Wanbiao Ye
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I9cf2d84ae080a567ad45a2d0ef002c7c89395479
Gerrit-Change-Number: 711960
Gerrit-PatchSet: 1
Gerrit-Owner: Wanbiao Ye <lacew...@gmail.com>
Gerrit-Reviewer: Robert Findley <rfin...@google.com>
Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Attention: Wanbiao Ye <lacew...@gmail.com>
Gerrit-Attention: Robert Griesemer <g...@golang.org>
Gerrit-Comment-Date: Wed, 15 Oct 2025 03:16:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Robert Griesemer (Gerrit)

unread,
12:30 AM (23 hours ago) 12:30 AM
to Wanbiao Ye, goph...@pubsubhelper.golang.org, Go LUCI, Robert Findley, Robert Griesemer, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Robert Findley, Robert Griesemer and Wanbiao Ye

Robert Griesemer voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Robert Findley
  • Robert Griesemer
  • Wanbiao Ye
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I9cf2d84ae080a567ad45a2d0ef002c7c89395479
    Gerrit-Change-Number: 711960
    Gerrit-PatchSet: 1
    Gerrit-Owner: Wanbiao Ye <lacew...@gmail.com>
    Gerrit-Reviewer: Robert Findley <rfin...@google.com>
    Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
    Gerrit-Reviewer: Robert Griesemer <g...@google.com>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Wanbiao Ye <lacew...@gmail.com>
    Gerrit-Attention: Robert Griesemer <g...@golang.org>
    Gerrit-Attention: Robert Findley <rfin...@google.com>
    Gerrit-Comment-Date: Wed, 15 Oct 2025 04:30:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Robert Findley (Gerrit)

    unread,
    3:55 PM (8 hours ago) 3:55 PM
    to Wanbiao Ye, goph...@pubsubhelper.golang.org, Robert Griesemer, Go LUCI, Robert Griesemer, Gopher Robot, golang-co...@googlegroups.com
    Attention needed from Robert Griesemer and Wanbiao Ye

    Robert Findley voted and added 1 comment

    Votes added by Robert Findley

    Commit-Queue+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Robert Findley . resolved

    Looks like a test flake! Sorry, I wasn't aware of this flake. Will re-run.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Robert Griesemer
    • Wanbiao Ye
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I9cf2d84ae080a567ad45a2d0ef002c7c89395479
    Gerrit-Change-Number: 711960
    Gerrit-PatchSet: 1
    Gerrit-Owner: Wanbiao Ye <lacew...@gmail.com>
    Gerrit-Reviewer: Robert Findley <rfin...@google.com>
    Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
    Gerrit-Reviewer: Robert Griesemer <g...@google.com>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Wanbiao Ye <lacew...@gmail.com>
    Gerrit-Attention: Robert Griesemer <g...@golang.org>
    Gerrit-Comment-Date: Wed, 15 Oct 2025 19:55:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Robert Griesemer (Gerrit)

    unread,
    4:48 PM (7 hours ago) 4:48 PM
    to Wanbiao Ye, goph...@pubsubhelper.golang.org, Go LUCI, Robert Findley, Robert Griesemer, Gopher Robot, golang-co...@googlegroups.com
    Attention needed from Robert Findley, Robert Griesemer and Wanbiao Ye

    Robert Griesemer voted and added 1 comment

    Votes added by Robert Griesemer

    TryBot-Bypass+1

    1 comment

    Patchset-level comments
    Robert Griesemer . resolved

    Failure is unrelated. Ok to submit.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Robert Findley
    • Robert Griesemer
    • Wanbiao Ye
    Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I9cf2d84ae080a567ad45a2d0ef002c7c89395479
      Gerrit-Change-Number: 711960
      Gerrit-PatchSet: 1
      Gerrit-Owner: Wanbiao Ye <lacew...@gmail.com>
      Gerrit-Reviewer: Robert Findley <rfin...@google.com>
      Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
      Gerrit-Reviewer: Robert Griesemer <g...@google.com>
      Gerrit-CC: Gopher Robot <go...@golang.org>
      Gerrit-Attention: Wanbiao Ye <lacew...@gmail.com>
      Gerrit-Attention: Robert Griesemer <g...@golang.org>
      Gerrit-Attention: Robert Findley <rfin...@google.com>
      Gerrit-Comment-Date: Wed, 15 Oct 2025 20:48:25 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Gopher Robot (Gerrit)

      unread,
      4:48 PM (7 hours ago) 4:48 PM
      to Wanbiao Ye, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Robert Griesemer, Go LUCI, Robert Findley, Robert Griesemer, golang-co...@googlegroups.com

      Gopher Robot submitted the change

      Change information

      Commit message:
      cmd/compile: fix an error in comments

      Remove the redundant only.
      Change-Id: I9cf2d84ae080a567ad45a2d0ef002c7c89395479
      Auto-Submit: Robert Findley <rfin...@google.com>
      Reviewed-by: Robert Griesemer <g...@google.com>
      Reviewed-by: Robert Findley <rfin...@google.com>
      TryBot-Bypass: Robert Griesemer <g...@google.com>
      Files:
      • M src/cmd/compile/internal/types2/instantiate.go
      • M src/go/types/instantiate.go
      Change size: XS
      Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
      Branch: refs/heads/master
      Submit Requirements:
      • requirement satisfiedCode-Review: +2 by Robert Findley, +2 by Robert Griesemer
      • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI, TryBot-Bypass+1 by Robert Griesemer
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I9cf2d84ae080a567ad45a2d0ef002c7c89395479
      Gerrit-Change-Number: 711960
      Gerrit-PatchSet: 2
      Gerrit-Owner: Wanbiao Ye <lacew...@gmail.com>
      Gerrit-Reviewer: Gopher Robot <go...@golang.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages