[mod] x/mod: allow for aggressively conslidating requires

3 views
Skip to first unread message

Ian Alexander (Gerrit)

unread,
Jan 26, 2026, 11:25:59 AMJan 26
to goph...@pubsubhelper.golang.org, Michael Pratt, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Michael Pratt

Ian Alexander voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Pratt
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: mod
Gerrit-Branch: master
Gerrit-Change-Id: If71e124725cbd9b1d9e6fc5ad0a4cf33f34cb3ae
Gerrit-Change-Number: 739221
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Alexander <ji...@google.com>
Gerrit-Reviewer: Ian Alexander <ji...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-CC: Michael Matloob <mat...@golang.org>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Mon, 26 Jan 2026 16:25:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Pratt (Gerrit)

unread,
Jan 26, 2026, 5:26:56 PMJan 26
to Ian Alexander, goph...@pubsubhelper.golang.org, Go LUCI, Michael Pratt, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Ian Alexander

Michael Pratt added 3 comments

Commit Message
Line 9, Patchset 1 (Latest):This chnage adds a new function `SetRequireSimplify` that will
Michael Pratt . unresolved

change

File modfile/rule.go
Line 1278, Patchset 1 (Latest):// SetRequireSimplify is like SetRequireSeparateIndirect but it aggressively
Michael Pratt . resolved

Tiny naming nit, feel free to disregard if you are already happy with the name.

IMO, "RequireSimplify" is pretty vague, it's not really clear how things will simplify at a glance. An alternative may be something like "RequireAtMostTwo".

(This applies to CL 738740 as well)

File modfile/rule_test.go
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Alexander
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: mod
    Gerrit-Branch: master
    Gerrit-Change-Id: If71e124725cbd9b1d9e6fc5ad0a4cf33f34cb3ae
    Gerrit-Change-Number: 739221
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ian Alexander <ji...@google.com>
    Gerrit-Reviewer: Ian Alexander <ji...@google.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: Michael Matloob <mat...@golang.org>
    Gerrit-Attention: Ian Alexander <ji...@google.com>
    Gerrit-Comment-Date: Mon, 26 Jan 2026 22:26:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Ian Alexander (Gerrit)

    unread,
    5:19 PM (6 hours ago) 5:19 PM
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Ian Alexander

    Ian Alexander uploaded new patchset

    Ian Alexander uploaded patch set #2 to this change.
    Following approvals got outdated and were removed:
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Alexander
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: mod
      Gerrit-Branch: master
      Gerrit-Change-Id: If71e124725cbd9b1d9e6fc5ad0a4cf33f34cb3ae
      Gerrit-Change-Number: 739221
      Gerrit-PatchSet: 2
      Gerrit-Owner: Ian Alexander <ji...@google.com>
      Gerrit-Reviewer: Ian Alexander <ji...@google.com>
      Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
      unsatisfied_requirement
      open
      diffy

      Ian Alexander (Gerrit)

      unread,
      5:19 PM (6 hours ago) 5:19 PM
      to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Pratt, Michael Matloob, golang-co...@googlegroups.com
      Attention needed from Michael Pratt

      Ian Alexander voted and added 3 comments

      Votes added by Ian Alexander

      Commit-Queue+1

      3 comments

      Commit Message
      Line 9, Patchset 1:This chnage adds a new function `SetRequireSimplify` that will
      Michael Pratt . resolved

      change

      Ian Alexander

      Done

      File modfile/rule.go
      Line 1278, Patchset 1:// SetRequireSimplify is like SetRequireSeparateIndirect but it aggressively
      Michael Pratt . resolved

      Tiny naming nit, feel free to disregard if you are already happy with the name.

      IMO, "RequireSimplify" is pretty vague, it's not really clear how things will simplify at a glance. An alternative may be something like "RequireAtMostTwo".

      (This applies to CL 738740 as well)

      Ian Alexander

      Done.

      File modfile/rule_test.go
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Michael Pratt
      Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: mod
        Gerrit-Branch: master
        Gerrit-Change-Id: If71e124725cbd9b1d9e6fc5ad0a4cf33f34cb3ae
        Gerrit-Change-Number: 739221
        Gerrit-PatchSet: 2
        Gerrit-Owner: Ian Alexander <ji...@google.com>
        Gerrit-Reviewer: Ian Alexander <ji...@google.com>
        Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
        Gerrit-CC: Michael Matloob <mat...@golang.org>
        Gerrit-Attention: Michael Pratt <mpr...@google.com>
        Gerrit-Comment-Date: Mon, 11 May 2026 21:19:45 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Michael Pratt <mpr...@google.com>
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages