[go] runtime: prefer to restart Ps on the same M after STW

7 views
Skip to first unread message

Michael Pratt (Gerrit)

unread,
Oct 24, 2025, 6:19:09 PM (13 days ago) Oct 24
to Michael Pratt, goph...@pubsubhelper.golang.org, Michael Knyszek, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Knyszek

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Knyszek
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a6a636c0969c587d039b68bc68ea16c74ff1fc9
Gerrit-Change-Number: 714801
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Michael Knyszek <mkny...@google.com>
Gerrit-Comment-Date: Fri, 24 Oct 2025 22:19:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Pratt (Gerrit)

unread,
Oct 30, 2025, 2:17:33 PM (7 days ago) Oct 30
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Knyszek

Michael Pratt uploaded new patchset

Michael Pratt uploaded patch set #3 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Knyszek
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a6a636c0969c587d039b68bc68ea16c74ff1fc9
Gerrit-Change-Number: 714801
Gerrit-PatchSet: 3
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Pratt (Gerrit)

unread,
Oct 30, 2025, 2:21:25 PM (7 days ago) Oct 30
to Michael Pratt, goph...@pubsubhelper.golang.org, Michael Knyszek, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Knyszek

Michael Pratt voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Knyszek
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a6a636c0969c587d039b68bc68ea16c74ff1fc9
Gerrit-Change-Number: 714801
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Michael Knyszek <mkny...@google.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 18:21:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

t hepudds (Gerrit)

unread,
Oct 30, 2025, 3:10:08 PM (7 days ago) Oct 30
to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, Michael Knyszek, golang-co...@googlegroups.com
Attention needed from Michael Knyszek and Michael Pratt

t hepudds added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
t hepudds . resolved

Hi Michael, quick comment to say that this seems really nice!

(FWIW, I've been thinking a bit about affinities in the context of #74299 (runtime.free), though not too worried about it at this point. Separately, I sometimes think about Felix's somewhat related CL 460541, though he might have viewed that as more of an experiment. In any event, I guess your #65694 is the more general place for this topic.)

Sorry, the TLDR is 🎉 🚀

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Knyszek
  • Michael Pratt
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a6a636c0969c587d039b68bc68ea16c74ff1fc9
Gerrit-Change-Number: 714801
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-CC: t hepudds <thepud...@gmail.com>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Michael Knyszek <mkny...@google.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 19:10:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Pratt (Gerrit)

unread,
Oct 30, 2025, 3:40:29 PM (7 days ago) Oct 30
to Michael Pratt, goph...@pubsubhelper.golang.org, t hepudds, Go LUCI, Michael Knyszek, golang-co...@googlegroups.com
Attention needed from Michael Knyszek

Michael Pratt voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Knyszek
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a6a636c0969c587d039b68bc68ea16c74ff1fc9
Gerrit-Change-Number: 714801
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-CC: t hepudds <thepud...@gmail.com>
Gerrit-Attention: Michael Knyszek <mkny...@google.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 19:40:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Knyszek (Gerrit)

unread,
Oct 30, 2025, 3:53:56 PM (7 days ago) Oct 30
to Michael Pratt, goph...@pubsubhelper.golang.org, t hepudds, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Pratt

Michael Knyszek added 2 comments

File src/runtime/proc.go
Line 2034, Patchset 4 (Latest): // Clear the self pointer so Ps don't access this M after it is freed,
// or keep it alive.
Michael Knyszek . unresolved

WDYT about adding a test that triggers this case? (get oldm set on some P, exit the thread, then do a bunch of scheduling to try and trigger a bad access)

File src/runtime/runtime2.go
Line 754, Patchset 4 (Latest): oldm *atomic.Pointer[m]
Michael Knyszek . unresolved

do we want to maybe give this a name like `type mWeakPointer struct { *atomic.Pointer[m] }`?

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Pratt
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I6a6a636c0969c587d039b68bc68ea16c74ff1fc9
    Gerrit-Change-Number: 714801
    Gerrit-PatchSet: 4
    Gerrit-Owner: Michael Pratt <mpr...@google.com>
    Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: t hepudds <thepud...@gmail.com>
    Gerrit-Attention: Michael Pratt <mpr...@google.com>
    Gerrit-Comment-Date: Thu, 30 Oct 2025 19:53:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Michael Pratt (Gerrit)

    unread,
    Oct 30, 2025, 4:36:54 PM (7 days ago) Oct 30
    to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, t hepudds, golang-co...@googlegroups.com

    Michael Pratt voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I6a6a636c0969c587d039b68bc68ea16c74ff1fc9
    Gerrit-Change-Number: 714801
    Gerrit-PatchSet: 5
    Gerrit-Owner: Michael Pratt <mpr...@google.com>
    Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: t hepudds <thepud...@gmail.com>
    Gerrit-Comment-Date: Thu, 30 Oct 2025 20:36:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    open
    diffy

    Michael Pratt (Gerrit)

    unread,
    Oct 31, 2025, 4:39:18 PM (6 days ago) Oct 31
    to Michael Pratt, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

    Michael Pratt uploaded new patchset

    Michael Pratt uploaded patch set #6 to this change.
    Following approvals got outdated and were removed:
    • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I6a6a636c0969c587d039b68bc68ea16c74ff1fc9
    Gerrit-Change-Number: 714801
    Gerrit-PatchSet: 6
    unsatisfied_requirement
    open
    diffy

    Michael Pratt (Gerrit)

    unread,
    Oct 31, 2025, 4:40:15 PM (6 days ago) Oct 31
    to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, t hepudds, golang-co...@googlegroups.com

    Michael Pratt voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I6a6a636c0969c587d039b68bc68ea16c74ff1fc9
    Gerrit-Change-Number: 714801
    Gerrit-PatchSet: 6
    Gerrit-Owner: Michael Pratt <mpr...@google.com>
    Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: t hepudds <thepud...@gmail.com>
    Gerrit-Comment-Date: Fri, 31 Oct 2025 20:40:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    open
    diffy

    Michael Pratt (Gerrit)

    unread,
    Oct 31, 2025, 5:40:52 PM (6 days ago) Oct 31
    to Michael Pratt, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Michael Pratt

    Michael Pratt uploaded new patchset

    Michael Pratt uploaded patch set #7 to this change.
    Following approvals got outdated and were removed:
    • TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Pratt
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I6a6a636c0969c587d039b68bc68ea16c74ff1fc9
    Gerrit-Change-Number: 714801
    Gerrit-PatchSet: 7
    Gerrit-Owner: Michael Pratt <mpr...@google.com>
    Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: t hepudds <thepud...@gmail.com>
    Gerrit-Attention: Michael Pratt <mpr...@google.com>
    unsatisfied_requirement
    open
    diffy

    Michael Pratt (Gerrit)

    unread,
    Nov 3, 2025, 4:59:34 PM (3 days ago) Nov 3
    to Michael Pratt, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Michael Pratt

    Michael Pratt uploaded new patchset

    Michael Pratt uploaded patch set #11 to this change.
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Pratt
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I6a6a636c0969c587d039b68bc68ea16c74ff1fc9
    Gerrit-Change-Number: 714801
    Gerrit-PatchSet: 11
    unsatisfied_requirement
    open
    diffy

    Michael Pratt (Gerrit)

    unread,
    Nov 3, 2025, 4:59:54 PM (3 days ago) Nov 3
    to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, t hepudds, golang-co...@googlegroups.com

    Michael Pratt voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I6a6a636c0969c587d039b68bc68ea16c74ff1fc9
    Gerrit-Change-Number: 714801
    Gerrit-PatchSet: 11
    Gerrit-Owner: Michael Pratt <mpr...@google.com>
    Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: t hepudds <thepud...@gmail.com>
    Gerrit-Comment-Date: Mon, 03 Nov 2025 21:59:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages