[go] cmd/go: use module index for local wildcard search
3 views
Skip to first unread message
Jake Bailey (Gerrit)
Jun 30, 2026, 4:06:42 PMJun 30
to goph...@pubsubhelper.golang.org, Quim Muntal, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Quim Muntal
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Michael Matloob
- Quim Muntal
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 18, 2026, 2:20:07 PM (3 days ago) Jul 18
to Jake Bailey, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Quim Muntal, golang-co...@googlegroups.com
Attention needed from Jake Bailey and Quim Muntal
Michael Matloob voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Jake Bailey
- Quim Muntal
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Quim Muntal (Gerrit)
Jul 18, 2026, 3:06:32 PM (3 days ago) Jul 18
to Jake Bailey, goph...@pubsubhelper.golang.org, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Jake Bailey
Quim Muntal voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jake Bailey
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 20, 2026, 11:08:39 AM (2 days ago) Jul 20
to Jake Bailey, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Quim Muntal, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Jake Bailey
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jake Bailey
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
Jul 21, 2026, 5:36:41 PM (9 hours ago) Jul 21
to Jake Bailey, goph...@pubsubhelper.golang.org, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, Quim Muntal, Michael Matloob, golang-co...@googlegroups.com
Attention needed from Jake Bailey
Carlos Amedee voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jake Bailey
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Liao (Gerrit)
Jul 21, 2026, 6:03:45 PM (8 hours ago) Jul 21
to Jake Bailey, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Carlos Amedee, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, Quim Muntal, Michael Matloob, golang-co...@googlegroups.com
Sean Liao submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
cmd/go: use module index for local wildcard search
Local wildcard matching checks whether each matched directory contains a
package. In module mode, answer that from the module index when available
instead of reading each directory again.
For typescript-go, the Windows local-wildcard go list query used by
gopls drops from about 4.3s to about 2.1s.
Change-Id: I7b6d8ee33031da61beec22926f1f8744d048a58e
Reviewed-on: https://go-review.googlesource.com/c/go/+/795741
Reviewed-by: Carlos Amedee <car...@golang.org>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Matloob <mat...@google.com>
Reviewed-by: Michael Matloob <mat...@golang.org>
Reviewed-by: Quim Muntal <quimm...@gmail.com>
Files:
- M src/cmd/go/internal/search/search.go
- M src/cmd/go/testdata/script/list_parse_err.txt
Change size: S
Delta: 2 files changed, 43 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Michael Matloob, +1 by Carlos Amedee, +1 by Quim Muntal, +1 by Michael Matloob
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages