[oscar] internal/model: go fix -any

1 view
Skip to first unread message

Hyang-Ah Hana Kim (Gerrit)

unread,
Feb 26, 2026, 10:07:57 PM (20 hours ago) Feb 26
to goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com

Hyang-Ah Hana Kim has uploaded the change for review

Commit message

internal/model: go fix -any
Change-Id: I615a7d108107284a3406aaf64c844f7e6be76327

Change diff

diff --git a/internal/model/model.go b/internal/model/model.go
index dcc4cd5..6346bf8 100644
--- a/internal/model/model.go
+++ b/internal/model/model.go
@@ -53,8 +53,7 @@

// Updates contains changes to a value.
// It is used in conjunction with [Source.Update].
-type Updates interface {
-}
+type Updates any

// PostUpdates holds updates to a [Post].
type PostUpdates interface {

Change information

Files:
  • M internal/model/model.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 2 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: oscar
Gerrit-Branch: master
Gerrit-Change-Id: I615a7d108107284a3406aaf64c844f7e6be76327
Gerrit-Change-Number: 749641
Gerrit-PatchSet: 1
Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Ian Lance Taylor (Gerrit)

unread,
Feb 26, 2026, 11:33:20 PM (19 hours ago) Feb 26
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim

Ian Lance Taylor voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Hyang-Ah Hana Kim
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: oscar
Gerrit-Branch: master
Gerrit-Change-Id: I615a7d108107284a3406aaf64c844f7e6be76327
Gerrit-Change-Number: 749641
Gerrit-PatchSet: 1
Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Comment-Date: Fri, 27 Feb 2026 04:33:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Cherry Mui (Gerrit)

unread,
4:39 PM (2 hours ago) 4:39 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim

Cherry Mui voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hyang-Ah Hana Kim
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: oscar
Gerrit-Branch: master
Gerrit-Change-Id: I615a7d108107284a3406aaf64c844f7e6be76327
Gerrit-Change-Number: 749641
Gerrit-PatchSet: 1
Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
Gerrit-Comment-Date: Fri, 27 Feb 2026 21:39:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nicholas Husin (Gerrit)

unread,
4:39 PM (2 hours ago) 4:39 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Cherry Mui, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim

Nicholas Husin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hyang-Ah Hana Kim
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: oscar
    Gerrit-Branch: master
    Gerrit-Change-Id: I615a7d108107284a3406aaf64c844f7e6be76327
    Gerrit-Change-Number: 749641
    Gerrit-PatchSet: 1
    Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Reviewer: Nicholas Husin <hu...@google.com>
    Gerrit-Attention: Hyang-Ah Hana Kim <hya...@gmail.com>
    Gerrit-Comment-Date: Fri, 27 Feb 2026 21:39:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Hyang-Ah Hana Kim (Gerrit)

    unread,
    4:44 PM (2 hours ago) 4:44 PM
    to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Nicholas Husin, Cherry Mui, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com

    Hyang-Ah Hana Kim submitted the change

    Change information

    Commit message:
    internal/model: go fix -any
    Change-Id: I615a7d108107284a3406aaf64c844f7e6be76327
    Commit-Queue: Cherry Mui <cher...@google.com>
    Reviewed-by: Nicholas Husin <hu...@google.com>
    Reviewed-by: Ian Lance Taylor <ia...@golang.org>
    Files:
    • M internal/model/model.go
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 2 deletions(-)
    Branch: refs/heads/master
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Ian Lance Taylor, +1 by Nicholas Husin
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: oscar
    Gerrit-Branch: master
    Gerrit-Change-Id: I615a7d108107284a3406aaf64c844f7e6be76327
    Gerrit-Change-Number: 749641
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages