[build] internal/task: consider failing to set a review a soft failure, part 2/2

3 views
Skip to first unread message

Dmitri Shuralyov (Gerrit)

unread,
May 9, 2025, 1:36:18 PMMay 9
to Carlos Amedee, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Carlos Amedee

Dmitri Shuralyov has uploaded the change for review

Dmitri Shuralyov would like Carlos Amedee to review this change.

Commit message

internal/task: consider failing to set a review a soft failure, part 2/2

Apply an analogous change for GenerateAutoSubmitChange
to mirror what CL 670475 did in CreateAutoSubmitChange.

For golang/go#68276.
Change-Id: I280b6e5b0e7814cb12dfe3ff1de9bb7037fc38ff

Change diff

diff --git a/internal/task/cloudbuild.go b/internal/task/cloudbuild.go
index a0d352e..dbea682 100644
--- a/internal/task/cloudbuild.go
+++ b/internal/task/cloudbuild.go
@@ -198,6 +198,7 @@
 	}
 
 	refspec := fmt.Sprintf("HEAD:refs/for/%s%%l=Auto-Submit,l=Commit-Queue+1", input.Branch)
+	refspecNoReviewers := refspec
 	reviewerEmails, err := coordinatorEmails(reviewers)
 	if err != nil {
 		return "", err
@@ -273,10 +274,14 @@
 					// git push output to be written to $BUILDER_OUTPUT/output regardless of its
 					// exit code, and complete the nearly-done build.
 					//
+					// First try a regular push, but also try again without reviewers in case it
+					// helps. See go.dev/issue/68276.
+					//
 					// Whether the push successfully created a CL or not will be determined from
 					// the output text.
-					Args: []string{"-c", `git push origin ` + refspec + ` 2>&1 | tee "$$BUILDER_OUTPUT/output"`},
-					Dir:  "checkout",
+					Args: []string{"-c", fmt.Sprintf("(git push origin %s || git push origin %s)", refspec, refspecNoReviewers) +
+						` 2>&1 | tee "$$BUILDER_OUTPUT/output"`},
+					Dir: "checkout",
 				},
 			},
 			Options: &cloudbuildpb.BuildOptions{

Change information

Files:
  • M internal/task/cloudbuild.go
Change size: XS
Delta: 1 file changed, 7 insertions(+), 2 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Carlos Amedee
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I280b6e5b0e7814cb12dfe3ff1de9bb7037fc38ff
Gerrit-Change-Number: 671535
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Attention: Carlos Amedee <car...@golang.org>
unsatisfied_requirement
satisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
May 9, 2025, 1:36:36 PMMay 9
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Carlos Amedee, golang-co...@googlegroups.com
Attention needed from Carlos Amedee

Dmitri Shuralyov voted

Code-Review+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Carlos Amedee
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I280b6e5b0e7814cb12dfe3ff1de9bb7037fc38ff
Gerrit-Change-Number: 671535
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Attention: Carlos Amedee <car...@golang.org>
Gerrit-Comment-Date: Fri, 09 May 2025 17:36:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Carlos Amedee (Gerrit)

unread,
May 23, 2025, 5:50:46 PMMay 23
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Go LUCI, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov

Carlos Amedee voted and added 1 comment

Votes added by Carlos Amedee

Code-Review+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Carlos Amedee . resolved

Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Dmitri Shuralyov
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I280b6e5b0e7814cb12dfe3ff1de9bb7037fc38ff
Gerrit-Change-Number: 671535
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Comment-Date: Fri, 23 May 2025 21:50:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
May 27, 2025, 12:58:01 PMMay 27
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Carlos Amedee, Go LUCI, Dmitri Shuralyov, golang-co...@googlegroups.com

Dmitri Shuralyov voted and added 1 comment

Votes added by Dmitri Shuralyov

Auto-Submit+1

1 comment

Patchset-level comments
Dmitri Shuralyov . resolved

Thanks.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I280b6e5b0e7814cb12dfe3ff1de9bb7037fc38ff
Gerrit-Change-Number: 671535
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Comment-Date: Tue, 27 May 2025 16:57:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Gopher Robot (Gerrit)

unread,
May 27, 2025, 12:59:32 PMMay 27
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Carlos Amedee, Go LUCI, Dmitri Shuralyov, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
internal/task: consider failing to set a review a soft failure, part 2/2

Apply an analogous change for GenerateAutoSubmitChange
to mirror what CL 670475 did in CreateAutoSubmitChange.

For golang/go#68276.
Change-Id: I280b6e5b0e7814cb12dfe3ff1de9bb7037fc38ff
Reviewed-by: Carlos Amedee <car...@golang.org>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
Files:
  • M internal/task/cloudbuild.go
Change size: XS
Delta: 1 file changed, 7 insertions(+), 2 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dmitri Shuralyov, +2 by Carlos Amedee
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I280b6e5b0e7814cb12dfe3ff1de9bb7037fc38ff
Gerrit-Change-Number: 671535
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages