[go] runtime: don't describe tracebackcrash as restoring old behavior

2 views
Skip to first unread message

Liz Fong-Jones (Gerrit)

unread,
Sep 28, 2026, 6:29:29 PM (11 days ago) Sep 28
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Pratt

Liz Fong-Jones has uploaded the change for review

Liz Fong-Jones would like Michael Pratt to review this change.

Commit message

runtime: don't describe tracebackcrash as restoring old behavior

GODEBUG=tracebackcrash=1 also throws on an invalid caller PC in
unwinds that tolerated it before Go 1.28, so it does not restore the
old behavior. Just say what it does.

For #80771
Change-Id: I48ac36160f8a658576e43e965820d66a07874cbc

Change diff

diff --git a/src/runtime/extern.go b/src/runtime/extern.go
index ef413fb..af7df77 100644
--- a/src/runtime/extern.go
+++ b/src/runtime/extern.go
@@ -211,9 +211,9 @@
 	report. This also extends the information returned by runtime.Stack.
 	Setting N to 0 will report no ancestry information.
 
-	tracebackcrash: setting tracebackcrash=1 restores the pre-Go 1.28 behavior of
-	throwing a fatal error on an unrecoverable unwind, even for unwinds such as
-	CPU profiling that otherwise tolerate errors and report a truncated stack.
+	tracebackcrash: setting tracebackcrash=1 causes the runtime to throw a fatal
+	error on any unwinding error, even for unwinds such as CPU profiling that
+	otherwise tolerate errors and report a truncated stack.
 
 	tracefpunwindoff: setting tracefpunwindoff=1 forces the execution tracer
 	and block and mutex profilers to use the runtime's default stack

Change information

Files:
  • M src/runtime/extern.go
Change size: XS
Delta: 1 file changed, 3 insertions(+), 3 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Pratt
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I48ac36160f8a658576e43e965820d66a07874cbc
Gerrit-Change-Number: 840865
Gerrit-PatchSet: 1
Gerrit-Owner: Liz Fong-Jones <li...@honeycomb.io>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Cherry Mui (Gerrit)

unread,
Sep 28, 2026, 6:57:03 PM (11 days ago) Sep 28
to Liz Fong-Jones, goph...@pubsubhelper.golang.org, Michael Pratt, golang-co...@googlegroups.com
Attention needed from Liz Fong-Jones and Michael Pratt

Cherry Mui voted and added 1 comment

Votes added by Cherry Mui

Code-Review+2
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Cherry Mui . resolved

Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Liz Fong-Jones
  • Michael Pratt
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I48ac36160f8a658576e43e965820d66a07874cbc
Gerrit-Change-Number: 840865
Gerrit-PatchSet: 1
Gerrit-Owner: Liz Fong-Jones <li...@honeycomb.io>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Liz Fong-Jones <li...@honeycomb.io>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Mon, 28 Sep 2026 22:56:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Pratt (Gerrit)

unread,
Sep 29, 2026, 12:10:36 PM (10 days ago) Sep 29
to Liz Fong-Jones, goph...@pubsubhelper.golang.org, Michael Pratt, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Liz Fong-Jones

Michael Pratt voted

Auto-Submit+1
Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Liz Fong-Jones
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I48ac36160f8a658576e43e965820d66a07874cbc
    Gerrit-Change-Number: 840865
    Gerrit-PatchSet: 1
    Gerrit-Owner: Liz Fong-Jones <li...@honeycomb.io>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-Attention: Liz Fong-Jones <li...@honeycomb.io>
    Gerrit-Comment-Date: Tue, 29 Sep 2026 16:10:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Gopher Robot (Gerrit)

    unread,
    Sep 29, 2026, 12:16:11 PM (10 days ago) Sep 29
    to Liz Fong-Jones, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Pratt, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, golang-co...@googlegroups.com

    Gopher Robot submitted the change

    Change information

    Commit message:
    runtime: don't describe tracebackcrash as restoring old behavior

    GODEBUG=tracebackcrash=1 also throws on an invalid caller PC in
    unwinds that tolerated it before Go 1.28, so it does not restore the
    old behavior. Just say what it does.

    For #80771
    Change-Id: I48ac36160f8a658576e43e965820d66a07874cbc
    Files:
    • M src/runtime/extern.go
    Change size: XS
    Delta: 1 file changed, 3 insertions(+), 3 deletions(-)
    Branch: refs/heads/master
    Submit Requirements:
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I48ac36160f8a658576e43e965820d66a07874cbc
    Gerrit-Change-Number: 840865
    Gerrit-PatchSet: 2
    Gerrit-Owner: Liz Fong-Jones <li...@honeycomb.io>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Gopher Robot <go...@golang.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages