[go] cmd/compile: fix internal compiler error: bad write barrier type

2 views
Skip to first unread message

Francisco Ferraz (Gerrit)

unread,
Feb 26, 2026, 6:03:09 AM (yesterday) Feb 26
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Francisco Ferraz has uploaded the change for review

Commit message

cmd/compile: fix internal compiler error: bad write barrier type

This change fixes an issue where the compiler panics with 'bad
write barrier type' for zero-sized arrays. The loops in
storeTypeScalars and storeTypePtrs erroneously processed
zero-sized arrays causing invalid operations. This ignores them.

Fixes #77815
Change-Id: I0db1b924fc63a75f1bed7488e2dc54d2de5dc0b2

Change diff

diff --git a/src/cmd/compile/internal/ssagen/ssa.go b/src/cmd/compile/internal/ssagen/ssa.go
index 5c4826f..5d54a61 100644
--- a/src/cmd/compile/internal/ssagen/ssa.go
+++ b/src/cmd/compile/internal/ssagen/ssa.go
@@ -5673,6 +5673,8 @@
 		}
 	case t.IsArray() && t.NumElem() == 0:
 		// nothing
+	case t.IsArray() && (t.NumElem() == 0 || t.Size() == 0):
+		// nothing
 	case t.IsArray() && t.NumElem() == 1:
 		s.storeTypeScalars(t.Elem(), left, s.newValue1I(ssa.OpArraySelect, t.Elem(), 0, right), 0)
 	default:
@@ -5711,7 +5713,7 @@
 			val := s.newValue1I(ssa.OpStructSelect, ft, int64(i), right)
 			s.storeTypePtrs(ft, addr, val)
 		}
-	case t.IsArray() && t.NumElem() == 0:
+	case t.IsArray() && (t.NumElem() == 0 || t.Size() == 0):
 		// nothing
 	case t.IsArray() && t.NumElem() == 1:
 		s.storeTypePtrs(t.Elem(), left, s.newValue1I(ssa.OpArraySelect, t.Elem(), 0, right))
diff --git a/test/fixedbugs/issue77815.go b/test/fixedbugs/issue77815.go
new file mode 100644
index 0000000..64feffe
--- /dev/null
+++ b/test/fixedbugs/issue77815.go
@@ -0,0 +1,17 @@
+// compile
+
+// Copyright 2026 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package p
+
+type S struct {
+	a [4]struct{}
+	c chan int
+}
+
+func f(x int, m map[int]S) {
+	var s S
+	m[x] = s
+}

Change information

Files:
  • M src/cmd/compile/internal/ssagen/ssa.go
  • A test/fixedbugs/issue77815.go
Change size: S
Delta: 2 files changed, 20 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I0db1b924fc63a75f1bed7488e2dc54d2de5dc0b2
Gerrit-Change-Number: 749380
Gerrit-PatchSet: 1
Gerrit-Owner: Francisco Ferraz <francisc...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Francisco Ferraz (Gerrit)

unread,
Feb 26, 2026, 6:14:11 AM (yesterday) Feb 26
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Keith Randall

Francisco Ferraz uploaded new patchset

Francisco Ferraz uploaded patch set #2 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Keith Randall
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I0db1b924fc63a75f1bed7488e2dc54d2de5dc0b2
Gerrit-Change-Number: 749380
Gerrit-PatchSet: 2
Gerrit-Owner: Francisco Ferraz <francisc...@gmail.com>
Gerrit-Reviewer: Keith Randall <k...@google.com>
Gerrit-Attention: Keith Randall <k...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Mateusz Poliwczak (Gerrit)

unread,
Feb 26, 2026, 7:47:49 AM (yesterday) Feb 26
to Francisco Ferraz, goph...@pubsubhelper.golang.org, Keith Randall, golang-co...@googlegroups.com
Attention needed from Francisco Ferraz and Keith Randall

Mateusz Poliwczak added 1 comment

File src/cmd/compile/internal/ssagen/ssa.go
Line 5674, Patchset 2 (Latest): case t.IsArray() && (t.NumElem() == 0 || t.Size() == 0):
Mateusz Poliwczak . unresolved
```suggestion
	case t.IsArray() && t.Size() == 0:
```

Isn't the `NumElem` redundant now?

Open in Gerrit

Related details

Attention is currently required from:
  • Francisco Ferraz
  • Keith Randall
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I0db1b924fc63a75f1bed7488e2dc54d2de5dc0b2
    Gerrit-Change-Number: 749380
    Gerrit-PatchSet: 2
    Gerrit-Owner: Francisco Ferraz <francisc...@gmail.com>
    Gerrit-Reviewer: Keith Randall <k...@google.com>
    Gerrit-CC: Mateusz Poliwczak <mpoliw...@gmail.com>
    Gerrit-Attention: Francisco Ferraz <francisc...@gmail.com>
    Gerrit-Attention: Keith Randall <k...@google.com>
    Gerrit-Comment-Date: Thu, 26 Feb 2026 12:47:42 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Mateusz Poliwczak (Gerrit)

    unread,
    Feb 26, 2026, 8:44:22 AM (yesterday) Feb 26
    to Francisco Ferraz, goph...@pubsubhelper.golang.org, Keith Randall, golang-co...@googlegroups.com
    Attention needed from Francisco Ferraz and Keith Randall

    Mateusz Poliwczak added 1 comment

    File test/fixedbugs/issue77815.go
    Line 7, Patchset 2 (Latest):package p

    type S struct {
    a [4]struct{}
    c chan int

    }

    func f(x int, m map[int]S) {
    var s S
    m[x] = s
    }
    Mateusz Poliwczak . unresolved

    ```suggestion
    package p

    type S struct {
    	a [4]struct{}
    	f chan int
    }
    func f(p *S) {
    	var s S
    	// Memory write that requires a write barrier should work
    	// with structs having zero-sized arrays of non-zero elements.
    	*p = s
    }
    ```


    This bug is not related to maps, we could avoid the confusion and a bit of comment can help, since not that complex to explain the issue.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Francisco Ferraz
    • Keith Randall
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I0db1b924fc63a75f1bed7488e2dc54d2de5dc0b2
    Gerrit-Change-Number: 749380
    Gerrit-PatchSet: 2
    Gerrit-Owner: Francisco Ferraz <francisc...@gmail.com>
    Gerrit-Reviewer: Keith Randall <k...@google.com>
    Gerrit-CC: Mateusz Poliwczak <mpoliw...@gmail.com>
    Gerrit-Attention: Francisco Ferraz <francisc...@gmail.com>
    Gerrit-Attention: Keith Randall <k...@google.com>
    Gerrit-Comment-Date: Thu, 26 Feb 2026 13:44:15 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Keith Randall (Gerrit)

    unread,
    Feb 26, 2026, 11:40:49 AM (yesterday) Feb 26
    to Francisco Ferraz, goph...@pubsubhelper.golang.org, Keith Randall, Mateusz Poliwczak, Keith Randall, golang-co...@googlegroups.com
    Attention needed from Francisco Ferraz and Keith Randall

    Keith Randall added 2 comments

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Keith Randall . resolved

    Thanks.

    File src/cmd/compile/internal/ssagen/ssa.go
    Line 5674, Patchset 2 (Latest): case t.IsArray() && (t.NumElem() == 0 || t.Size() == 0):
    Mateusz Poliwczak . unresolved
    ```suggestion

    	case t.IsArray() && t.Size() == 0:
    ```

    Isn't the `NumElem` redundant now?

    Keith Randall

    Probably even better to just put t.Size() == 0 as the first case. (Like zeroVal.)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Francisco Ferraz
    • Keith Randall
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I0db1b924fc63a75f1bed7488e2dc54d2de5dc0b2
    Gerrit-Change-Number: 749380
    Gerrit-PatchSet: 2
    Gerrit-Owner: Francisco Ferraz <francisc...@gmail.com>
    Gerrit-Reviewer: Keith Randall <k...@google.com>
    Gerrit-CC: Keith Randall <k...@golang.org>
    Gerrit-CC: Mateusz Poliwczak <mpoliw...@gmail.com>
    Gerrit-Attention: Francisco Ferraz <francisc...@gmail.com>
    Gerrit-Attention: Keith Randall <k...@google.com>
    Gerrit-Comment-Date: Thu, 26 Feb 2026 16:40:44 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Mateusz Poliwczak <mpoliw...@gmail.com>
    unsatisfied_requirement
    open
    diffy

    David Chase (Gerrit)

    unread,
    Feb 26, 2026, 11:55:32 AM (yesterday) Feb 26
    to Francisco Ferraz, goph...@pubsubhelper.golang.org, Keith Randall, Mateusz Poliwczak, Keith Randall, golang-co...@googlegroups.com
    Attention needed from Francisco Ferraz and Keith Randall

    David Chase voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Francisco Ferraz
    • Keith Randall
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I0db1b924fc63a75f1bed7488e2dc54d2de5dc0b2
    Gerrit-Change-Number: 749380
    Gerrit-PatchSet: 2
    Gerrit-Owner: Francisco Ferraz <francisc...@gmail.com>
    Gerrit-Reviewer: David Chase <drc...@google.com>
    Gerrit-Reviewer: Keith Randall <k...@google.com>
    Gerrit-CC: Keith Randall <k...@golang.org>
    Gerrit-CC: Mateusz Poliwczak <mpoliw...@gmail.com>
    Gerrit-Attention: Francisco Ferraz <francisc...@gmail.com>
    Gerrit-Attention: Keith Randall <k...@google.com>
    Gerrit-Comment-Date: Thu, 26 Feb 2026 16:55:28 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    open
    diffy

    Francisco Ferraz (Gerrit)

    unread,
    Feb 26, 2026, 12:35:02 PM (yesterday) Feb 26
    to goph...@pubsubhelper.golang.org, Go LUCI, David Chase, Keith Randall, Mateusz Poliwczak, Keith Randall, golang-co...@googlegroups.com
    Attention needed from Keith Randall and Mateusz Poliwczak

    Francisco Ferraz added 1 comment

    File test/fixedbugs/issue77815.go
    Line 7, Patchset 2 (Latest):package p

    type S struct {
    a [4]struct{}
    c chan int
    }

    func f(x int, m map[int]S) {
    var s S
    m[x] = s
    }
    Mateusz Poliwczak . unresolved

    ```suggestion
    package p

    type S struct {
    	a [4]struct{}
    	f chan int
    }
    func f(p *S) {
    	var s S
    	// Memory write that requires a write barrier should work
    	// with structs having zero-sized arrays of non-zero elements.
    	*p = s
    }
    ```


    This bug is not related to maps, we could avoid the confusion and a bit of comment can help, since not that complex to explain the issue.

    Francisco Ferraz

    Thank you for the quick reply, I will fix this issue as soon as possible.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Keith Randall
    • Mateusz Poliwczak
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I0db1b924fc63a75f1bed7488e2dc54d2de5dc0b2
      Gerrit-Change-Number: 749380
      Gerrit-PatchSet: 2
      Gerrit-Owner: Francisco Ferraz <francisc...@gmail.com>
      Gerrit-Reviewer: David Chase <drc...@google.com>
      Gerrit-Reviewer: Keith Randall <k...@google.com>
      Gerrit-CC: Keith Randall <k...@golang.org>
      Gerrit-CC: Mateusz Poliwczak <mpoliw...@gmail.com>
      Gerrit-Attention: Mateusz Poliwczak <mpoliw...@gmail.com>
      Gerrit-Attention: Keith Randall <k...@google.com>
      Gerrit-Comment-Date: Thu, 26 Feb 2026 17:34:53 +0000
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Francisco Ferraz (Gerrit)

      unread,
      12:32 PM (3 hours ago) 12:32 PM
      to goph...@pubsubhelper.golang.org, Go LUCI, David Chase, Keith Randall, Mateusz Poliwczak, Keith Randall, golang-co...@googlegroups.com
      Attention needed from Keith Randall, Keith Randall and Mateusz Poliwczak

      Francisco Ferraz added 2 comments

      File src/cmd/compile/internal/ssagen/ssa.go
      Line 5674, Patchset 2 (Latest): case t.IsArray() && (t.NumElem() == 0 || t.Size() == 0):
      Mateusz Poliwczak . resolved
      ```suggestion
      	case t.IsArray() && t.Size() == 0:
      ```

      Isn't the `NumElem` redundant now?

      Keith Randall

      Probably even better to just put t.Size() == 0 as the first case. (Like zeroVal.)

      Francisco Ferraz

      Fix applied.

      File test/fixedbugs/issue77815.go
      Line 7, Patchset 2 (Latest):package p

      type S struct {
      a [4]struct{}
      c chan int
      }

      func f(x int, m map[int]S) {
      var s S
      m[x] = s
      }
      Mateusz Poliwczak . resolved

      ```suggestion
      package p

      type S struct {
      	a [4]struct{}
      	f chan int
      }
      func f(p *S) {
      	var s S
      	// Memory write that requires a write barrier should work
      	// with structs having zero-sized arrays of non-zero elements.
      	*p = s
      }
      ```


      This bug is not related to maps, we could avoid the confusion and a bit of comment can help, since not that complex to explain the issue.

      Francisco Ferraz

      Thank you for the quick reply, I will fix this issue as soon as possible.

      Francisco Ferraz

      Fix applied.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Keith Randall
      • Keith Randall
      • Mateusz Poliwczak
      Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I0db1b924fc63a75f1bed7488e2dc54d2de5dc0b2
        Gerrit-Change-Number: 749380
        Gerrit-PatchSet: 2
        Gerrit-Owner: Francisco Ferraz <francisc...@gmail.com>
        Gerrit-Reviewer: David Chase <drc...@google.com>
        Gerrit-Reviewer: Keith Randall <k...@google.com>
        Gerrit-CC: Keith Randall <k...@golang.org>
        Gerrit-CC: Mateusz Poliwczak <mpoliw...@gmail.com>
        Gerrit-Attention: Keith Randall <k...@golang.org>
        Gerrit-Attention: Mateusz Poliwczak <mpoliw...@gmail.com>
        Gerrit-Attention: Keith Randall <k...@google.com>
        Gerrit-Comment-Date: Fri, 27 Feb 2026 17:32:49 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Keith Randall <k...@golang.org>
        Comment-In-Reply-To: Mateusz Poliwczak <mpoliw...@gmail.com>
        Comment-In-Reply-To: Francisco Ferraz <francisc...@gmail.com>
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Keith Randall (Gerrit)

        unread,
        12:47 PM (3 hours ago) 12:47 PM
        to Francisco Ferraz, goph...@pubsubhelper.golang.org, Go LUCI, David Chase, Keith Randall, Mateusz Poliwczak, Keith Randall, golang-co...@googlegroups.com
        Attention needed from Francisco Ferraz, Keith Randall and Mateusz Poliwczak

        Keith Randall added 1 comment

        Patchset-level comments
        Keith Randall . unresolved

        I don't see a new patchset?

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Francisco Ferraz
        • Keith Randall
        • Mateusz Poliwczak
        Submit Requirements:
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: I0db1b924fc63a75f1bed7488e2dc54d2de5dc0b2
          Gerrit-Change-Number: 749380
          Gerrit-PatchSet: 2
          Gerrit-Owner: Francisco Ferraz <francisc...@gmail.com>
          Gerrit-Reviewer: David Chase <drc...@google.com>
          Gerrit-Reviewer: Keith Randall <k...@google.com>
          Gerrit-CC: Keith Randall <k...@golang.org>
          Gerrit-CC: Mateusz Poliwczak <mpoliw...@gmail.com>
          Gerrit-Attention: Mateusz Poliwczak <mpoliw...@gmail.com>
          Gerrit-Attention: Francisco Ferraz <francisc...@gmail.com>
          Gerrit-Attention: Keith Randall <k...@google.com>
          Gerrit-Comment-Date: Fri, 27 Feb 2026 17:46:59 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          unsatisfied_requirement
          satisfied_requirement
          open
          diffy

          Mateusz Poliwczak (Gerrit)

          unread,
          1:09 PM (2 hours ago) 1:09 PM
          to Francisco Ferraz, goph...@pubsubhelper.golang.org, Go LUCI, David Chase, Keith Randall, Keith Randall, golang-co...@googlegroups.com
          Attention needed from Francisco Ferraz and Keith Randall

          Mateusz Poliwczak added 1 comment

          File src/cmd/compile/internal/ssagen/ssa.go
          Line 5714, Patchset 3 (Latest): case t.IsArray() && (t.NumElem() == 0 || t.Size() == 0):
          Mateusz Poliwczak . unresolved

          also here

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Francisco Ferraz
          • Keith Randall
          Submit Requirements:
            • requirement is not satisfiedCode-Review
            • requirement is not satisfiedNo-Unresolved-Comments
            • requirement is not satisfiedReview-Enforcement
            • requirement is not satisfiedTryBots-Pass
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: go
            Gerrit-Branch: master
            Gerrit-Change-Id: I0db1b924fc63a75f1bed7488e2dc54d2de5dc0b2
            Gerrit-Change-Number: 749380
            Gerrit-PatchSet: 3
            Gerrit-Owner: Francisco Ferraz <francisc...@gmail.com>
            Gerrit-Reviewer: David Chase <drc...@google.com>
            Gerrit-Reviewer: Keith Randall <k...@google.com>
            Gerrit-CC: Keith Randall <k...@golang.org>
            Gerrit-CC: Mateusz Poliwczak <mpoliw...@gmail.com>
            Gerrit-Attention: Francisco Ferraz <francisc...@gmail.com>
            Gerrit-Attention: Keith Randall <k...@google.com>
            Gerrit-Comment-Date: Fri, 27 Feb 2026 18:09:51 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            unsatisfied_requirement
            open
            diffy

            Francisco Ferraz (Gerrit)

            unread,
            1:19 PM (2 hours ago) 1:19 PM
            to goph...@pubsubhelper.golang.org, Go LUCI, David Chase, Keith Randall, Mateusz Poliwczak, Keith Randall, golang-co...@googlegroups.com
            Attention needed from Keith Randall, Keith Randall and Mateusz Poliwczak

            Francisco Ferraz added 2 comments

            Patchset-level comments
            File-level comment, Patchset 2:
            Keith Randall . resolved

            I don't see a new patchset?

            Francisco Ferraz

            Check again please, i retried the submission.

            File src/cmd/compile/internal/ssagen/ssa.go
            Line 5714, Patchset 3: case t.IsArray() && (t.NumElem() == 0 || t.Size() == 0):
            Mateusz Poliwczak . resolved

            also here

            Francisco Ferraz

            Done

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Keith Randall
            • Keith Randall
            • Mateusz Poliwczak
            Submit Requirements:
              • requirement is not satisfiedCode-Review
              • requirement satisfiedNo-Unresolved-Comments
              • requirement is not satisfiedReview-Enforcement
              • requirement is not satisfiedTryBots-Pass
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: go
              Gerrit-Branch: master
              Gerrit-Change-Id: I0db1b924fc63a75f1bed7488e2dc54d2de5dc0b2
              Gerrit-Change-Number: 749380
              Gerrit-PatchSet: 4
              Gerrit-Owner: Francisco Ferraz <francisc...@gmail.com>
              Gerrit-Reviewer: David Chase <drc...@google.com>
              Gerrit-Reviewer: Keith Randall <k...@google.com>
              Gerrit-CC: Keith Randall <k...@golang.org>
              Gerrit-CC: Mateusz Poliwczak <mpoliw...@gmail.com>
              Gerrit-Attention: Keith Randall <k...@golang.org>
              Gerrit-Attention: Mateusz Poliwczak <mpoliw...@gmail.com>
              Gerrit-Attention: Keith Randall <k...@google.com>
              Gerrit-Comment-Date: Fri, 27 Feb 2026 18:19:10 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: No
              unsatisfied_requirement
              satisfied_requirement
              open
              diffy
              Reply all
              Reply to author
              Forward
              0 new messages