[go] net: add test case (WIP)
2 views
Skip to first unread message
Mateusz Poliwczak (Gerrit)
Feb 2, 2026, 1:47:50 PM (5 days ago) Feb 2
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Mateusz Poliwczak has uploaded the change for review![]( "Open in Gerrit")
Commit message
net: add test case (WIP)
Change-Id: Ibb76bfeb2b7974301d3515d90517d7766a6a6964
Change diff
diff --git a/src/net/dnsclient_unix_test.go b/src/net/dnsclient_unix_test.go
index fc1d40f..73ce383 100644
--- a/src/net/dnsclient_unix_test.go
+++ b/src/net/dnsclient_unix_test.go
@@ -2855,3 +2855,50 @@
t.Fatalf("r.tryOneName(): unexpected error: %v", err)
}
}
+
+// TODO: test name is bad
+func TestEmptyResolvConfUpdatedWithNew(t *testing.T) {
+ conf, err := newResolvConfTest()
+ if err != nil {
+ t.Fatal(err)
+ }
+ defer conf.teardown()
+
+ path := filepath.Join(t.TempDir(), "empty-resolv.conf")
+ f, err := os.Create(path)
+ if err != nil {
+ t.Fatal(err)
+ }
+ defer f.Close()
+
+ if _, err := f.WriteString("# Empty resolv.conf file\n"); err != nil {
+ t.Fatal(err)
+ }
+
+ if err := conf.forceUpdate(path, time.Now()); err != nil {
+ t.Fatal(err)
+ }
+
+ // Same as the pacakge scoped [getSystemDNSConfig], but with
+ // a different path specified.
+ getSystemDNSConfig := func() *dnsConfig {
+ resolvConf.tryUpdate(path)
+ return resolvConf.dnsConfig.Load()
+ }
+
+ if _, err := f.WriteString("nameserver 1.1.1.1"); err != nil {
+ t.Fatal(err)
+ }
+
+ var wg sync.WaitGroup
+
+ for range 200 {
+ wg.Go(func() {
+ if len(getSystemDNSConfig().servers) == 0 {
+ t.Error("got zero nameservers")
+ }
+ })
+ }
+
+ wg.Wait()
+}
Change information
Files:
- M src/net/dnsclient_unix_test.go
Change size: S
Delta: 1 file changed, 47 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mateusz Poliwczak (Gerrit)
4:58 AM (10 hours ago) 4:58 AM
to goph...@pubsubhelper.golang.org, Go LUCI, Brad Fitzpatrick, Damien Neil, Ian Lance Taylor, golang-co...@googlegroups.com
Attention needed from Damien Neil and Ian Lance Taylor
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Damien Neil
- Ian Lance Taylor
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mateusz Poliwczak (Gerrit)
8:11 AM (7 hours ago) 8:11 AM
to goph...@pubsubhelper.golang.org, Go LUCI, Brad Fitzpatrick, Damien Neil, Ian Lance Taylor, golang-co...@googlegroups.com
Attention needed from Damien Neil and Ian Lance Taylor
Mateusz Poliwczak voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Damien Neil
- Ian Lance Taylor
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mateusz Poliwczak (Gerrit)
11:11 AM (4 hours ago) 11:11 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Damien Neil and Ian Lance Taylor
Mateusz Poliwczak uploaded new patchset![]( "Open in Gerrit")
Mateusz Poliwczak uploaded patch set #8 to this change.
Related details
Attention is currently required from:
- Damien Neil
- Ian Lance Taylor
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages