[crypto] sha3: Avo implementation of keccakf_amd64.s
8 views
Skip to first unread message
Garrett (Gerrit)
Jun 24, 2024, 7:17:37 PM (9 days ago) Jun 24
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Garrett has uploaded the change for review![]( "Open in Gerrit")
Commit message
sha3: Avo implementation of keccakf_amd64.s
This implementation utilizes the same registers found in the original
assembly to minimize the diff between Avo output and keccakf_amd64.s
Diff output (Found 6 Lines that differ):
https://gist.github.com/Garrett-Bodley/d6786031af6405287fd762192c086c88
Commands used to check validity of Avo code:
cd _asm && go run keccakf_amd64_asm.go > ../keccakf_amd64_avo.s
cd ../ && go tool asm -o compiled_avo keccakf_amd64_avo.s
go tool objdump compiled_avo | awk '{$1=$2=""; print substr($0,3)}'
Change-Id: I1c0ea516531355263b83d3b66a37df090e293cea
Change diff
diff --git a/sha3/_asm/keccakf_amd64_asm.go b/sha3/_asm/keccakf_amd64_asm.go
new file mode 100644
index 0000000..bfb4407
--- /dev/null
+++ b/sha3/_asm/keccakf_amd64_asm.go
@@ -0,0 +1,434 @@
+// Copyright 2023 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package main
+
+import (
+ . "github.com/mmcloughlin/avo/build"
+ . "github.com/mmcloughlin/avo/operand"
+ . "github.com/mmcloughlin/avo/reg"
+)
+
+//go:generate go run . -out ../keccakf_amd64.s -pkg sha3
+
+// Round Constants for use in the ι step.
+var RoundConstants = [24]uint64{
+ 0x0000000000000001,
+ 0x0000000000008082,
+ 0x800000000000808A,
+ 0x8000000080008000,
+ 0x000000000000808B,
+ 0x0000000080000001,
+ 0x8000000080008081,
+ 0x8000000000008009,
+ 0x000000000000008A,
+ 0x0000000000000088,
+ 0x0000000080008009,
+ 0x000000008000000A,
+ 0x000000008000808B,
+ 0x800000000000008B,
+ 0x8000000000008089,
+ 0x8000000000008003,
+ 0x8000000000008002,
+ 0x8000000000000080,
+ 0x000000000000800A,
+ 0x800000008000000A,
+ 0x8000000080008081,
+ 0x8000000000008080,
+ 0x0000000080000001,
+ 0x8000000080008008,
+}
+
+var (
+ // Temporary registers
+ rT1 GPPhysical = RAX
+
+ // Round vars
+ rpState = RDI
+ rpStack = RSP
+
+ rDa = RBX
+ rDe = RCX
+ rDi = RDX
+ rDo = R8
+ rDu = R9
+
+ rBa = R10
+ rBe = R11
+ rBi = R12
+ rBo = R13
+ rBu = R14
+
+ rCa = RSI
+ rCe = RBP
+ rCi = rBi
+ rCo = rBo
+ rCu = R15
+)
+
+const (
+ _ba = iota * 8
+ _be
+ _bi
+ _bo
+ _bu
+ _ga
+ _ge
+ _gi
+ _go
+ _gu
+ _ka
+ _ke
+ _ki
+ _ko
+ _ku
+ _ma
+ _me
+ _mi
+ _mo
+ _mu
+ _sa
+ _se
+ _si
+ _so
+ _su
+)
+
+func main() {
+ Package("golang.org/x/crypto/sha3")
+ ConstraintExpr("amd64,!purego,gc")
+ keccakF1600()
+ Generate()
+}
+
+func MOVQ_RBI_RCE() { MOVQ(rBi, rCe) }
+func XORQ_RT1_RCA() { XORQ(rT1, rCa) }
+func XORQ_RT1_RCE() { XORQ(rT1, rCe) }
+func XORQ_RBA_RCU() { XORQ(rBa, rCu) }
+func XORQ_RBE_RCU() { XORQ(rBe, rCu) }
+func XORQ_RDU_RCU() { XORQ(rDu, rCu) }
+func XORQ_RDA_RCA() { XORQ(rDa, rCa) }
+func XORQ_RDE_RCE() { XORQ(rDe, rCe) }
+
+type ArgMacro func()
+
+func mKeccakRound(
+ iState, oState GPPhysical,
+ rc U64,
+ B_RBI_RCE, G_RT1_RCA, G_RT1_RCE, G_RBA_RCU,
+ K_RT1_RCA, K_RT1_RCE, K_RBA_RCU, M_RT1_RCA,
+ M_RT1_RCE, M_RBE_RCU, S_RDU_RCU, S_RDA_RCA,
+ S_RDE_RCE ArgMacro,
+) {
+ Comment("Prepare round")
+ MOVQ(rCe, rDa)
+ ROLQ(Imm(1), rDa)
+
+ MOVQ(Mem{Base: iState}.Offset(_bi), rCi)
+ XORQ(Mem{Base: iState}.Offset(_gi), rDi)
+ XORQ(rCu, rDa)
+ XORQ(Mem{Base: iState}.Offset(_ki), rCi)
+ XORQ(Mem{Base: iState}.Offset(_mi), rDi)
+ XORQ(rDi, rCi)
+
+ MOVQ(rCi, rDe)
+ ROLQ(Imm(1), rDe)
+
+ MOVQ(Mem{Base: iState}.Offset(_bo), rCo)
+ XORQ(Mem{Base: iState}.Offset(_go), rDo)
+ XORQ(rCa, rDe)
+ XORQ(Mem{Base: iState}.Offset(_ko), rCo)
+ XORQ(Mem{Base: iState}.Offset(_mo), rDo)
+ XORQ(rDo, rCo)
+
+ MOVQ(rCo, rDi)
+ ROLQ(Imm(1), rDi)
+
+ MOVQ(rCu, rDo)
+ XORQ(rCe, rDi)
+ ROLQ(Imm(1), rDo)
+
+ MOVQ(rCa, rDu)
+ XORQ(rCi, rDo)
+ ROLQ(Imm(1), rDu)
+
+ Comment("Result b")
+ MOVQ(Mem{Base: iState}.Offset(_ba), rBa)
+ MOVQ(Mem{Base: iState}.Offset(_ge), rBe)
+ XORQ(rCo, rDu)
+ MOVQ(Mem{Base: iState}.Offset(_ki), rBi)
+ MOVQ(Mem{Base: iState}.Offset(_mo), rBo)
+ MOVQ(Mem{Base: iState}.Offset(_su), rBu)
+ XORQ(rDe, rBe)
+ ROLQ(Imm(44), rBe)
+ XORQ(rDi, rBi)
+ XORQ(rDa, rBa)
+ ROLQ(Imm(43), rBi)
+
+ MOVQ(rBe, rCa)
+ MOVQ(rc, rT1)
+ ORQ(rBi, rCa)
+ XORQ(rBa, rT1)
+ XORQ(rT1, rCa)
+ MOVQ(rCa, Mem{Base: oState}.Offset(_ba))
+
+ XORQ(rDu, rBu)
+ ROLQ(Imm(14), rBu)
+ MOVQ(rBa, rCu)
+ ANDQ(rBe, rCu)
+ XORQ(rBu, rCu)
+ MOVQ(rCu, Mem{Base: oState}.Offset(_bu))
+
+ XORQ(rDo, rBo)
+ ROLQ(Imm(21), rBo)
+ MOVQ(rBo, rT1)
+ ANDQ(rBu, rT1)
+ XORQ(rBi, rT1)
+ MOVQ(rT1, Mem{Base: oState}.Offset(_bi))
+
+ NOTQ(rBi)
+ ORQ(rBa, rBu)
+ ORQ(rBo, rBi)
+ XORQ(rBo, rBu)
+ XORQ(rBe, rBi)
+ MOVQ(rBu, Mem{Base: oState}.Offset(_bo))
+ MOVQ(rBi, Mem{Base: oState}.Offset(_be))
+ B_RBI_RCE()
+
+ Comment("Result g")
+ MOVQ(Mem{Base: iState}.Offset(_gu), rBe)
+ XORQ(rDu, rBe)
+ MOVQ(Mem{Base: iState}.Offset(_ka), rBi)
+ ROLQ(Imm(20), rBe)
+ XORQ(rDa, rBi)
+ ROLQ(Imm(3), rBi)
+ MOVQ(Mem{Base: iState}.Offset(_bo), rBa)
+ MOVQ(rBe, rT1)
+ ORQ(rBi, rT1)
+ XORQ(rDo, rBa)
+ MOVQ(Mem{Base: iState}.Offset(_me), rBo)
+ MOVQ(Mem{Base: iState}.Offset(_si), rBu)
+ ROLQ(Imm(28), rBa)
+ XORQ(rBa, rT1)
+ MOVQ(rT1, Mem{Base: oState}.Offset(_ga))
+ G_RT1_RCA()
+
+ XORQ(rDe, rBo)
+ ROLQ(Imm(45), rBo)
+ MOVQ(rBi, rT1)
+ ANDQ(rBo, rT1)
+ XORQ(rBe, rT1)
+ MOVQ(rT1, Mem{Base: oState}.Offset(_ge))
+ G_RT1_RCE()
+
+ XORQ(rDi, rBu)
+ ROLQ(Imm(61), rBu)
+ MOVQ(rBu, rT1)
+ ORQ(rBa, rT1)
+ XORQ(rBo, rT1)
+ MOVQ(rT1, Mem{Base: oState}.Offset(_go))
+
+ ANDQ(rBe, rBa)
+ XORQ(rBu, rBa)
+ MOVQ(rBa, Mem{Base: oState}.Offset(_gu))
+ NOTQ(rBu)
+ G_RBA_RCU()
+
+ ORQ(rBu, rBo)
+ XORQ(rBi, rBo)
+ MOVQ(rBo, Mem{Base: oState}.Offset(_gi))
+
+ Comment("Result k")
+ MOVQ(Mem{Base: iState}.Offset(_be), rBa)
+ MOVQ(Mem{Base: iState}.Offset(_gi), rBe)
+ MOVQ(Mem{Base: iState}.Offset(_ko), rBi)
+ MOVQ(Mem{Base: iState}.Offset(_mu), rBo)
+ MOVQ(Mem{Base: iState}.Offset(_sa), rBu)
+ XORQ(rDi, rBe)
+ ROLQ(Imm(6), rBe)
+ XORQ(rDo, rBi)
+ ROLQ(Imm(25), rBi)
+ MOVQ(rBe, rT1)
+ ORQ(rBi, rT1)
+ XORQ(rDe, rBa)
+ ROLQ(Imm(1), rBa)
+ XORQ(rBa, rT1)
+ MOVQ(rT1, Mem{Base: oState}.Offset(_ka))
+ K_RT1_RCA()
+
+ XORQ(rDu, rBo)
+ ROLQ(Imm(8), rBo)
+ MOVQ(rBi, rT1)
+ ANDQ(rBo, rT1)
+ XORQ(rBe, rT1)
+ MOVQ(rT1, Mem{Base: oState}.Offset(_ke))
+ K_RT1_RCE()
+
+ XORQ(rDa, rBu)
+ ROLQ(Imm(18), rBu)
+ NOTQ(rBo)
+ MOVQ(rBo, rT1)
+ ANDQ(rBu, rT1)
+ XORQ(rBi, rT1)
+ MOVQ(rT1, Mem{Base: oState}.Offset(_ki))
+
+ MOVQ(rBu, rT1)
+ ORQ(rBa, rT1)
+ XORQ(rBo, rT1)
+ MOVQ(rT1, Mem{Base: oState}.Offset(_ko))
+
+ ANDQ(rBe, rBa)
+ XORQ(rBu, rBa)
+ MOVQ(rBa, Mem{Base: oState}.Offset(_ku))
+ K_RBA_RCU()
+
+ Comment("Result m")
+ MOVQ(Mem{Base: iState}.Offset(_ga), rBe)
+ XORQ(rDa, rBe)
+ MOVQ(Mem{Base: iState}.Offset(_ke), rBi)
+ ROLQ(Imm(36), rBe)
+ XORQ(rDe, rBi)
+ MOVQ(Mem{Base: iState}.Offset(_bu), rBa)
+ ROLQ(Imm(10), rBi)
+ MOVQ(rBe, rT1)
+ MOVQ(Mem{Base: iState}.Offset(_mi), rBo)
+ ANDQ(rBi, rT1)
+ XORQ(rDu, rBa)
+ MOVQ(Mem{Base: iState}.Offset(_so), rBu)
+ ROLQ(Imm(27), rBa)
+ XORQ(rBa, rT1)
+ MOVQ(rT1, Mem{Base: oState}.Offset(_ma))
+ M_RT1_RCA()
+
+ XORQ(rDi, rBo)
+ ROLQ(Imm(15), rBo)
+ MOVQ(rBi, rT1)
+ ORQ(rBo, rT1)
+ XORQ(rBe, rT1)
+ MOVQ(rT1, Mem{Base: oState}.Offset(_me))
+ M_RT1_RCE()
+
+ XORQ(rDo, rBu)
+ ROLQ(Imm(56), rBu)
+ NOTQ(rBo)
+ MOVQ(rBo, rT1)
+ ORQ(rBu, rT1)
+ XORQ(rBi, rT1)
+ MOVQ(rT1, Mem{Base: oState}.Offset(_mi))
+
+ ORQ(rBa, rBe)
+ XORQ(rBu, rBe)
+ MOVQ(rBe, Mem{Base: oState}.Offset(_mu))
+
+ ANDQ(rBa, rBu)
+ XORQ(rBo, rBu)
+ MOVQ(rBu, Mem{Base: oState}.Offset(_mo))
+ M_RBE_RCU()
+
+ Comment("Result s")
+ MOVQ(Mem{Base: iState}.Offset(_bi), rBa)
+ MOVQ(Mem{Base: iState}.Offset(_go), rBe)
+ MOVQ(Mem{Base: iState}.Offset(_ku), rBi)
+ XORQ(rDi, rBa)
+ MOVQ(Mem{Base: iState}.Offset(_ma), rBo)
+ ROLQ(Imm(62), rBa)
+ XORQ(rDo, rBe)
+ MOVQ(Mem{Base: iState}.Offset(_se), rBu)
+ ROLQ(Imm(55), rBe)
+
+ XORQ(rDu, rBi)
+ MOVQ(rBa, rDu)
+ XORQ(rDe, rBu)
+ ROLQ(Imm(2), rBu)
+ ANDQ(rBe, rDu)
+ XORQ(rBu, rDu)
+ MOVQ(rDu, Mem{Base: oState}.Offset(_su))
+
+ ROLQ(Imm(39), rBi)
+ S_RDU_RCU()
+ NOTQ(rBe)
+ XORQ(rDa, rBo)
+ MOVQ(rBe, rDa)
+ ANDQ(rBi, rDa)
+ XORQ(rBa, rDa)
+ MOVQ(rDa, Mem{Base: oState}.Offset(_sa))
+ S_RDA_RCA()
+
+ ROLQ(Imm(41), rBo)
+ MOVQ(rBi, rDe)
+ ORQ(rBo, rDe)
+ XORQ(rBe, rDe)
+ MOVQ(rDe, Mem{Base: oState}.Offset(_se))
+ S_RDE_RCE()
+
+ MOVQ(rBo, rDi)
+ MOVQ(rBu, rDo)
+ ANDQ(rBu, rDi)
+ ORQ(rBa, rDo)
+ XORQ(rBi, rDi)
+ XORQ(rBo, rDo)
+ MOVQ(rDi, Mem{Base: oState}.Offset(_si))
+ MOVQ(rDo, Mem{Base: oState}.Offset(_so))
+}
+
+// keccakF1600 applies the Keccak permutation to a 1600b-wide
+// state represented as a slice of 25 uint64s.
+func keccakF1600() {
+ Implement("keccakF1600")
+ AllocLocal(200)
+
+ Load(Param("a"), rpState)
+
+ Comment("Convert the user state into an internal state")
+ NOTQ(Mem{Base: rpState}.Offset(_be))
+ NOTQ(Mem{Base: rpState}.Offset(_bi))
+ NOTQ(Mem{Base: rpState}.Offset(_go))
+ NOTQ(Mem{Base: rpState}.Offset(_ki))
+ NOTQ(Mem{Base: rpState}.Offset(_mi))
+ NOTQ(Mem{Base: rpState}.Offset(_sa))
+
+ Comment("Execute the KeccakF permutation")
+ MOVQ(Mem{Base: rpState}.Offset(_ba), rCa)
+ MOVQ(Mem{Base: rpState}.Offset(_be), rCe)
+ MOVQ(Mem{Base: rpState}.Offset(_bu), rCu)
+
+ XORQ(Mem{Base: rpState}.Offset(_ga), rCa)
+ XORQ(Mem{Base: rpState}.Offset(_ge), rCe)
+ XORQ(Mem{Base: rpState}.Offset(_gu), rCu)
+
+ XORQ(Mem{Base: rpState}.Offset(_ka), rCa)
+ XORQ(Mem{Base: rpState}.Offset(_ke), rCe)
+ XORQ(Mem{Base: rpState}.Offset(_ku), rCu)
+
+ XORQ(Mem{Base: rpState}.Offset(_ma), rCa)
+ XORQ(Mem{Base: rpState}.Offset(_me), rCe)
+ XORQ(Mem{Base: rpState}.Offset(_mu), rCu)
+
+ XORQ(Mem{Base: rpState}.Offset(_sa), rCa)
+ XORQ(Mem{Base: rpState}.Offset(_se), rCe)
+ MOVQ(Mem{Base: rpState}.Offset(_si), rDi)
+ MOVQ(Mem{Base: rpState}.Offset(_so), rDo)
+ XORQ(Mem{Base: rpState}.Offset(_su), rCu)
+
+ for i, rc := range RoundConstants[:len(RoundConstants)-1] {
+ var iState, oState GPPhysical
+ if i%2 == 0 {
+ iState, oState = rpState, rpStack
+ } else {
+ iState, oState = rpStack, rpState
+ }
+ mKeccakRound(iState, oState, U64(rc), MOVQ_RBI_RCE, XORQ_RT1_RCA, XORQ_RT1_RCE, XORQ_RBA_RCU, XORQ_RT1_RCA, XORQ_RT1_RCE, XORQ_RBA_RCU, XORQ_RT1_RCA, XORQ_RT1_RCE, XORQ_RBE_RCU, XORQ_RDU_RCU, XORQ_RDA_RCA, XORQ_RDE_RCE)
+ }
+ mKeccakRound(rpStack, rpState, U64(RoundConstants[len(RoundConstants)-1]), NOP, NOP, NOP, NOP, NOP, NOP, NOP, NOP, NOP, NOP, NOP, NOP, NOP)
+
+ Comment("Revert the internal state to the user state")
+ NOTQ(Mem{Base: rpState}.Offset(_be))
+ NOTQ(Mem{Base: rpState}.Offset(_bi))
+ NOTQ(Mem{Base: rpState}.Offset(_go))
+ NOTQ(Mem{Base: rpState}.Offset(_ki))
+ NOTQ(Mem{Base: rpState}.Offset(_mi))
+ NOTQ(Mem{Base: rpState}.Offset(_sa))
+
+ RET()
+}
Change information
Files:
- A sha3/_asm/keccakf_amd64_asm.go
Change size: L
Delta: 1 file changed, 434 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Garrett (Gerrit)
Jun 24, 2024, 10:32:11 PM (9 days ago) Jun 24
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Clide Stefani, Esra Al, Filippo Valsorda, Manuel Sabin, Roland Shoemaker and Russell Webb
Garrett uploaded new patchset![]( "Open in Gerrit")
Garrett uploaded patch set #2 to this change.
Related details
Attention is currently required from:
- Clide Stefani
- Esra Al
- Filippo Valsorda
- Manuel Sabin
- Roland Shoemaker
- Russell Webb
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Russell Webb (Gerrit)
Jun 25, 2024, 1:47:14 PM (8 days ago) Jun 25
to Garrett, goph...@pubsubhelper.golang.org, Manuel Sabin, Esra Al, Clide Stefani, Roland Shoemaker, golang-co...@googlegroups.com
Attention needed from Clide Stefani, Esra Al, Filippo Valsorda, Garrett, Manuel Sabin and Roland Shoemaker
Russell Webb added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Russell Webb . unresolved
@garrett...@gmail.com are there changes to keccakf_amd64.s that should also be included in this CL?
File sha3/_asm/go.mod
Line 3, Patchset 2 (Latest):
go 1.22.4Russell Webb . unresolved
I noticed that the crypto/go.mod file specifies go 1.18 - is this version deliberately different?
File sha3/_asm/keccakf_amd64_asm.go
Line 16, Patchset 2 (Latest):
var RoundConstants = [24]uint64{Russell Webb . unresolved
Is this the same as rc in keccakf.go, and if so, does it make sense to use that copy of it rather than making another copy?
Related details
Attention is currently required from:
- Clide Stefani
- Esra Al
- Filippo Valsorda
- Garrett
- Manuel Sabin
- Roland Shoemaker
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Garrett (Gerrit)
Jun 25, 2024, 2:43:19 PM (8 days ago) Jun 25
to goph...@pubsubhelper.golang.org, Russell Webb, Manuel Sabin, Esra Al, Clide Stefani, Roland Shoemaker, golang-co...@googlegroups.com
Attention needed from Clide Stefani, Esra Al, Filippo Valsorda, Manuel Sabin, Roland Shoemaker and Russell Webb
Message from Garrett![]( "Open in Gerrit")
Attention is currently required from:
- Clide Stefani
- Esra Al
- Filippo Valsorda
- Manuel Sabin
- Roland Shoemaker
- Russell Webb
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Garrett (Gerrit)
Jun 25, 2024, 3:52:20 PM (8 days ago) Jun 25
to goph...@pubsubhelper.golang.org, Russell Webb, Manuel Sabin, Esra Al, Clide Stefani, Roland Shoemaker, golang-co...@googlegroups.com
Attention needed from Clide Stefani, Esra Al, Filippo Valsorda, Manuel Sabin, Roland Shoemaker and Russell Webb
Garrett added 3 comments![]( "Open in Gerrit")
Patchset-level comments
@garrett...@gmail.com are there changes to keccakf_amd64.s that should also be included in this CL?
I noticed that the crypto/go.mod file specifies go 1.18 - is this version deliberately different?
Russell Webb . unresolved
Is this the same as rc in keccakf.go, and if so, does it make sense to use that copy of it rather than making another copy?
Garrett
the `rc` var in `keccakf.go` is not publicly exported. I felt the decision to publicly expose `rc` was outside the purview of this CL. The constants are defined in the spec and should never change. If we want to expose `rc` I think it makes sense to do that in a separate CL.
Russell Webb (Gerrit)
Jun 25, 2024, 8:03:23 PM (8 days ago) Jun 25
to Garrett, goph...@pubsubhelper.golang.org, Manuel Sabin, Esra Al, Clide Stefani, Roland Shoemaker, golang-co...@googlegroups.com
Attention needed from Clide Stefani, Esra Al, Filippo Valsorda, Garrett, Manuel Sabin and Roland Shoemaker
Russell Webb added 1 comment![]( "Open in Gerrit")
File sha3/_asm/keccakf_amd64_asm.go
Line 16, Patchset 2:
var RoundConstants = [24]uint64{Russell Webb . resolved
GarrettIs this the same as rc in keccakf.go, and if so, does it make sense to use that copy of it rather than making another copy?
the `rc` var in `keccakf.go` is not publicly exported. I felt the decision to publicly expose `rc` was outside the purview of this CL. The constants are defined in the spec and should never change. If we want to expose `rc` I think it makes sense to do that in a separate CL.
Attention is currently required from:
- Clide Stefani
- Esra Al
- Filippo Valsorda
- Garrett
- Manuel Sabin
- Roland Shoemaker
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Garrett (Gerrit)
Jun 26, 2024, 12:45:15 AM (8 days ago) Jun 26
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Clide Stefani, Esra Al, Filippo Valsorda, Garrett, Manuel Sabin and Roland Shoemaker
Garrett uploaded new patchset![]( "Open in Gerrit")
Garrett uploaded patch set #4 to this change.
Related details
Attention is currently required from:
- Clide Stefani
- Esra Al
- Filippo Valsorda
- Garrett
- Manuel Sabin
- Roland Shoemaker
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Russell Webb (Gerrit)
Jun 26, 2024, 2:52:16 PM (7 days ago) Jun 26
to Garrett, goph...@pubsubhelper.golang.org, Manuel Sabin, Esra Al, Clide Stefani, Roland Shoemaker, golang-co...@googlegroups.com
Attention needed from Clide Stefani, Esra Al, Filippo Valsorda, Garrett, Manuel Sabin and Roland Shoemaker
Russell Webb added 1 comment![]( "Open in Gerrit")
File sha3/keccakf_amd64.s
Line 6, Patchset 4 (Latest):
TEXT ·keccakF1600(SB), $200-8Russell Webb . unresolved
I am not clear about what the effect of removing this "0," is.
Related details
Attention is currently required from:
- Clide Stefani
- Esra Al
- Filippo Valsorda
- Garrett
- Manuel Sabin
- Roland Shoemaker
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Russell Webb (Gerrit)
Jun 28, 2024, 12:46:04 PM (5 days ago) Jun 28
to Garrett, goph...@pubsubhelper.golang.org, Manuel Sabin, Esra Al, Clide Stefani, Roland Shoemaker, golang-co...@googlegroups.com
Attention needed from Clide Stefani, Esra Al, Filippo Valsorda, Garrett, Manuel Sabin and Roland Shoemaker
Russell Webb voted and added 1 comment![]( "Open in Gerrit")
Votes added by Russell Webb
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Russell Webb . unresolved
+1 with the caveat that I'd like a more experienced set of eyes on the following:
- overall validity of the compile-decompile-diff verification process
- semantic meaning of the TEXT diff (flagged below)
- semantic meaning of the address changes in the gist
- what "unlinkable" means in the gist
Filippo Valsorda (Gerrit)
2:22 PM (7 hours ago) 2:22 PM
to Garrett, goph...@pubsubhelper.golang.org, Michael McLoughlin, Russell Webb, Manuel Sabin, Esra Al, Clide Stefani, Roland Shoemaker, golang-co...@googlegroups.com
Attention needed from Clide Stefani, Esra Al, Garrett, Manuel Sabin, Michael McLoughlin, Roland Shoemaker and Russell Webb
Filippo Valsorda voted and added 6 comments![]( "Open in Gerrit")
Votes added by Filippo Valsorda
| Code-Review | +1 |
| Commit-Queue | +1 |
6 comments
Patchset-level comments
Filippo Valsorda . resolved
Roland PTAL!
File sha3/_asm/go.mod
Line 1, Patchset 4 (Latest):
module sha3/_asmFilippo Valsorda . resolved
I *think* this will not be go get-able both because of the _ and because of the unrooted module name.
File sha3/_asm/keccakf_amd64_asm.go
Line 1, Patchset 4 (Latest):
// Copyright 2023 The Go Authors. All rights reserved.Filippo Valsorda . unresolved
2024
File sha3/keccakf_amd64.s
Line 6, Patchset 4 (Latest):
TEXT ·keccakF1600(SB), $200-8Russell Webb . resolved
I am not clear about what the effect of removing this "0," is.
Filippo Valsorda
Those are the optional flags. I assume zero is the default and Avo knows to omit them.
Line 8, Patchset 4 (Parent):
// domain sources at https://github.com/gvanas/KeccakCodePackageFilippo Valsorda . unresolved
Move attribution to sha3/_asm/keccakf_amd64_asm.go
Related details
Attention is currently required from:
- Clide Stefani
- Esra Al
- Garrett
- Manuel Sabin
- Michael McLoughlin
- Roland Shoemaker
- Russell Webb
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages