[go] net/http/internal/http2: prevent alloc when writing status code for responses
2 views
Skip to first unread message
Nicholas Husin (Gerrit)
Apr 2, 2026, 8:32:30 AM (7 days ago) Apr 2
to goph...@pubsubhelper.golang.org, Go LUCI, Damien Neil, golang-co...@googlegroups.com
Attention needed from Damien Neil
Nicholas Husin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nicholas Husin
| Hold | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Nicholas Husin . unresolved
Hold: do not submit until CL 762040 is vendored into `std`. Otherwise, we'll be adding allocs when writing `200` and `404` status codes compared to before, since they'll escape when being encoded.
Related details
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Apr 2, 2026, 10:58:14 AM (7 days ago) Apr 2
to Nicholas Husin, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Nicholas Husin
Damien Neil voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Nicholas Husin
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Apr 2, 2026, 2:03:55 PM (6 days ago) Apr 2
to Nicholas Husin, goph...@pubsubhelper.golang.org, Damien Neil, Go LUCI, golang-co...@googlegroups.com
Attention needed from Nicholas Husin
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Nicholas Husin
Submit Requirements:
Code-Review
No-Holds
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Apr 8, 2026, 5:09:40 PM (7 hours ago) Apr 8
to goph...@pubsubhelper.golang.org, Nicholas Husin, Damien Neil, Go LUCI, golang-co...@googlegroups.com
Nicholas Husin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nicholas Husin
| Hold | +0 |
1 comment
Patchset-level comments
Nicholas Husin . resolved
Hold: do not submit until CL 762040 is vendored into `std`. Otherwise, we'll be adding allocs when writing `200` and `404` status codes compared to before, since they'll escape when being encoded.
Nicholas Husin
CL 762040 has been vendored into `std` by CL 740121.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
Apr 8, 2026, 5:09:54 PM (7 hours ago) Apr 8
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Nicholas Husin, Damien Neil, Go LUCI, golang-co...@googlegroups.com
Nicholas Husin submitted the change![]( "Open in Gerrit")
Change information
Commit message:
net/http/internal/http2: prevent alloc when writing status code for responses
Previously, writing responses with non-200 and non-404 status code
requires an allocation. Now that CL 762040 prevents header names and
values from escaping, we can modify writeFrame to not allocate status
codes on the heap.
Change-Id: I230bed1b83627c1fb389c0507106d8e16a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/762140
Reviewed-by: Nicholas Husin <hu...@google.com>
Reviewed-by: Damien Neil <dn...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M src/net/http/internal/http2/http2.go
- M src/net/http/internal/http2/write.go
Change size: S
Delta: 2 files changed, 5 insertions(+), 13 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Nicholas Husin, +2 by Damien Neil
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages