[go] runtime,syscall: implement and use syscallN on darwin

6 views
Skip to first unread message

Quim Muntal (Gerrit)

unread,
Sep 15, 2025, 8:33:42 AMSep 15
to goph...@pubsubhelper.golang.org, Cherry Mui, Michael Pratt, Go LUCI, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Michael Pratt

Quim Muntal added 1 comment

Patchset-level comments
File-level comment, Patchset 18 (Latest):
Quim Muntal . resolved

This CL is pending CL 700856, but can be already reviewed.

Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
  • Michael Pratt
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
Gerrit-Change-Number: 699177
Gerrit-PatchSet: 18
Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Cherry Mui <cher...@google.com>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Mon, 15 Sep 2025 12:33:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Michael Pratt (Gerrit)

unread,
Sep 15, 2025, 1:12:55 PMSep 15
to Quim Muntal, goph...@pubsubhelper.golang.org, Cherry Mui, Michael Pratt, Go LUCI, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Quim Muntal

Michael Pratt added 1 comment

File src/internal/runtime/sys/consts.go
Line 15, Patchset 18 (Latest):const StackGuardMultiplier = 1 + goos.IsAix + goos.IsOpenbsd + goos.IsDarwin + isRace
Michael Pratt . unresolved

We're generally quite hesitant to increase the nosplit limit because it increases total memory usage. This would be the first first class port to do so.

Is it possible to shave off a few bytes somewhere?

Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
  • Quim Muntal
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
    Gerrit-Change-Number: 699177
    Gerrit-PatchSet: 18
    Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Cherry Mui <cher...@google.com>
    Gerrit-Comment-Date: Mon, 15 Sep 2025 17:12:50 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    open
    diffy

    Cherry Mui (Gerrit)

    unread,
    Sep 15, 2025, 1:22:17 PMSep 15
    to Quim Muntal, goph...@pubsubhelper.golang.org, Michael Pratt, Go LUCI, golang-co...@googlegroups.com
    Attention needed from Quim Muntal

    Cherry Mui added 1 comment

    File src/internal/runtime/sys/consts.go
    Line 15, Patchset 18 (Latest):const StackGuardMultiplier = 1 + goos.IsAix + goos.IsOpenbsd + goos.IsDarwin + isRace
    Michael Pratt . unresolved

    We're generally quite hesitant to increase the nosplit limit because it increases total memory usage. This would be the first first class port to do so.

    Is it possible to shave off a few bytes somewhere?

    Cherry Mui

    Agreed. We should avoid increasing the limit, especially as that this CL is just a refactoring.

    I still want to do something with the ideas mentioned in #51256, which would allow us to eliminate the fixed nosplit limit in most cases (if not all). One day.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Quim Muntal
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
    Gerrit-Change-Number: 699177
    Gerrit-PatchSet: 18
    Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
    Gerrit-Comment-Date: Mon, 15 Sep 2025 17:22:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Michael Pratt <mpr...@google.com>
    unsatisfied_requirement
    open
    diffy

    Quim Muntal (Gerrit)

    unread,
    Sep 15, 2025, 1:55:17 PMSep 15
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Quim Muntal

    Quim Muntal uploaded new patchset

    Quim Muntal uploaded patch set #19 to this change.
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Quim Muntal
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
    Gerrit-Change-Number: 699177
    Gerrit-PatchSet: 19
    unsatisfied_requirement
    open
    diffy

    Quim Muntal (Gerrit)

    unread,
    Sep 15, 2025, 1:55:49 PMSep 15
    to goph...@pubsubhelper.golang.org, Cherry Mui, Michael Pratt, Go LUCI, golang-co...@googlegroups.com
    Attention needed from Cherry Mui and Michael Pratt

    Quim Muntal voted and added 1 comment

    Votes added by Quim Muntal

    Commit-Queue+1

    1 comment

    File src/internal/runtime/sys/consts.go
    Line 15, Patchset 18:const StackGuardMultiplier = 1 + goos.IsAix + goos.IsOpenbsd + goos.IsDarwin + isRace
    Michael Pratt . resolved

    We're generally quite hesitant to increase the nosplit limit because it increases total memory usage. This would be the first first class port to do so.

    Is it possible to shave off a few bytes somewhere?

    Cherry Mui

    Agreed. We should avoid increasing the limit, especially as that this CL is just a refactoring.

    I still want to do something with the ideas mentioned in #51256, which would allow us to eliminate the fixed nosplit limit in most cases (if not all). One day.

    Quim Muntal

    Yeo, that's doable.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Cherry Mui
    • Michael Pratt
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
      Gerrit-Change-Number: 699177
      Gerrit-PatchSet: 19
      Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
      Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
      Gerrit-Attention: Michael Pratt <mpr...@google.com>
      Gerrit-Attention: Cherry Mui <cher...@google.com>
      Gerrit-Comment-Date: Mon, 15 Sep 2025 17:55:42 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Michael Pratt <mpr...@google.com>
      Comment-In-Reply-To: Cherry Mui <cher...@google.com>
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Quim Muntal (Gerrit)

      unread,
      Sep 17, 2025, 3:16:26 AMSep 17
      to goph...@pubsubhelper.golang.org, Go LUCI, Cherry Mui, Michael Pratt, golang-co...@googlegroups.com
      Attention needed from Cherry Mui and Michael Pratt

      Quim Muntal voted Commit-Queue+1

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Cherry Mui
      • Michael Pratt
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
      Gerrit-Change-Number: 699177
      Gerrit-PatchSet: 20
      Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
      Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
      Gerrit-Attention: Michael Pratt <mpr...@google.com>
      Gerrit-Attention: Cherry Mui <cher...@google.com>
      Gerrit-Comment-Date: Wed, 17 Sep 2025 07:16:18 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Quim Muntal (Gerrit)

      unread,
      Oct 2, 2025, 4:49:41 AM (14 days ago) Oct 2
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Cherry Mui, Michael Pratt and Quim Muntal

      Quim Muntal uploaded new patchset

      Quim Muntal uploaded patch set #21 to this change.
      Following approvals got outdated and were removed:
      • TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Cherry Mui
      • Michael Pratt
      • Quim Muntal
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
      Gerrit-Change-Number: 699177
      Gerrit-PatchSet: 21
      Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
      Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
      Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
      Gerrit-Attention: Cherry Mui <cher...@google.com>
      Gerrit-Attention: Michael Pratt <mpr...@google.com>
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Quim Muntal (Gerrit)

      unread,
      Oct 2, 2025, 4:51:10 AM (14 days ago) Oct 2
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Cherry Mui, Michael Pratt and Quim Muntal

      Quim Muntal uploaded new patchset

      Quim Muntal uploaded patch set #22 to this change.
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Cherry Mui
      • Michael Pratt
      • Quim Muntal
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
      Gerrit-Change-Number: 699177
      Gerrit-PatchSet: 22
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Quim Muntal (Gerrit)

      unread,
      Oct 2, 2025, 4:54:09 AM (14 days ago) Oct 2
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Cherry Mui, Michael Pratt and Quim Muntal

      Quim Muntal uploaded new patchset

      Quim Muntal uploaded patch set #23 to this change.
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Cherry Mui
      • Michael Pratt
      • Quim Muntal
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
      Gerrit-Change-Number: 699177
      Gerrit-PatchSet: 23
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Quim Muntal (Gerrit)

      unread,
      Oct 2, 2025, 4:58:59 AM (14 days ago) Oct 2
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Cherry Mui, Michael Pratt and Quim Muntal

      Quim Muntal uploaded new patchset

      Quim Muntal uploaded patch set #24 to this change.
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Cherry Mui
      • Michael Pratt
      • Quim Muntal
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
      Gerrit-Change-Number: 699177
      Gerrit-PatchSet: 24
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Quim Muntal (Gerrit)

      unread,
      Oct 2, 2025, 4:59:55 AM (14 days ago) Oct 2
      to goph...@pubsubhelper.golang.org, Go LUCI, Cherry Mui, Michael Pratt, golang-co...@googlegroups.com
      Attention needed from Cherry Mui and Michael Pratt

      Quim Muntal voted Commit-Queue+1

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Cherry Mui
      • Michael Pratt
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
      Gerrit-Change-Number: 699177
      Gerrit-PatchSet: 24
      Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
      Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
      Gerrit-Attention: Cherry Mui <cher...@google.com>
      Gerrit-Attention: Michael Pratt <mpr...@google.com>
      Gerrit-Comment-Date: Thu, 02 Oct 2025 08:59:48 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Quim Muntal (Gerrit)

      unread,
      Oct 2, 2025, 10:42:18 AM (14 days ago) Oct 2
      to goph...@pubsubhelper.golang.org, Michael Pratt, Michael Knyszek, Go LUCI, golang-co...@googlegroups.com
      Attention needed from Michael Knyszek and Michael Pratt

      New activity on the change

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Michael Knyszek
      • Michael Pratt
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
      Gerrit-Change-Number: 699177
      Gerrit-PatchSet: 31
      Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
      Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
      Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
      Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
      Gerrit-Attention: Michael Pratt <mpr...@google.com>
      Gerrit-Attention: Michael Knyszek <mkny...@google.com>
      Gerrit-Comment-Date: Thu, 02 Oct 2025 14:42:08 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Quim Muntal (Gerrit)

      unread,
      4:45 PM (7 hours ago) 4:45 PM
      to goph...@pubsubhelper.golang.org, Go LUCI, Cherry Mui, Michael Pratt, golang-co...@googlegroups.com
      Attention needed from Cherry Mui and Michael Pratt

      Quim Muntal added 1 comment

      Patchset-level comments
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Cherry Mui
      • Michael Pratt
      Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: If5de80442b1d4a1123258401a3ae21695e7c8f6b
        Gerrit-Change-Number: 699177
        Gerrit-PatchSet: 31
        Gerrit-Owner: Quim Muntal <quimm...@gmail.com>
        Gerrit-Reviewer: Cherry Mui <cher...@google.com>
        Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
        Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
        Gerrit-Attention: Cherry Mui <cher...@google.com>
        Gerrit-Attention: Michael Pratt <mpr...@google.com>
        Gerrit-Comment-Date: Wed, 15 Oct 2025 20:45:05 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages