[go] debug: fix comment error

8 views
Skip to first unread message

Gerrit Bot (Gerrit)

unread,
Feb 20, 2024, 12:53:43 AM2/20/24
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Gerrit Bot has uploaded the change for review

Commit message

debug: fix comment error
Change-Id: Icfe3063a5390105cf0796046348bcaa9e88bbfde
GitHub-Last-Rev: 4df263e334c7011a0a08b7eb5d1722290302b15f
GitHub-Pull-Request: golang/go#65803

Change diff

diff --git a/src/debug/pe/file.go b/src/debug/pe/file.go
index ed63a11..91bac52 100644
--- a/src/debug/pe/file.go
+++ b/src/debug/pe/file.go
@@ -483,7 +483,7 @@
 		return nil, fmt.Errorf("optional header size is less than optional header magic size")
 	}
 
-	// read reads from io.ReadSeeke, r, into data.
+	// read reads from io.ReadSeeker, r, into data.
 	var err error
 	read := func(data any) bool {
 		err = binary.Read(r, binary.LittleEndian, data)

Change information

Files:
  • M src/debug/pe/file.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Icfe3063a5390105cf0796046348bcaa9e88bbfde
Gerrit-Change-Number: 565276
Gerrit-PatchSet: 1
Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Ian Lance Taylor (Gerrit)

unread,
Feb 20, 2024, 1:06:05 AM2/20/24
to Gerrit Bot, goph...@pubsubhelper.golang.org, Alex Brainman, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Alex Brainman

Ian Lance Taylor voted and added 1 comment

Votes added by Ian Lance Taylor

Auto-Submit+1
Code-Review+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ian Lance Taylor . resolved

Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Brainman
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Icfe3063a5390105cf0796046348bcaa9e88bbfde
Gerrit-Change-Number: 565276
Gerrit-PatchSet: 1
Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@google.com>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Attention: Alex Brainman <alex.b...@gmail.com>
Gerrit-Comment-Date: Tue, 20 Feb 2024 06:06:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Brainman (Gerrit)

unread,
Feb 20, 2024, 3:49:11 PM2/20/24
to Gerrit Bot, goph...@pubsubhelper.golang.org, Gopher Robot, golang-co...@googlegroups.com

Alex Brainman voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Icfe3063a5390105cf0796046348bcaa9e88bbfde
Gerrit-Change-Number: 565276
Gerrit-PatchSet: 1
Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@google.com>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Comment-Date: Tue, 20 Feb 2024 20:49:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sean Liao (Gerrit)

unread,
Jul 17, 2026, 6:12:15 PMJul 17
to Gerrit Bot, goph...@pubsubhelper.golang.org, Alex Brainman, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Ian Lance Taylor

Sean Liao voted

Auto-Submit+1
Code-Review+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Lance Taylor
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Icfe3063a5390105cf0796046348bcaa9e88bbfde
Gerrit-Change-Number: 565276
Gerrit-PatchSet: 2
Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@google.com>
Gerrit-Reviewer: Sean Liao <se...@liao.dev>
Gerrit-CC: Gopher Robot <go...@golang.org>
Gerrit-Attention: Ian Lance Taylor <ia...@google.com>
Gerrit-Comment-Date: Fri, 17 Jul 2026 22:12:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Brainman (Gerrit)

unread,
Jul 17, 2026, 10:03:41 PMJul 17
to Gerrit Bot, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Ian Lance Taylor

Alex Brainman voted and added 1 comment

Votes added by Alex Brainman

Code-Review+2

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Alex Brainman . resolved

Sean,

Thanks for running try bot.

Alex

Open in Gerrit

Related details

Attention is currently required from:
  • Ian Lance Taylor
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Icfe3063a5390105cf0796046348bcaa9e88bbfde
    Gerrit-Change-Number: 565276
    Gerrit-PatchSet: 2
    Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
    Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@google.com>
    Gerrit-Reviewer: Sean Liao <se...@liao.dev>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Ian Lance Taylor <ia...@google.com>
    Gerrit-Comment-Date: Sat, 18 Jul 2026 02:03:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Carlos Amedee (Gerrit)

    unread,
    Jul 20, 2026, 12:20:38 PMJul 20
    to Gerrit Bot, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Alex Brainman, Gopher Robot, golang-co...@googlegroups.com
    Attention needed from Ian Lance Taylor

    Carlos Amedee voted

    Auto-Submit+1
    Code-Review+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Lance Taylor
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Icfe3063a5390105cf0796046348bcaa9e88bbfde
    Gerrit-Change-Number: 565276
    Gerrit-PatchSet: 2
    Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
    Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
    Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@google.com>
    Gerrit-Reviewer: Sean Liao <se...@liao.dev>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Ian Lance Taylor <ia...@google.com>
    Gerrit-Comment-Date: Mon, 20 Jul 2026 16:20:31 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Cherry Mui (Gerrit)

    unread,
    Jul 21, 2026, 7:19:56 PMJul 21
    to Gerrit Bot, goph...@pubsubhelper.golang.org, Carlos Amedee, golang...@luci-project-accounts.iam.gserviceaccount.com, Alex Brainman, Gopher Robot, golang-co...@googlegroups.com
    Attention needed from Ian Lance Taylor

    Cherry Mui voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Lance Taylor
    Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Icfe3063a5390105cf0796046348bcaa9e88bbfde
      Gerrit-Change-Number: 565276
      Gerrit-PatchSet: 2
      Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
      Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
      Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Ian Lance Taylor <ia...@google.com>
      Gerrit-Reviewer: Sean Liao <se...@liao.dev>
      Gerrit-CC: Gopher Robot <go...@golang.org>
      Gerrit-Attention: Ian Lance Taylor <ia...@google.com>
      Gerrit-Comment-Date: Tue, 21 Jul 2026 23:19:51 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Gopher Robot (Gerrit)

      unread,
      Jul 21, 2026, 7:21:38 PMJul 21
      to Gerrit Bot, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Cherry Mui, Carlos Amedee, golang...@luci-project-accounts.iam.gserviceaccount.com, Alex Brainman, golang-co...@googlegroups.com

      Gopher Robot submitted the change

      Change information

      Commit message:
      debug: fix comment error
      Change-Id: Icfe3063a5390105cf0796046348bcaa9e88bbfde
      GitHub-Last-Rev: 4df263e334c7011a0a08b7eb5d1722290302b15f
      GitHub-Pull-Request: golang/go#65803
      Reviewed-by: Cherry Mui <cher...@google.com>
      Reviewed-by: Alex Brainman <alex.b...@gmail.com>
      Reviewed-by: Sean Liao <se...@liao.dev>
      Auto-Submit: Sean Liao <se...@liao.dev>
      Reviewed-by: Ian Lance Taylor <ia...@google.com>
      Auto-Submit: Carlos Amedee <car...@golang.org>
      Reviewed-by: Carlos Amedee <car...@golang.org>
      Files:
      • M src/debug/pe/file.go
      Change size: XS
      Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
      Branch: refs/heads/master
      Submit Requirements:
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Icfe3063a5390105cf0796046348bcaa9e88bbfde
      Gerrit-Change-Number: 565276
      Gerrit-PatchSet: 3
      Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
      Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
      Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Gopher Robot <go...@golang.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages