[go] rewrite x-y*z to fused multiply subtract for GOAMD64=v3

1 view
Skip to first unread message

Michael Matloob (Gerrit)

unread,
Jul 16, 2026, 1:02:23 PM (yesterday) Jul 16
to goph...@pubsubhelper.golang.org, Jorropo, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Jorropo and Keith Randall

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Jorropo
  • Keith Randall
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Id32c6ef68aad91dcbccf2e6e5e9822656a6a6964
Gerrit-Change-Number: 801620
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Attention: Keith Randall <k...@golang.org>
Gerrit-Attention: Jorropo <jorro...@gmail.com>
Gerrit-Comment-Date: Thu, 16 Jul 2026 17:02:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Jorropo (Gerrit)

unread,
Jul 16, 2026, 1:10:39 PM (yesterday) Jul 16
to Michael Matloob, goph...@pubsubhelper.golang.org, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Keith Randall and Michael Matloob

Jorropo voted and added 1 comment

Votes added by Jorropo

Auto-Submit+1
Code-Review+2
Commit-Queue+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Keith Randall
  • Michael Matloob
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Id32c6ef68aad91dcbccf2e6e5e9822656a6a6964
Gerrit-Change-Number: 801620
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Attention: Keith Randall <k...@golang.org>
Gerrit-Attention: Michael Matloob <mat...@golang.org>
Gerrit-Comment-Date: Thu, 16 Jul 2026 17:10:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Matloob (Gerrit)

unread,
Jul 16, 2026, 1:32:28 PM (yesterday) Jul 16
to Michael Matloob, goph...@pubsubhelper.golang.org, Jorropo, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Keith Randall and Michael Matloob

Michael Matloob voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Keith Randall
  • Michael Matloob
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Id32c6ef68aad91dcbccf2e6e5e9822656a6a6964
Gerrit-Change-Number: 801620
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@google.com>
Gerrit-Comment-Date: Thu, 16 Jul 2026 17:32:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Pratt (Gerrit)

unread,
3:02 PM (8 hours ago) 3:02 PM
to Michael Matloob, goph...@pubsubhelper.golang.org, Michael Pratt, Michael Matloob, Jorropo, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Keith Randall and Michael Matloob

Michael Pratt voted and added 1 comment

Votes added by Michael Pratt

Code-Review+1

1 comment

Commit Message
Line 9, Patchset 1 (Latest):This CL addresses go.dev/cl/799984/comments/03458ed5_ce76e7f6
Michael Pratt . unresolved

This URL doesn't actually work. (It would be nice to fix go.dev/cl/ to work for these)

Open in Gerrit

Related details

Attention is currently required from:
  • Keith Randall
  • Michael Matloob
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Id32c6ef68aad91dcbccf2e6e5e9822656a6a6964
Gerrit-Change-Number: 801620
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Fri, 17 Jul 2026 19:02:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Matloob (Gerrit)

unread,
5:06 PM (6 hours ago) 5:06 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Jorropo, Keith Randall and Michael Pratt

Michael Matloob uploaded new patchset

Michael Matloob uploaded patch set #2 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Jorropo
  • Keith Randall
  • Michael Pratt
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Id32c6ef68aad91dcbccf2e6e5e9822656a6a6964
Gerrit-Change-Number: 801620
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Keith Randall <k...@golang.org>
Gerrit-Attention: Jorropo <jorro...@gmail.com>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
satisfied_requirement
open
diffy

Michael Matloob (Gerrit)

unread,
5:06 PM (6 hours ago) 5:06 PM
to goph...@pubsubhelper.golang.org, Michael Pratt, Michael Matloob, Jorropo, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Jorropo, Keith Randall and Michael Pratt

Michael Matloob added 1 comment

Commit Message
Line 9, Patchset 1:This CL addresses go.dev/cl/799984/comments/03458ed5_ce76e7f6
Michael Pratt . resolved

This URL doesn't actually work. (It would be nice to fix go.dev/cl/ to work for these)

Michael Matloob

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Jorropo
  • Keith Randall
  • Michael Pratt
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Id32c6ef68aad91dcbccf2e6e5e9822656a6a6964
Gerrit-Change-Number: 801620
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Keith Randall <k...@golang.org>
Gerrit-Attention: Jorropo <jorro...@gmail.com>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Fri, 17 Jul 2026 21:06:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Pratt <mpr...@google.com>
satisfied_requirement
open
diffy

Michael Matloob (Gerrit)

unread,
5:06 PM (6 hours ago) 5:06 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Jorropo, Keith Randall and Michael Pratt

Michael Matloob uploaded new patchset

Michael Matloob uploaded patch set #3 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Jorropo
  • Keith Randall
  • Michael Pratt
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Id32c6ef68aad91dcbccf2e6e5e9822656a6a6964
Gerrit-Change-Number: 801620
Gerrit-PatchSet: 3
satisfied_requirement
open
diffy

Michael Matloob (Gerrit)

unread,
5:06 PM (6 hours ago) 5:06 PM
to goph...@pubsubhelper.golang.org, Michael Pratt, Michael Matloob, Jorropo, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Jorropo, Keith Randall and Michael Pratt

Michael Matloob voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jorropo
  • Keith Randall
  • Michael Pratt
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Id32c6ef68aad91dcbccf2e6e5e9822656a6a6964
    Gerrit-Change-Number: 801620
    Gerrit-PatchSet: 3
    Gerrit-Owner: Michael Matloob <mat...@golang.org>
    Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
    Gerrit-Reviewer: Keith Randall <k...@golang.org>
    Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
    Gerrit-Reviewer: Michael Matloob <mat...@google.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-Attention: Keith Randall <k...@golang.org>
    Gerrit-Attention: Jorropo <jorro...@gmail.com>
    Gerrit-Attention: Michael Pratt <mpr...@google.com>
    Gerrit-Comment-Date: Fri, 17 Jul 2026 21:06:54 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gopher Robot (Gerrit)

    unread,
    5:29 PM (6 hours ago) 5:29 PM
    to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Pratt, Michael Matloob, Jorropo, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

    Gopher Robot submitted the change

    Unreviewed changes

    1 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    cmd/compile: rewrite x-y*z to fused multiply subtract for GOAMD64=v3

    This CL addresses https://go-review.googlesource.com/c/go/+/799984/comments/03458ed5_ce76e7f6

    Fixes #80278
    Change-Id: Id32c6ef68aad91dcbccf2e6e5e9822656a6a6964
    Reviewed-by: Jorropo <jorro...@gmail.com>
    Reviewed-by: Michael Pratt <mpr...@google.com>
    Auto-Submit: Michael Matloob <mat...@golang.org>
    Reviewed-by: Michael Matloob <mat...@google.com>
    Files:
    • M src/cmd/compile/internal/amd64/ssa.go
    • M src/cmd/compile/internal/ssa/_gen/AMD64.rules
    • M src/cmd/compile/internal/ssa/_gen/AMD64Ops.go
    • M src/cmd/compile/internal/ssa/opGen.go
    • M src/cmd/compile/internal/ssa/rewriteAMD64.go
    • M test/codegen/floats.go
    Change size: M
    Delta: 6 files changed, 87 insertions(+), 1 deletion(-)
    Branch: refs/heads/master
    Submit Requirements:
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Id32c6ef68aad91dcbccf2e6e5e9822656a6a6964
    Gerrit-Change-Number: 801620
    Gerrit-PatchSet: 4
    Gerrit-Owner: Michael Matloob <mat...@golang.org>
    Gerrit-Reviewer: Gopher Robot <go...@golang.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages