[text] unicode/norm: avoid infinite loop on invalid input
6 views
Skip to first unread message
Damien Neil (Gerrit)
Jun 24, 2026, 5:54:58 PM (3 days ago) Jun 24
to goph...@pubsubhelper.golang.org, Russ Cox, Neal Patel, golang-co...@googlegroups.com
Attention needed from Neal Patel and Russ Cox
Damien Neil voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Neal Patel
- Russ Cox
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Jun 25, 2026, 3:22:56 PM (2 days ago) Jun 25
to goph...@pubsubhelper.golang.org, Neal Patel, Neal Patel, golang...@luci-project-accounts.iam.gserviceaccount.com, Russ Cox, golang-co...@googlegroups.com
Attention needed from Neal Patel and Russ Cox
Damien Neil voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Neal Patel
- Russ Cox
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Jun 25, 2026, 3:23:09 PM (2 days ago) Jun 25
to goph...@pubsubhelper.golang.org, Neal Patel, Neal Patel, golang...@luci-project-accounts.iam.gserviceaccount.com, Russ Cox, golang-co...@googlegroups.com
Attention needed from Neal Patel and Russ Cox
Damien Neil voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Neal Patel
- Russ Cox
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Neal Patel (Gerrit)
Jun 26, 2026, 11:55:23 AM (19 hours ago) Jun 26
to Damien Neil, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Neal Patel, Russ Cox, golang-co...@googlegroups.com
Attention needed from Damien Neil and Russ Cox
Neal Patel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Neal Patel
| Code-Review | +2 |
1 comment
File unicode/norm/forminfo.go
Line 125, Patchset 2 (Latest):
// We set flags to 0x80 (high bit 7 unused in quick check data) to indicate an invalid rune.Neal Patel . unresolved
0x80 means the MSB is set (the 8th)? Am I mis-reading? Is this 0-indexing the bit indicies?
Related details
Attention is currently required from:
- Damien Neil
- Russ Cox
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Jun 26, 2026, 12:22:52 PM (19 hours ago) Jun 26
to goph...@pubsubhelper.golang.org, Neal Patel, golang...@luci-project-accounts.iam.gserviceaccount.com, Neal Patel, Russ Cox, golang-co...@googlegroups.com
Attention needed from Russ Cox
Damien Neil voted and added 1 comment![]( "Open in Gerrit")
Votes added by Damien Neil
| Auto-Submit | +1 |
1 comment
File unicode/norm/forminfo.go
Line 125, Patchset 2 (Latest):
// We set flags to 0x80 (high bit 7 unused in quick check data) to indicate an invalid rune.Neal Patel . resolved
0x80 means the MSB is set (the 8th)? Am I mis-reading? Is this 0-indexing the bit indicies?
Damien Neil
Yeah, the comment above is using 0-indexing and I chose to be consistent.
Related details
Attention is currently required from:
- Russ Cox
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Neal Patel (Gerrit)
Jun 26, 2026, 3:24:08 PM (16 hours ago) Jun 26
to Damien Neil, goph...@pubsubhelper.golang.org, Neal Patel, golang...@luci-project-accounts.iam.gserviceaccount.com, Russ Cox, golang-co...@googlegroups.com
Attention needed from Damien Neil and Russ Cox
Neal Patel voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Damien Neil
- Russ Cox
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Jun 26, 2026, 3:27:11 PM (15 hours ago) Jun 26
to Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Neal Patel, Neal Patel, golang...@luci-project-accounts.iam.gserviceaccount.com, Russ Cox, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
unicode/norm: avoid infinite loop on invalid input
Invalid characters are given a Properties with a size of 0.
The nextComposed function can enter an infinite loop when
encountering an invalid character, since it advances
its input by the (possibly 0) character size.
Rather than finding every place which might assume characters
have a non-zero size, change compInfo to return a size-1
Properties for invalid characters and use the property flags
to record validity.
Fixes golang/go#80142
Change-Id: Ie0791faefeddc1e8f671b0ed73f29e906a6a6964
Reviewed-on: https://go-review.googlesource.com/c/text/+/794100
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Damien Neil <dn...@google.com>
Reviewed-by: Neal Patel <ne...@golang.org>
Reviewed-by: Neal Patel <neal...@google.com>
Files:
- M unicode/norm/forminfo.go
- M unicode/norm/iter.go
- M unicode/norm/normalize.go
- M unicode/norm/normalize_test.go
Change size: S
Delta: 4 files changed, 25 insertions(+), 17 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Neal Patel, +1 by Neal Patel
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages