[vscode-go] workflows: replace repository dispatch with workflow dispatch

Hyang-Ah Hana Kim (Gerrit)

unread,

Jan 21, 2022, 2:34:32 PM1/21/22

to Suzy Mueller, goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com

Attention is currently required from: Suzy Mueller.

Hyang-Ah Hana Kim would like Suzy Mueller to review this change.

workflows: replace repository dispatch with workflow dispatch

And set workflow environment for publishing job.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows
https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment

Change-Id: I9db2cf26789c937f06fcf633f333cdb3dc601eda
---
M .github/workflows/release-nightly.yml
1 file changed, 26 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/release-nightly.yml b/.github/workflows/release-nightly.yml
index 811b087..609a067 100644
--- a/.github/workflows/release-nightly.yml
+++ b/.github/workflows/release-nightly.yml
@@ -1,19 +1,17 @@
 name: Release (golang.go-nightly)
 
 # Daily release on 15:00 UTC, monday-thursday.
-# Or, force to release by triggering repository_dispatch events by using
-#   curl -v -H "Accept: application/vnd.github.everest-preview+json" -H "Authorization: token ${GITHUB_TOKEN}" https://api.github.com/repos/golang/vscode-go/dispatches -d '{ "event_type": "force-release" }'
+# Or, trigger with workflow dispatch event.
 on:
   schedule:
     - cron: "0 15 * * MON-THU"  # 15 UTC, monday-thursday daily
-  repository_dispatch:
-    types: [force-release]
+  workflow_dispatch:   
 
 jobs:
-  release:
-    if: github.ref == 'refs/heads/master' && github.repository == 'golang/vscode-go'
+  build:
+    if: github.ref == 'refs/heads/master'
 
-    name: Release Nightly
+    name: Build Nightly
     runs-on: ubuntu-latest
     timeout-minutes: 20
 
@@ -60,8 +58,14 @@
           CODE_VERSION: 'insiders'
           VSCODEGO_BEFORE_RELEASE_TESTS: true
 
+  publish:
+    if: github.ref == 'refs/heads/master' && github.repository == 'golang/vscode-go'
+
+    needs: [build]
+    runs-on: ubuntu-latest
+    environment: nightly
+    steps:
       - name: Publish
-        if: github.ref == 'refs/heads/master' && github.repository == 'golang/vscode-go'
         uses: lannonbr/vsce-action@0f3391ee0477b08fae949eb0a875e91e6d20b075
         with:
           args: "publish -p $VSCE_TOKEN"

To view, visit change 380175. To unsubscribe, or for help writing mail filters, visit settings.

kokoro (Gerrit)

unread,

Jan 21, 2022, 2:50:26 PM1/21/22

to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Suzy Mueller, golang-co...@googlegroups.com

Attention is currently required from: Suzy Mueller, Hyang-Ah Hana Kim.

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/ce2821ae-0c18-47cb-bb6b-2de932d5fbe7

Patch set 1:TryBot-Result -1

View Change

To view, visit change 380175. To unsubscribe, or for help writing mail filters, visit settings.

Suzy Mueller (Gerrit)

unread,

Jan 21, 2022, 6:29:45 PM1/21/22

to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, kokoro, golang-co...@googlegroups.com

Attention is currently required from: Hyang-Ah Hana Kim.

Patch set 1:Code-Review +2

View Change

To view, visit change 380175. To unsubscribe, or for help writing mail filters, visit settings.

Hyang-Ah Hana Kim (Gerrit)

unread,

Jan 25, 2022, 11:31:13 AM1/25/22

to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Suzy Mueller, kokoro, golang-co...@googlegroups.com

Patch set 2:Run-TryBot +1Trust +1

View Change

To view, visit change 380175. To unsubscribe, or for help writing mail filters, visit settings.

kokoro (Gerrit)

unread,

Jan 25, 2022, 11:48:16 AM1/25/22

to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Suzy Mueller, golang-co...@googlegroups.com

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/789741fa-a6e8-49e8-9e5b-69d6b9a77cdb

Patch set 2:TryBot-Result +1

View Change

To view, visit change 380175. To unsubscribe, or for help writing mail filters, visit settings.

Hyang-Ah Hana Kim (Gerrit)

unread,

Jan 26, 2022, 2:09:45 PM1/26/22

to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, kokoro, Suzy Mueller, golang-co...@googlegroups.com

Hyang-Ah Hana Kim submitted this change.

View Change



1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals:
  Suzy Mueller: Looks good to me, approved
  Hyang-Ah Hana Kim: Trusted; Run TryBots
  kokoro: TryBots succeeded

workflows: replace repository dispatch with workflow dispatch

And set workflow environment for publishing job.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows
https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment

Change-Id: I9db2cf26789c937f06fcf633f333cdb3dc601eda

Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/380175
Reviewed-by: Suzy Mueller <suz...@golang.org>
Trust: Hyang-Ah Hana Kim <hya...@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hya...@gmail.com>
TryBot-Result: kokoro <noreply...@google.com>
---
M .github/workflows/release-nightly.yml
1 file changed, 31 insertions(+), 8 deletions(-)

To view, visit change 380175. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward