[tools] gopls/internal/protocol: patch RenameParams to extend PositionParams

3 views
Skip to first unread message

Hongxiang Jiang (Gerrit)

unread,
Dec 14, 2025, 9:42:34 PM (2 days ago) Dec 14
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Hongxiang Jiang has uploaded the change for review

Commit message

gopls/internal/protocol: patch RenameParams to extend PositionParams

The LSP states that RenameParams extends TextDocumentPositionParams.
However, the source json definition flattens the text document and
position fields directly to Renameparams, rather than preserving
the inheritance.

This change manually patches the parsed model ensuring the generated
code correctly embeds PositionParams matching the LSP.
Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503

Change diff

diff --git a/gopls/internal/protocol/generate/main.go b/gopls/internal/protocol/generate/main.go
index 828fddd..9b21b80 100644
--- a/gopls/internal/protocol/generate/main.go
+++ b/gopls/internal/protocol/generate/main.go
@@ -20,6 +20,7 @@
 	"os"
 	"os/exec"
 	"path/filepath"
+	"slices"
 	"strings"
 )
 
@@ -72,6 +73,28 @@
 
 	model := parse(filepath.Join(*repodir, "protocol/metaModel.json"))
 
+	// Although the LSP specification defines RenameParams as extending
+	// TextDocumentPositionParams, the metaModel.json definition flattens
+	// these properties (likely due to specific comments in the TS definition).
+	for _, s := range model.Structures {
+		if s.Name == "RenameParams" {
+			s.Properties = slices.DeleteFunc(s.Properties,
+				func(t NameType) bool {
+					return t.Name == "position" || t.Name == "textDocument"
+				})
+			if !slices.ContainsFunc(s.Extends, func(t *Type) bool {
+				return t.Kind == "reference" && t.Name == "TextDocumentPositionParams"
+			}) {
+				s.Extends = append(s.Extends,
+					&Type{
+						Kind: "reference",
+						Name: "TextDocumentPositionParams",
+					},
+				)
+			}
+		}
+	}
+
 	findTypeNames(model)
 	generateOutput(model)
 
diff --git a/gopls/internal/protocol/tsprotocol.go b/gopls/internal/protocol/tsprotocol.go
index a409c01..10aa2a4 100644
--- a/gopls/internal/protocol/tsprotocol.go
+++ b/gopls/internal/protocol/tsprotocol.go
@@ -4523,14 +4523,11 @@
 //
 // See https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification#renameParams
 type RenameParams struct {
-	// The document to rename.
-	TextDocument TextDocumentIdentifier `json:"textDocument"`
-	// The position at which this request was sent.
-	Position Position `json:"position"`
 	// The new name of the symbol. If the given name is not valid the
 	// request must return a {@link ResponseError} with an
 	// appropriate message set.
 	NewName string `json:"newName"`
+	TextDocumentPositionParams
 	WorkDoneProgressParams
 }
 
diff --git a/gopls/internal/protocol/tsserver.go b/gopls/internal/protocol/tsserver.go
index 83841fd..b0c6547 100644
--- a/gopls/internal/protocol/tsserver.go
+++ b/gopls/internal/protocol/tsserver.go
@@ -748,6 +748,11 @@
 		if err := UnmarshalJSON(raw, &params); err != nil {
 			return nil, true, fmt.Errorf("%w: %s", jsonrpc2.ErrParse, err)
 		}
+		if params.Range != (Range{}) {
+			if !params.Range.Contains(params.Position) {
+				return nil, true, fmt.Errorf("position %v is outside the provided range %v.", params.Position, params.Range)
+			}
+		}
 		resp, err := server.Rename(ctx, &params)
 		if err != nil {
 			return nil, true, err

Change information

Files:
  • M gopls/internal/protocol/generate/main.go
  • M gopls/internal/protocol/tsprotocol.go
  • M gopls/internal/protocol/tsserver.go
Change size: S
Delta: 3 files changed, 29 insertions(+), 4 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503
Gerrit-Change-Number: 730040
Gerrit-PatchSet: 1
Gerrit-Owner: Hongxiang Jiang <hxj...@golang.org>
unsatisfied_requirement
satisfied_requirement
open
diffy

Hongxiang Jiang (Gerrit)

unread,
Dec 14, 2025, 9:43:23 PM (2 days ago) Dec 14
to goph...@pubsubhelper.golang.org, Alan Donovan, Madeline Kalil, golang-co...@googlegroups.com
Attention needed from Alan Donovan and Madeline Kalil

Hongxiang Jiang voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
  • Madeline Kalil
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503
Gerrit-Change-Number: 730040
Gerrit-PatchSet: 1
Gerrit-Owner: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
Gerrit-Attention: Madeline Kalil <mka...@google.com>
Gerrit-Attention: Alan Donovan <adon...@google.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 02:43:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Hongxiang Jiang (Gerrit)

unread,
Dec 14, 2025, 9:57:52 PM (2 days ago) Dec 14
to goph...@pubsubhelper.golang.org, Go LUCI, Alan Donovan, Madeline Kalil, golang-co...@googlegroups.com
Attention needed from Alan Donovan and Madeline Kalil

Hongxiang Jiang voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
  • Madeline Kalil
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503
Gerrit-Change-Number: 730040
Gerrit-PatchSet: 2
Gerrit-Owner: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
Gerrit-Attention: Madeline Kalil <mka...@google.com>
Gerrit-Attention: Alan Donovan <adon...@google.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 02:57:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Hongxiang Jiang (Gerrit)

unread,
Dec 14, 2025, 10:33:49 PM (2 days ago) Dec 14
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Alan Donovan, Hongxiang Jiang and Madeline Kalil

Hongxiang Jiang uploaded new patchset

Hongxiang Jiang uploaded patch set #4 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
  • Hongxiang Jiang
  • Madeline Kalil
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503
Gerrit-Change-Number: 730040
Gerrit-PatchSet: 4
Gerrit-Owner: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
Gerrit-Attention: Madeline Kalil <mka...@google.com>
Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Attention: Alan Donovan <adon...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Hongxiang Jiang (Gerrit)

unread,
Dec 14, 2025, 10:36:36 PM (2 days ago) Dec 14
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Alan Donovan, Hongxiang Jiang and Madeline Kalil

Hongxiang Jiang uploaded new patchset

Hongxiang Jiang uploaded patch set #5 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
  • Hongxiang Jiang
  • Madeline Kalil
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503
Gerrit-Change-Number: 730040
Gerrit-PatchSet: 5
unsatisfied_requirement
satisfied_requirement
open
diffy

Hongxiang Jiang (Gerrit)

unread,
Dec 15, 2025, 12:29:10 AM (2 days ago) Dec 15
to goph...@pubsubhelper.golang.org, Go LUCI, Alan Donovan, Madeline Kalil, golang-co...@googlegroups.com
Attention needed from Alan Donovan and Madeline Kalil

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
  • Madeline Kalil
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: tools
    Gerrit-Branch: master
    Gerrit-Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503
    Gerrit-Change-Number: 730040
    Gerrit-PatchSet: 5
    Gerrit-Owner: Hongxiang Jiang <hxj...@golang.org>
    Gerrit-Reviewer: Alan Donovan <adon...@google.com>
    Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
    Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
    Gerrit-Attention: Madeline Kalil <mka...@google.com>
    Gerrit-Attention: Alan Donovan <adon...@google.com>
    Gerrit-Comment-Date: Mon, 15 Dec 2025 05:29:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Alan Donovan (Gerrit)

    unread,
    Dec 16, 2025, 4:25:39 PM (10 hours ago) Dec 16
    to Hongxiang Jiang, goph...@pubsubhelper.golang.org, Go LUCI, Madeline Kalil, golang-co...@googlegroups.com
    Attention needed from Hongxiang Jiang and Madeline Kalil

    Alan Donovan added 7 comments

    Patchset-level comments
    File-level comment, Patchset 5 (Latest):
    Alan Donovan . resolved

    Thanks for fixing this.

    File gopls/internal/protocol/generate/main.go
    Line 78, Patchset 5 (Latest): // these properties (likely due to specific comments in the TS definition).
    Alan Donovan . unresolved

    Let's file an upstream issue as well.

    Line 81, Patchset 5 (Latest): s.Properties = slices.DeleteFunc(s.Properties,
    func(t NameType) bool {
    Alan Donovan . unresolved

    join lines

    Line 88, Patchset 5 (Latest): s.Extends = append(s.Extends,
    &Type{
    Alan Donovan . unresolved

    join lines

    Line 92, Patchset 5 (Latest): },
    )
    Alan Donovan . unresolved

    join lines

    File gopls/internal/protocol/tsserver.go
    Line 751, Patchset 5 (Latest): if params.Range != (Range{}) {
    Alan Donovan . unresolved

    !params.Range.Empty() && !params.Range.Contains(params.Position)

    File gopls/internal/test/integration/fake/editor.go
    Line 1403, Patchset 5 (Latest): prepareParams.TextDocument = e.TextDocumentIdentifier(path)
    prepareParams.Position = loc.Range.Start
    Alan Donovan . unresolved

    Does PrepareRename need the same treatment?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hongxiang Jiang
    • Madeline Kalil
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: tools
      Gerrit-Branch: master
      Gerrit-Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503
      Gerrit-Change-Number: 730040
      Gerrit-PatchSet: 5
      Gerrit-Owner: Hongxiang Jiang <hxj...@golang.org>
      Gerrit-Reviewer: Alan Donovan <adon...@google.com>
      Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
      Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
      Gerrit-Attention: Madeline Kalil <mka...@google.com>
      Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
      Gerrit-Comment-Date: Tue, 16 Dec 2025 21:25:34 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Hongxiang Jiang (Gerrit)

      unread,
      Dec 16, 2025, 7:43:38 PM (7 hours ago) Dec 16
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Hongxiang Jiang and Madeline Kalil

      Hongxiang Jiang uploaded new patchset

      Hongxiang Jiang uploaded patch set #6 to this change.
      Following approvals got outdated and were removed:
      • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Hongxiang Jiang
      • Madeline Kalil
      Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: newpatchset
        Gerrit-Project: tools
        Gerrit-Branch: master
        Gerrit-Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503
        Gerrit-Change-Number: 730040
        Gerrit-PatchSet: 6
        unsatisfied_requirement
        open
        diffy

        Hongxiang Jiang (Gerrit)

        unread,
        Dec 16, 2025, 7:52:33 PM (6 hours ago) Dec 16
        to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
        Attention needed from Hongxiang Jiang and Madeline Kalil

        Hongxiang Jiang uploaded new patchset

        Hongxiang Jiang uploaded patch set #7 to this change.
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Hongxiang Jiang
        • Madeline Kalil
        Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: newpatchset
        Gerrit-Project: tools
        Gerrit-Branch: master
        Gerrit-Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503
        Gerrit-Change-Number: 730040
        Gerrit-PatchSet: 7
        unsatisfied_requirement
        open
        diffy

        Hongxiang Jiang (Gerrit)

        unread,
        Dec 16, 2025, 7:53:18 PM (6 hours ago) Dec 16
        to goph...@pubsubhelper.golang.org, Go LUCI, Alan Donovan, Madeline Kalil, golang-co...@googlegroups.com
        Attention needed from Alan Donovan and Madeline Kalil

        Hongxiang Jiang voted and added 6 comments

        Votes added by Hongxiang Jiang

        Auto-Submit+1
        Commit-Queue+1

        6 comments

        File gopls/internal/protocol/generate/main.go
        Line 78, Patchset 5: // these properties (likely due to specific comments in the TS definition).
        Alan Donovan . resolved

        Let's file an upstream issue as well.

        Hongxiang Jiang

        Looks like there is already one that now fixed.

        TODO(hxjiang) for deleting this fix after 3.18.

        https://github.com/microsoft/vscode-languageserver-node/issues/1698

        Line 81, Patchset 5: s.Properties = slices.DeleteFunc(s.Properties,
        func(t NameType) bool {
        Alan Donovan . resolved

        join lines

        Hongxiang Jiang

        Done

        Line 88, Patchset 5: s.Extends = append(s.Extends,
        &Type{
        Alan Donovan . resolved

        join lines

        Hongxiang Jiang

        Done

        Line 92, Patchset 5: },
        )
        Alan Donovan . resolved

        join lines

        Hongxiang Jiang

        Done

        File gopls/internal/protocol/tsserver.go
        Line 751, Patchset 5: if params.Range != (Range{}) {
        Alan Donovan . resolved

        !params.Range.Empty() && !params.Range.Contains(params.Position)

        Hongxiang Jiang

        Done

        File gopls/internal/test/integration/fake/editor.go
        Line 1403, Patchset 5: prepareParams.TextDocument = e.TextDocumentIdentifier(path)
        prepareParams.Position = loc.Range.Start
        Alan Donovan . resolved

        Does PrepareRename need the same treatment?

        Hongxiang Jiang

        No, for some reason, the prepare rename extends textdocumentpositionparam. :D

        I still change the code so the way we create the parameter looks identical.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alan Donovan
        • Madeline Kalil
        Submit Requirements:
          • requirement is not satisfiedCode-Review
          • requirement satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement is not satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: tools
          Gerrit-Branch: master
          Gerrit-Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503
          Gerrit-Change-Number: 730040
          Gerrit-PatchSet: 7
          Gerrit-Owner: Hongxiang Jiang <hxj...@golang.org>
          Gerrit-Reviewer: Alan Donovan <adon...@google.com>
          Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
          Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
          Gerrit-Attention: Madeline Kalil <mka...@google.com>
          Gerrit-Attention: Alan Donovan <adon...@google.com>
          Gerrit-Comment-Date: Wed, 17 Dec 2025 00:53:12 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          Comment-In-Reply-To: Alan Donovan <adon...@google.com>
          unsatisfied_requirement
          satisfied_requirement
          open
          diffy

          Alan Donovan (Gerrit)

          unread,
          Dec 16, 2025, 8:16:31 PM (6 hours ago) Dec 16
          to Hongxiang Jiang, goph...@pubsubhelper.golang.org, Go LUCI, Madeline Kalil, golang-co...@googlegroups.com
          Attention needed from Hongxiang Jiang and Madeline Kalil

          Alan Donovan voted Code-Review+2

          Code-Review+2
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Hongxiang Jiang
          • Madeline Kalil
          Submit Requirements:
          • requirement satisfiedCode-Review
          • requirement satisfiedNo-Unresolved-Comments
          • requirement satisfiedReview-Enforcement
          • requirement satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: tools
          Gerrit-Branch: master
          Gerrit-Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503
          Gerrit-Change-Number: 730040
          Gerrit-PatchSet: 7
          Gerrit-Owner: Hongxiang Jiang <hxj...@golang.org>
          Gerrit-Reviewer: Alan Donovan <adon...@google.com>
          Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
          Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
          Gerrit-Attention: Madeline Kalil <mka...@google.com>
          Gerrit-Attention: Hongxiang Jiang <hxj...@golang.org>
          Gerrit-Comment-Date: Wed, 17 Dec 2025 01:16:28 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy

          Gopher Robot (Gerrit)

          unread,
          Dec 16, 2025, 8:17:42 PM (6 hours ago) Dec 16
          to Hongxiang Jiang, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Alan Donovan, Go LUCI, Madeline Kalil, golang-co...@googlegroups.com

          Gopher Robot submitted the change

          Change information

          Commit message:
          gopls/internal/protocol: patch RenameParams to extend PositionParams

          The LSP states that RenameParams extends TextDocumentPositionParams.
          However, the source json definition flattens the text document and
          position fields directly to Renameparams, rather than preserving
          the inheritance.

          This change manually patches the parsed model ensuring the generated
          code correctly embeds PositionParams matching the LSP.
          Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503
          Auto-Submit: Hongxiang Jiang <hxj...@golang.org>
          Reviewed-by: Alan Donovan <adon...@google.com>
          Files:
          • M gopls/internal/cmd/rename.go
          • M gopls/internal/protocol/generate/main.go
          • M gopls/internal/protocol/generate/output.go
          • M gopls/internal/protocol/tsprotocol.go
          • M gopls/internal/protocol/tsserver.go
          • M gopls/internal/test/integration/fake/editor.go
          • M gopls/internal/test/marker/marker_test.go
          Change size: M
          Delta: 7 files changed, 68 insertions(+), 81 deletions(-)
          Branch: refs/heads/master
          Submit Requirements:
          • requirement satisfiedCode-Review: +2 by Alan Donovan
          • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
          Open in Gerrit
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: merged
          Gerrit-Project: tools
          Gerrit-Branch: master
          Gerrit-Change-Id: I265ceab5fc5c7ce08cfca2ceb81cc9a52f0be503
          Gerrit-Change-Number: 730040
          Gerrit-PatchSet: 8
          Gerrit-Owner: Hongxiang Jiang <hxj...@golang.org>
          Gerrit-Reviewer: Alan Donovan <adon...@google.com>
          Gerrit-Reviewer: Gopher Robot <go...@golang.org>
          open
          diffy
          satisfied_requirement
          Reply all
          Reply to author
          Forward
          0 new messages