[build] cmd/watchflakes: double the memory allocation

3 views
Skip to first unread message

Dmitri Shuralyov (Gerrit)

unread,
May 28, 2025, 7:38:20 AMMay 28
to Michael Knyszek, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Michael Knyszek

Dmitri Shuralyov has uploaded the change for review

Dmitri Shuralyov would like Michael Knyszek to review this change.

Commit message

cmd/watchflakes: double the memory allocation

Some of the recent watchflakes restarts have OOMKilled as the reason.

For golang/go#70743.
Change-Id: I7e25f54ed37383ecddb6d54a129c2fcac58d0d27

Change diff

diff --git a/cmd/watchflakes/deployment-prod.yaml b/cmd/watchflakes/deployment-prod.yaml
index a3ee5ff..38acc71 100644
--- a/cmd/watchflakes/deployment-prod.yaml
+++ b/cmd/watchflakes/deployment-prod.yaml
@@ -26,10 +26,10 @@
         resources:
           requests:
             cpu: "1"
-            memory: "2Gi"
+            memory: "4Gi"
           limits:
             cpu: "2"
-            memory: "4Gi"
+            memory: "8Gi"
 ---
 apiVersion: v1
 kind: ServiceAccount

Change information

Files:
  • M cmd/watchflakes/deployment-prod.yaml
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Knyszek
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I7e25f54ed37383ecddb6d54a129c2fcac58d0d27
Gerrit-Change-Number: 676735
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Attention: Michael Knyszek <mkny...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
May 28, 2025, 8:11:18 AMMay 28
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Michael Knyszek, golang-co...@googlegroups.com
Attention needed from Michael Knyszek

Dmitri Shuralyov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Knyszek
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I7e25f54ed37383ecddb6d54a129c2fcac58d0d27
Gerrit-Change-Number: 676735
Gerrit-PatchSet: 1
Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Attention: Michael Knyszek <mkny...@google.com>
Gerrit-Comment-Date: Wed, 28 May 2025 12:11:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
May 28, 2025, 8:11:47 AMMay 28
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Michael Knyszek, golang-co...@googlegroups.com
Attention needed from Michael Knyszek

Dmitri Shuralyov voted TryBot-Bypass+1

TryBot-Bypass+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Knyszek
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: build
    Gerrit-Branch: master
    Gerrit-Change-Id: I7e25f54ed37383ecddb6d54a129c2fcac58d0d27
    Gerrit-Change-Number: 676735
    Gerrit-PatchSet: 1
    Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
    Gerrit-Attention: Michael Knyszek <mkny...@google.com>
    Gerrit-Comment-Date: Wed, 28 May 2025 12:11:40 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Michael Knyszek (Gerrit)

    unread,
    May 28, 2025, 11:40:45 AMMay 28
    to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang-co...@googlegroups.com
    Attention needed from Dmitri Shuralyov

    Michael Knyszek voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dmitri Shuralyov
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: build
    Gerrit-Branch: master
    Gerrit-Change-Id: I7e25f54ed37383ecddb6d54a129c2fcac58d0d27
    Gerrit-Change-Number: 676735
    Gerrit-PatchSet: 1
    Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
    Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Comment-Date: Wed, 28 May 2025 15:40:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Dmitri Shuralyov (Gerrit)

    unread,
    May 28, 2025, 11:44:28 AMMay 28
    to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang-co...@googlegroups.com

    Dmitri Shuralyov voted and added 1 comment

    Votes added by Dmitri Shuralyov

    Hold+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Dmitri Shuralyov . resolved

    Hold to try CL 676775 first.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Holds
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: build
    Gerrit-Branch: master
    Gerrit-Change-Id: I7e25f54ed37383ecddb6d54a129c2fcac58d0d27
    Gerrit-Change-Number: 676735
    Gerrit-PatchSet: 1
    Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
    Gerrit-Comment-Date: Wed, 28 May 2025 15:44:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dmitri Shuralyov (Gerrit)

    unread,
    Dec 19, 2025, 1:24:44 PM (6 days ago) Dec 19
    to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Dmitri Shuralyov

    Dmitri Shuralyov uploaded new patchset

    Dmitri Shuralyov uploaded patch set #2 to this change.
    Following approvals got outdated and were removed:
    • TryBots-Pass: TryBot-Bypass+1 by Dmitri Shuralyov
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dmitri Shuralyov
    Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Holds
      • requirement satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: build
      Gerrit-Branch: master
      Gerrit-Change-Id: I7e25f54ed37383ecddb6d54a129c2fcac58d0d27
      Gerrit-Change-Number: 676735
      Gerrit-PatchSet: 2
      Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
      Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Dmitri Shuralyov (Gerrit)

      unread,
      Dec 23, 2025, 5:38:53 PM (2 days ago) Dec 23
      to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang-co...@googlegroups.com

      Dmitri Shuralyov voted and added 2 comments

      Votes added by Dmitri Shuralyov

      Auto-Submit+1
      Hold+0
      TryBot-Bypass+1

      2 comments

      Patchset-level comments
      Dmitri Shuralyov . resolved

      Hold to try CL 676775 first.

      Dmitri Shuralyov

      Done.

      File-level comment, Patchset 3 (Latest):
      Dmitri Shuralyov . resolved

      This helps reduce frequency of OOMs (down from a handful over a few days to 0 over a few days), so submitting this now. If it still happens with the bigger limit we can revisit then.

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: build
      Gerrit-Branch: master
      Gerrit-Change-Id: I7e25f54ed37383ecddb6d54a129c2fcac58d0d27
      Gerrit-Change-Number: 676735
      Gerrit-PatchSet: 3
      Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
      Gerrit-Comment-Date: Tue, 23 Dec 2025 22:38:49 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Dmitri Shuralyov <dmit...@golang.org>
      satisfied_requirement
      open
      diffy

      Gopher Robot (Gerrit)

      unread,
      Dec 23, 2025, 5:39:22 PM (2 days ago) Dec 23
      to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek, Dmitri Shuralyov, golang-co...@googlegroups.com

      Gopher Robot submitted the change with unreviewed changes

      Unreviewed changes

      1 is the latest approved patch-set.
      The change was submitted with unreviewed changes in the following files:

      ```
      The name of the file: cmd/watchflakes/deployment-prod.yaml
      Insertions: 14, Deletions: 11.

      The diff is too large to show. Please review the diff.
      ```

      Change information

      Commit message:
      cmd/watchflakes: double the memory allocation

      Some of the recent watchflakes restarts have OOMKilled as the reason,
      and 2 GiB of requested memory is a bit on the low end. Bump it first.

      For golang/go#70743.
      Change-Id: I7e25f54ed37383ecddb6d54a129c2fcac58d0d27
      TryBot-Bypass: Dmitri Shuralyov <dmit...@golang.org>
      Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
      Reviewed-by: Michael Knyszek <mkny...@google.com>
      Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
      Files:
      • M cmd/watchflakes/deployment-prod.yaml
      Change size: XS
      Delta: 1 file changed, 3 insertions(+), 3 deletions(-)
      Branch: refs/heads/master
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Dmitri Shuralyov, +2 by Michael Knyszek
      • requirement satisfiedTryBots-Pass: TryBot-Bypass+1 by Dmitri Shuralyov
       Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      


       Gerrit-MessageType: merged 
      

       Gerrit-Project: build 
      

       Gerrit-Branch: master 
      

       Gerrit-Change-Id: I7e25f54ed37383ecddb6d54a129c2fcac58d0d27 
      

       Gerrit-Change-Number: 676735 
      

       Gerrit-PatchSet: 4 
      

       Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org> 
      

       Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org> 
      

       Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com> 
      

       Gerrit-Reviewer: Gopher Robot <go...@golang.org> 
      

       Gerrit-Reviewer: Michael Knyszek <mkny...@google.com> 
      


      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages