[net] internal/http3: skip TestNetHTTPIntegration on plan9

0 views
Skip to first unread message

Nicholas Husin (Gerrit)

unread,
Mar 19, 2026, 2:35:19 PM (11 hours ago) Mar 19
to Richard Miller, Ethan Lee, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Ethan Lee and Richard Miller

Nicholas Husin has uploaded the change for review

Nicholas Husin would like Richard Miller and Ethan Lee to review this change.

Commit message

internal/http3: skip TestNetHTTPIntegration on plan9

TestNetHTTPIntegration relies on ReadMsgUDP which is currently
unimplemented in plan9.

For golang/go#78223
Change-Id: I958f5f1324236e540a9c8cdf4f2b3c805f023732

Change diff

diff --git a/internal/http3/nethttp_test.go b/internal/http3/nethttp_test.go
index 5ae8a0d..fa4cbb5 100644
--- a/internal/http3/nethttp_test.go
+++ b/internal/http3/nethttp_test.go
@@ -10,6 +10,7 @@
 	"crypto/tls"
 	"io"
 	"net/http"
+	"runtime"
 	"slices"
 	"testing"
 	"time"
@@ -40,6 +41,10 @@
 }
 
 func TestNetHTTPIntegration(t *testing.T) {
+	if runtime.GOOS == "plan9" {
+		t.Skip("ReadMsgUDP not supported on plan9")
+	}
+
 	body := []byte("some body")
 	handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.Write(body)

Change information

Files:
  • M internal/http3/nethttp_test.go
Change size: XS
Delta: 1 file changed, 5 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Ethan Lee
  • Richard Miller
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: net
Gerrit-Branch: master
Gerrit-Change-Id: I958f5f1324236e540a9c8cdf4f2b3c805f023732
Gerrit-Change-Number: 757000
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Husin <n...@golang.org>
Gerrit-Reviewer: Ethan Lee <etha...@google.com>
Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
Gerrit-Reviewer: Richard Miller <millerr...@gmail.com>
Gerrit-Attention: Richard Miller <millerr...@gmail.com>
Gerrit-Attention: Ethan Lee <etha...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Nicholas Husin (Gerrit)

unread,
Mar 19, 2026, 2:36:42 PM (11 hours ago) Mar 19
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Ethan Lee, Nicholas Husin and Richard Miller

Nicholas Husin uploaded new patchset

Nicholas Husin uploaded patch set #2 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Ethan Lee
  • Nicholas Husin
  • Richard Miller
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: net
Gerrit-Branch: master
Gerrit-Change-Id: I958f5f1324236e540a9c8cdf4f2b3c805f023732
Gerrit-Change-Number: 757000
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Husin <n...@golang.org>
Gerrit-Reviewer: Ethan Lee <etha...@google.com>
Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
Gerrit-Reviewer: Richard Miller <millerr...@gmail.com>
Gerrit-Attention: Richard Miller <millerr...@gmail.com>
Gerrit-Attention: Nicholas Husin <n...@golang.org>
Gerrit-Attention: Ethan Lee <etha...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Ethan Lee (Gerrit)

unread,
Mar 19, 2026, 2:38:34 PM (11 hours ago) Mar 19
to Nicholas Husin, goph...@pubsubhelper.golang.org, Go LUCI, Richard Miller, golang-co...@googlegroups.com
Attention needed from Nicholas Husin and Richard Miller

Ethan Lee voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Nicholas Husin
  • Richard Miller
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: net
Gerrit-Branch: master
Gerrit-Change-Id: I958f5f1324236e540a9c8cdf4f2b3c805f023732
Gerrit-Change-Number: 757000
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Husin <n...@golang.org>
Gerrit-Reviewer: Ethan Lee <etha...@google.com>
Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
Gerrit-Reviewer: Richard Miller <millerr...@gmail.com>
Gerrit-Attention: Richard Miller <millerr...@gmail.com>
Gerrit-Attention: Nicholas Husin <n...@golang.org>
Gerrit-Comment-Date: Thu, 19 Mar 2026 18:38:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nicholas Husin (Gerrit)

unread,
Mar 19, 2026, 2:41:33 PM (11 hours ago) Mar 19
to Nicholas Husin, goph...@pubsubhelper.golang.org, Ethan Lee, Go LUCI, Richard Miller, golang-co...@googlegroups.com
Attention needed from Nicholas Husin and Richard Miller

Nicholas Husin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nicholas Husin
  • Richard Miller
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: net
    Gerrit-Branch: master
    Gerrit-Change-Id: I958f5f1324236e540a9c8cdf4f2b3c805f023732
    Gerrit-Change-Number: 757000
    Gerrit-PatchSet: 2
    Gerrit-Owner: Nicholas Husin <n...@golang.org>
    Gerrit-Reviewer: Ethan Lee <etha...@google.com>
    Gerrit-Reviewer: Nicholas Husin <hu...@google.com>
    Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
    Gerrit-Reviewer: Richard Miller <millerr...@gmail.com>
    Gerrit-Attention: Richard Miller <millerr...@gmail.com>
    Gerrit-Attention: Nicholas Husin <n...@golang.org>
    Gerrit-Comment-Date: Thu, 19 Mar 2026 18:41:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nicholas Husin (Gerrit)

    unread,
    Mar 19, 2026, 2:46:09 PM (11 hours ago) Mar 19
    to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Nicholas Husin, Ethan Lee, Richard Miller, golang-co...@googlegroups.com

    Nicholas Husin submitted the change

    Change information

    Commit message:
    internal/http3: skip TestNetHTTPIntegration on plan9

    TestNetHTTPIntegration relies on ReadMsgUDP which is currently
    unimplemented in plan9.

    For golang/go#78223
    Change-Id: I958f5f1324236e540a9c8cdf4f2b3c805f023732
    Reviewed-by: Nicholas Husin <hu...@google.com>
    Reviewed-by: Ethan Lee <etha...@google.com>
    Files:
    • M internal/http3/nethttp_test.go
    Change size: XS
    Delta: 1 file changed, 6 insertions(+), 0 deletions(-)
    Branch: refs/heads/master
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Ethan Lee, +1 by Nicholas Husin
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: net
    Gerrit-Branch: master
    Gerrit-Change-Id: I958f5f1324236e540a9c8cdf4f2b3c805f023732
    Gerrit-Change-Number: 757000
    Gerrit-PatchSet: 3
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages