[net] http2: add support for setting RFC 9218 priority via header field
3 views
Skip to first unread message
Nicholas Husin (Gerrit)
Dec 10, 2025, 3:38:26 PM (11 days ago) Dec 10
to goph...@pubsubhelper.golang.org, Damien Neil, Go LUCI, golang-co...@googlegroups.com
Attention needed from Damien Neil
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Damien Neil (Gerrit)
Dec 19, 2025, 6:05:22 PM (2 days ago) Dec 19
to Nicholas Husin, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Nicholas Husin
Damien Neil added 3 comments![]( "Open in Gerrit")
File http2/server.go
Line 2087, Patchset 2 (Latest):
// Round-robin behavior.Damien Neil . unresolved
Perhaps expand on the reason for ignoring the priority in this case?
Line 2207, Patchset 2 (Latest):
}Damien Neil . unresolved
If this is a user-provided write scheduler we still want to call `AdjustStream`. I think we should just always call `AdjustStream` on a PRIORITY frame, regardless of what the write scheduler is.
Line 2215, Patchset 2 (Latest):
}Damien Neil . unresolved
Should we handle PRIORITY_UPDATE frames when the request comes through a coalescing intermediary? The "Priority" header is under control of the originator of the request unless the intermediary strips it, but forwarding a PRIORITY_UPDATE frame is more intentional.
Maybe we should only ignore Priority headers but not PRIORITY_UPDATE frames?
Related details
Attention is currently required from:
- Nicholas Husin
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages