[oscar] internal/filter: go fix -stditerators ./... & go fix -forvar ./...
1 view
Skip to first unread message
Hyang-Ah Hana Kim (Gerrit)
Feb 26, 2026, 10:07:57 PM (20 hours ago) Feb 26
to goph...@pubsubhelper.golang.org, Hyang-Ah Hana Kim, golang-co...@googlegroups.com
Hyang-Ah Hana Kim has uploaded the change for review![]( "Open in Gerrit")
Commit message
internal/filter: go fix -stditerators ./... & go fix -forvar ./...
Change-Id: I60b446d134359b4743ba60d889b89cb4edc18893
Change diff
diff --git a/internal/filter/eval.go b/internal/filter/eval.go
index 0c90ca6..6ab7b86 100644
--- a/internal/filter/eval.go
+++ b/internal/filter/eval.go
@@ -1068,8 +1068,7 @@
var methodCalls []func(context.Context, reflect.Value) reflect.Value
var matchFns []func(context.Context, reflect.Value) bool
- for i := range typ.NumMethod() {
- m := typ.Method(i)
+ for m := range typ.Methods() {
if !methodTypeOK(typ, m) {
continue
}
@@ -1638,8 +1637,7 @@
func (ev *eval[T]) compareStructFields(typ reflect.Type, buildMatchFn func(reflect.Type) func(context.Context, reflect.Value) bool) func(context.Context, reflect.Value) bool {
var fieldIndexes [][]int
var matchFns []func(context.Context, reflect.Value) bool
- for i := range typ.NumField() {
- field := typ.Field(i)
+ for field := range typ.Fields() {
// Ignore unexported fields. We are matching on types
// that are defined by a program that expects them
@@ -1708,8 +1706,7 @@
return m, true
}
- for i := range typ.NumMethod() {
- m := typ.Method(i)
+ for m := range typ.Methods() {
if camelCaseMatch(method, m.Name) && methodTypeOK(typ, m) {
return m, true
}
Change information
Files:
- M internal/filter/eval.go
Change size: XS
Delta: 1 file changed, 3 insertions(+), 6 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Lance Taylor (Gerrit)
Feb 26, 2026, 11:45:07 PM (19 hours ago) Feb 26
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Ian Lance Taylor voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicholas Husin (Gerrit)
4:40 PM (2 hours ago) 4:40 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Attention needed from Hyang-Ah Hana Kim
Nicholas Husin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Hyang-Ah Hana Kim
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hyang-Ah Hana Kim (Gerrit)
4:44 PM (2 hours ago) 4:44 PM
to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Nicholas Husin, Ian Lance Taylor, Go LUCI, golang-co...@googlegroups.com
Hyang-Ah Hana Kim submitted the change![]( "Open in Gerrit")
Change information
Commit message:
internal/filter: go fix -stditerators ./... & go fix -forvar ./...
Change-Id: I60b446d134359b4743ba60d889b89cb4edc18893
Reviewed-on: https://go-review.googlesource.com/c/oscar/+/749648
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Ian Lance Taylor <ia...@golang.org>
Reviewed-by: Nicholas Husin <hu...@google.com>
Files:
- M internal/filter/eval.go
Change size: XS
Delta: 1 file changed, 3 insertions(+), 6 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Ian Lance Taylor, +1 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages