[go] net: poll: add GetsockoptInt

Matthieu Baerts (Gerrit)

unread,

Feb 24, 2023, 12:38:38 PM2/24/23

to Gregory Detal, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention is currently required from: Gregory Detal.

Matthieu Baerts would like Gregory Detal to review this change.

net: poll: add GetsockoptInt

This new function wraps the getsockopt() network call with an integer
argument, similar to SetsockoptInt().

This will be used in MPTCP in the following commit.

Updates #56539

https://github.com/golang/go/issues/56539
Signed-off-by: Gregory Detal <gregor...@tessares.net>
Signed-off-by: Matthieu Baerts <matthie...@tessares.net>
Change-Id: I8f6aa00ea2535683d9bbf436993c23e9c6ca2af3
---
M src/internal/poll/sockopt.go
1 file changed, 28 insertions(+), 0 deletions(-)

diff --git a/src/internal/poll/sockopt.go b/src/internal/poll/sockopt.go
index a7c9d11..a87a9e6 100644
--- a/src/internal/poll/sockopt.go
+++ b/src/internal/poll/sockopt.go
@@ -34,3 +34,12 @@
 	defer fd.decref()
 	return syscall.SetsockoptLinger(fd.Sysfd, level, name, l)
 }
+
+// GetsockoptInt wraps the getsockopt network call with an int argument.
+func (fd *FD) GetsockoptInt(level, name int) (int, error) {
+	if err := fd.incref(); err != nil {
+		return -1, err
+	}
+	defer fd.decref()
+	return syscall.GetsockoptInt(fd.Sysfd, level, name)
+}

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Matthieu Baerts (Gerrit)

unread,

Mar 20, 2023, 9:14:35 AM3/20/23

to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention is currently required from: Gregory Detal.

Matthieu Baerts uploaded patch set #3 to this change.

View Change

net: poll: add GetsockoptInt

This new function wraps the getsockopt network call with an integer
argument, similar to SetsockoptInt.



This will be used in MPTCP in the following commit.

This work has been co-developped by Gregory Detal
<gregor...@tessares.net>.

Updates #56539



Change-Id: I8f6aa00ea2535683d9bbf436993c23e9c6ca2af3
---
M src/internal/poll/sockopt.go

1 file changed, 9 insertions(+), 0 deletions(-)

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Ian Lance Taylor (Gerrit)

unread,

Mar 20, 2023, 6:13:59 PM3/20/23

to Matthieu Baerts, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Gregory Detal, golang-co...@googlegroups.com

Attention is currently required from: Gregory Detal, Matthieu Baerts.

View Change

1 comment:

Commit Message:
- Patch Set #3, Line 7: net: poll: add GetsockoptInt
  internal/poll: add GetsockoptInt

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Matthieu Baerts (Gerrit)

unread,

Mar 21, 2023, 6:46:24 AM3/21/23

to goph...@pubsubhelper.golang.org, Ian Lance Taylor, Gregory Detal, golang-co...@googlegroups.com

Attention is currently required from: Gregory Detal, Ian Lance Taylor.

View Change

1 comment:

Commit Message:

- Patch Set #3, Line 7: net: poll: add GetsockoptInt
  internal/poll: add GetsockoptInt

- Done

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Matthieu Baerts (Gerrit)

unread,

Mar 21, 2023, 6:46:25 AM3/21/23

to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention is currently required from: Gregory Detal, Ian Lance Taylor.

Matthieu Baerts uploaded patch set #4 to this change.

View Change

internal/poll: add GetsockoptInt



This new function wraps the getsockopt network call with an integer
argument, similar to SetsockoptInt.

This will be used in MPTCP in the following commit.

This work has been co-developped by Gregory Detal
<gregor...@tessares.net>.

Updates #59166



Change-Id: I8f6aa00ea2535683d9bbf436993c23e9c6ca2af3
---
M src/internal/poll/sockopt.go
1 file changed, 9 insertions(+), 0 deletions(-)

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Emmanuel Odeke (Gerrit)

unread,

Mar 27, 2023, 4:53:52 PM3/27/23

to Matthieu Baerts, goph...@pubsubhelper.golang.org, Ian Lance Taylor, Gregory Detal, golang-co...@googlegroups.com

Attention is currently required from: Gregory Detal, Ian Lance Taylor, Matthieu Baerts.

Patch set 11:Run-TryBot +1

View Change

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Emmanuel Odeke (Gerrit)

unread,

Mar 28, 2023, 1:25:12 PM3/28/23

to Matthieu Baerts, goph...@pubsubhelper.golang.org, Gopher Robot, Ian Lance Taylor, Gregory Detal, golang-co...@googlegroups.com

Attention is currently required from: Gregory Detal, Ian Lance Taylor, Matthieu Baerts.

Patch set 12:Run-TryBot +1

View Change

1 comment:

Commit Message:
- Patch Set #12, Line 13:
  s/developped/developed/

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Matthieu Baerts (Gerrit)

unread,

Mar 28, 2023, 3:31:53 PM3/28/23

to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention is currently required from: Gregory Detal, Ian Lance Taylor, Matthieu Baerts.

Matthieu Baerts uploaded patch set #13 to this change.

View Change

internal/poll: add GetsockoptInt

This new function wraps the getsockopt network call with an integer
argument, similar to SetsockoptInt.

This will be used in MPTCP in the following commit.

This work has been co-developed by Gregory Detal


<gregor...@tessares.net>.

Updates #59166

Change-Id: I8f6aa00ea2535683d9bbf436993c23e9c6ca2af3
---
M src/internal/poll/sockopt.go
1 file changed, 9 insertions(+), 0 deletions(-)

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Matthieu Baerts (Gerrit)

unread,

Mar 28, 2023, 3:32:42 PM3/28/23

to goph...@pubsubhelper.golang.org, Gopher Robot, Emmanuel Odeke, Ian Lance Taylor, Gregory Detal, golang-co...@googlegroups.com

Attention is currently required from: Emmanuel Odeke, Gregory Detal, Ian Lance Taylor.

View Change

1 comment:

Commit Message:

- Patch Set #12, Line 13:
  s/developped/developed/

- Done

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Emmanuel Odeke (Gerrit)

unread,

Mar 28, 2023, 3:51:33 PM3/28/23

to Matthieu Baerts, goph...@pubsubhelper.golang.org, Gopher Robot, Ian Lance Taylor, Gregory Detal, golang-co...@googlegroups.com

Attention is currently required from: Gregory Detal, Ian Lance Taylor, Matthieu Baerts.

Patch set 13:Run-TryBot +1Code-Review +1

View Change

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Emmanuel Odeke (Gerrit)

unread,

Mar 30, 2023, 10:20:12 AM3/30/23

to Matthieu Baerts, goph...@pubsubhelper.golang.org, Gopher Robot, Ian Lance Taylor, Gregory Detal, golang-co...@googlegroups.com

Attention is currently required from: Gregory Detal, Ian Lance Taylor, Matthieu Baerts.

Patch set 15:Run-TryBot +1Code-Review +1

View Change

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Ian Lance Taylor (Gerrit)

unread,

Apr 13, 2023, 5:45:28 PM4/13/23

to Matthieu Baerts, goph...@pubsubhelper.golang.org, Gopher Robot, Emmanuel Odeke, Ian Lance Taylor, Gregory Detal, golang-co...@googlegroups.com

Attention is currently required from: Emmanuel Odeke, Gregory Detal, Ian Lance Taylor, Matthieu Baerts.

Patch set 17:Run-TryBot +1Auto-Submit +1Code-Review +2

View Change

1 comment:

Patchset:
- Patch Set #17:
  Thanks.

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Ian Lance Taylor (Gerrit)

unread,

Apr 17, 2023, 5:14:27 PM4/17/23

to Matthieu Baerts, goph...@pubsubhelper.golang.org, Gopher Robot, Emmanuel Odeke, Ian Lance Taylor, Gregory Detal, golang-co...@googlegroups.com

Attention is currently required from: Emmanuel Odeke, Gregory Detal, Ian Lance Taylor, Matthieu Baerts.

Patch set 19:Run-TryBot +1Auto-Submit +1Code-Review +2

View Change

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Bryan Mills (Gerrit)

unread,

Apr 18, 2023, 9:44:48 AM4/18/23

to Matthieu Baerts, goph...@pubsubhelper.golang.org, Bryan Mills, Gopher Robot, Emmanuel Odeke, Ian Lance Taylor, Gregory Detal, golang-co...@googlegroups.com

Attention is currently required from: Emmanuel Odeke, Gregory Detal, Ian Lance Taylor, Matthieu Baerts.

Patch set 19:Code-Review +1

View Change

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Gopher Robot (Gerrit)

unread,

Apr 18, 2023, 9:44:55 AM4/18/23

to Matthieu Baerts, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Bryan Mills, Emmanuel Odeke, Ian Lance Taylor, Gregory Detal, golang-co...@googlegroups.com

Gopher Robot submitted this change.

View Change

Approvals:
  Ian Lance Taylor: Looks good to me, approved; Run TryBots; Automatically submit change
  Emmanuel Odeke: Looks good to me, but someone else must approve
  Bryan Mills: Looks good to me, but someone else must approve
  Gopher Robot: TryBots succeeded

internal/poll: add GetsockoptInt

This new function wraps the getsockopt network call with an integer
argument, similar to SetsockoptInt.

This will be used in MPTCP in the following commit.

This work has been co-developed by Gregory Detal
<gregor...@tessares.net>.

Updates #59166

Change-Id: I8f6aa00ea2535683d9bbf436993c23e9c6ca2af3

Reviewed-on: https://go-review.googlesource.com/c/go/+/471139
Reviewed-by: Bryan Mills <bcm...@google.com>
Auto-Submit: Ian Lance Taylor <ia...@google.com>
Reviewed-by: Emmanuel Odeke <emma...@orijtech.com>
Reviewed-by: Ian Lance Taylor <ia...@google.com>
Run-TryBot: Ian Lance Taylor <ia...@google.com>
TryBot-Result: Gopher Robot <go...@golang.org>


---
M src/internal/poll/sockopt.go
1 file changed, 9 insertions(+), 0 deletions(-)

diff --git a/src/internal/poll/sockopt.go b/src/internal/poll/sockopt.go
index a7c9d11..a87a9e6 100644
--- a/src/internal/poll/sockopt.go
+++ b/src/internal/poll/sockopt.go
@@ -34,3 +34,12 @@
 	defer fd.decref()
 	return syscall.SetsockoptLinger(fd.Sysfd, level, name, l)
 }
+
+// GetsockoptInt wraps the getsockopt network call with an int argument.
+func (fd *FD) GetsockoptInt(level, name int) (int, error) {
+	if err := fd.incref(); err != nil {
+		return -1, err
+	}
+	defer fd.decref()
+	return syscall.GetsockoptInt(fd.Sysfd, level, name)
+}

To view, visit change 471139. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward