[go/release-branch.go1.25] [release-branch.go1.25] debug/pe: permit symbols with no name

3 views
Skip to first unread message

Carlos Amedee (Gerrit)

unread,
11:24 AM (11 hours ago) 11:24 AM
to goph...@pubsubhelper.golang.org, Ian Lance Taylor, golang-co...@googlegroups.com

Carlos Amedee has uploaded the change for review

Commit message

[release-branch.go1.25] debug/pe: permit symbols with no name

They are reportedly generated by llvm-mingw clang21.

For #75219
Fixes #75221

Change-Id: I7fa7e13039bc7eee826cc19826985ca0e357a9ff
Reviewed-on: https://go-review.googlesource.com/c/go/+/700137
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: Michael Pratt <mpr...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Quim Muntal <quimm...@gmail.com>
Auto-Submit: Ian Lance Taylor <ia...@golang.org>
(cherry picked from commit ea00650784bc2909580c7decf729f668349aa939)

Change diff

diff --git a/src/debug/pe/symbol.go b/src/debug/pe/symbol.go
index 6e8d9d1..80acebe 100644
--- a/src/debug/pe/symbol.go
+++ b/src/debug/pe/symbol.go
@@ -98,7 +98,12 @@
 // isSymNameOffset checks symbol name if it is encoded as offset into string table.
 func isSymNameOffset(name [8]byte) (bool, uint32) {
 	if name[0] == 0 && name[1] == 0 && name[2] == 0 && name[3] == 0 {
-		return true, binary.LittleEndian.Uint32(name[4:])
+		offset := binary.LittleEndian.Uint32(name[4:])
+		if offset == 0 {
+			// symbol has no name
+			return false, 0
+		}
+		return true, offset
 	}
 	return false, 0
 }

Change information

Files:
  • M src/debug/pe/symbol.go
Change size: XS
Delta: 1 file changed, 6 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: release-branch.go1.25
Gerrit-Change-Id: I7fa7e13039bc7eee826cc19826985ca0e357a9ff
Gerrit-Change-Number: 708356
Gerrit-PatchSet: 1
Gerrit-Owner: Carlos Amedee <car...@golang.org>
Gerrit-CC: Ian Lance Taylor <ia...@golang.org>
unsatisfied_requirement
satisfied_requirement
open
diffy

Carlos Amedee (Gerrit)

unread,
11:26 AM (11 hours ago) 11:26 AM
to goph...@pubsubhelper.golang.org, Ian Lance Taylor, golang-co...@googlegroups.com

Carlos Amedee has uploaded the change for review

Commit message

[release-branch.go1.24] debug/pe: permit symbols with no name


They are reportedly generated by llvm-mingw clang21.

For #75219
Fixes #75220
Gerrit-Branch: release-branch.go1.24
Gerrit-Change-Id: I7fa7e13039bc7eee826cc19826985ca0e357a9ff
Gerrit-Change-Number: 708357
unsatisfied_requirement
satisfied_requirement
open
diffy

Carlos Amedee (Gerrit)

unread,
11:27 AM (11 hours ago) 11:27 AM
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, Cherry Mui, Michael Pratt, Quim Muntal, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Ian Lance Taylor, Michael Pratt and Quim Muntal

Carlos Amedee voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
  • Ian Lance Taylor
  • Michael Pratt
  • Quim Muntal
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: release-branch.go1.25
Gerrit-Change-Id: I7fa7e13039bc7eee826cc19826985ca0e357a9ff
Gerrit-Change-Number: 708356
Gerrit-PatchSet: 1
Gerrit-Owner: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Cherry Mui <cher...@google.com>
Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Wed, 01 Oct 2025 15:27:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Carlos Amedee (Gerrit)

unread,
11:27 AM (11 hours ago) 11:27 AM
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, Cherry Mui, Michael Pratt, Quim Muntal, golang-co...@googlegroups.com
Attention needed from Cherry Mui, Ian Lance Taylor, Michael Pratt and Quim Muntal

Carlos Amedee voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Cherry Mui
  • Ian Lance Taylor
  • Michael Pratt
  • Quim Muntal
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: release-branch.go1.24
Gerrit-Change-Id: I7fa7e13039bc7eee826cc19826985ca0e357a9ff
Gerrit-Change-Number: 708357
Gerrit-PatchSet: 1
Gerrit-Owner: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Cherry Mui <cher...@google.com>
Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Wed, 01 Oct 2025 15:27:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Cherry Mui (Gerrit)

unread,
11:31 AM (11 hours ago) 11:31 AM
to Ian Lance Taylor, Carlos Amedee, goph...@pubsubhelper.golang.org, Go LUCI, Michael Pratt, Quim Muntal, golang-co...@googlegroups.com
Attention needed from Carlos Amedee, Ian Lance Taylor, Michael Pratt and Quim Muntal

Cherry Mui voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Carlos Amedee
  • Ian Lance Taylor
  • Michael Pratt
  • Quim Muntal
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: release-branch.go1.25
    Gerrit-Change-Id: I7fa7e13039bc7eee826cc19826985ca0e357a9ff
    Gerrit-Change-Number: 708356
    Gerrit-PatchSet: 1
    Gerrit-Owner: Carlos Amedee <car...@golang.org>
    Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Attention: Michael Pratt <mpr...@google.com>
    Gerrit-Attention: Carlos Amedee <car...@golang.org>
    Gerrit-Comment-Date: Wed, 01 Oct 2025 15:31:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Cherry Mui (Gerrit)

    unread,
    11:31 AM (11 hours ago) 11:31 AM
    to Ian Lance Taylor, Carlos Amedee, goph...@pubsubhelper.golang.org, Go LUCI, Michael Pratt, Quim Muntal, golang-co...@googlegroups.com
    Attention needed from Carlos Amedee, Ian Lance Taylor, Michael Pratt and Quim Muntal

    Cherry Mui voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Carlos Amedee
    • Ian Lance Taylor
    • Michael Pratt
    • Quim Muntal
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: release-branch.go1.24
    Gerrit-Change-Id: I7fa7e13039bc7eee826cc19826985ca0e357a9ff
    Gerrit-Change-Number: 708357
    Gerrit-PatchSet: 1
    Gerrit-Owner: Carlos Amedee <car...@golang.org>
    Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Attention: Michael Pratt <mpr...@google.com>
    Gerrit-Attention: Carlos Amedee <car...@golang.org>
    Gerrit-Comment-Date: Wed, 01 Oct 2025 15:31:35 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Carlos Amedee (Gerrit)

    unread,
    2:34 PM (8 hours ago) 2:34 PM
    to Ian Lance Taylor, goph...@pubsubhelper.golang.org, Go LUCI, Cherry Mui, Michael Pratt, Quim Muntal, golang-co...@googlegroups.com
    Attention needed from Ian Lance Taylor, Michael Pratt and Quim Muntal

    Carlos Amedee voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Lance Taylor
    • Michael Pratt
    • Quim Muntal
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: release-branch.go1.25
    Gerrit-Change-Id: I7fa7e13039bc7eee826cc19826985ca0e357a9ff
    Gerrit-Change-Number: 708356
    Gerrit-PatchSet: 1
    Gerrit-Owner: Carlos Amedee <car...@golang.org>
    Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
    Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Attention: Michael Pratt <mpr...@google.com>
    Gerrit-Comment-Date: Wed, 01 Oct 2025 18:34:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Carlos Amedee (Gerrit)

    unread,
    2:58 PM (8 hours ago) 2:58 PM
    to Ian Lance Taylor, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Cherry Mui, Michael Pratt, Quim Muntal, golang-co...@googlegroups.com

    Carlos Amedee submitted the change

    Change information

    Commit message:
    [release-branch.go1.24] debug/pe: permit symbols with no name

    They are reportedly generated by llvm-mingw clang21.

    For #75219
    Fixes #75220

    Change-Id: I7fa7e13039bc7eee826cc19826985ca0e357a9ff
    Reviewed-on: https://go-review.googlesource.com/c/go/+/700137
    Reviewed-by: Cherry Mui <cher...@google.com>
    Reviewed-by: Michael Pratt <mpr...@google.com>
    LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Quim Muntal <quimm...@gmail.com>
    Auto-Submit: Ian Lance Taylor <ia...@golang.org>
    (cherry picked from commit ea00650784bc2909580c7decf729f668349aa939)
    Files:
    • M src/debug/pe/symbol.go
    Change size: XS
    Delta: 1 file changed, 6 insertions(+), 1 deletion(-)
    Branch: refs/heads/release-branch.go1.24
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Cherry Mui
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
     Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: merged 
    

     Gerrit-Project: go 
    

     Gerrit-Branch: release-branch.go1.24 
    

     Gerrit-Change-Id: I7fa7e13039bc7eee826cc19826985ca0e357a9ff 
    

     Gerrit-Change-Number: 708357 
    

     Gerrit-PatchSet: 2 
    open
    diffy
    satisfied_requirement
    Carlos Amedee (Gerrit)
    unread,
    2:58 PM (8 hours ago) 2:58 PM
    to Ian Lance Taylor, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Cherry Mui, Michael Pratt, Quim Muntal, golang-co...@googlegroups.com
    Carlos Amedee submitted the change
    Change information
    Commit message:
    [release-branch.go1.25] debug/pe: permit symbols with no name


    They are reportedly generated by llvm-mingw clang21.

    For #75219
    Fixes #75221


    Change-Id: I7fa7e13039bc7eee826cc19826985ca0e357a9ff
    Reviewed-on: https://go-review.googlesource.com/c/go/+/700137
    Reviewed-by: Cherry Mui <cher...@google.com>
    Reviewed-by: Michael Pratt <mpr...@google.com>
    LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Quim Muntal <quimm...@gmail.com>
    Auto-Submit: Ian Lance Taylor <ia...@golang.org>
    (cherry picked from commit ea00650784bc2909580c7decf729f668349aa939)
    Files:
    • M src/debug/pe/symbol.go
    Change size: XS
    Delta: 1 file changed, 6 insertions(+), 1 deletion(-)
    Branch: refs/heads/release-branch.go1.25
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Cherry Mui
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: merged 
    

     Gerrit-Project: go 
    

     Gerrit-Branch: release-branch.go1.25 
    

     Gerrit-Change-Id: I7fa7e13039bc7eee826cc19826985ca0e357a9ff 
    

     Gerrit-Change-Number: 708356 
    

    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages