[go] runtime: fix printfloat, printcomplex buffer sizes
0 views
Skip to first unread message
Michael Pratt (Gerrit)
3:43 PM (3 hours ago) 3:43 PM
to Michael Pratt, goph...@pubsubhelper.golang.org, Russ Cox, Michael Knyszek, golang-co...@googlegroups.com
Attention needed from Michael Knyszek and Russ Cox
Michael Pratt voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Michael Knyszek
- Russ Cox
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
3:49 PM (3 hours ago) 3:49 PM
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Michael Knyszek and Russ Cox
Michael Pratt uploaded new patchset![]( "Open in Gerrit")
Michael Pratt uploaded patch set #2 to this change.
Related details
Attention is currently required from:
- Michael Knyszek
- Russ Cox
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Knyszek (Gerrit)
3:59 PM (3 hours ago) 3:59 PM
to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, Russ Cox, golang-co...@googlegroups.com
Attention needed from Michael Pratt and Russ Cox
Michael Knyszek voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Michael Pratt
- Russ Cox
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Russ Cox (Gerrit)
5:17 PM (1 hour ago) 5:17 PM
to Michael Pratt, goph...@pubsubhelper.golang.org, Go LUCI, Russ Cox, golang-co...@googlegroups.com
Attention needed from Michael Pratt
Russ Cox added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Russ Cox . resolved
Thanks, and apologies. Flag for next minor release.
File src/runtime/print.go
Line 141, Patchset 2 (Latest):
// complex128 requires 24+24+1+1+1 = 51 bytes max (float64+float64+paren+sign+i+paren).Russ Cox . unresolved
(paren+float64+float64+i+paren)
The comment mentions sign but that's included in the float64. The math is right.
Line 149, Patchset 2 (Latest):
// complex64 requires 15+15+1+1+1 = 33 bytes max (float32+float32+paren+sign+i+paren).Russ Cox . unresolved
(paren+float32+float32+i+paren)
Related details
Attention is currently required from:
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Russ Cox (Gerrit)
5:17 PM (1 hour ago) 5:17 PM
to Michael Pratt, goph...@pubsubhelper.golang.org, Russ Cox, Go LUCI, golang-co...@googlegroups.com
Attention needed from Michael Pratt
Russ Cox voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages