[go] math/pow10: remove overlapping boundary (n=0)
3 views
Skip to first unread message
Wanbiao Ye (Gerrit)
Dec 15, 2025, 2:11:19 AM (yesterday) Dec 15
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Wanbiao Ye has uploaded the change for review![]( "Open in Gerrit")
Commit message
math/pow10: remove overlapping boundary (n=0)
Both the first and second conditions include n=0, creating an
implicit logic that relies on order of evaluation. Testing has shown
that this modification will not affect performance or assembly code
in linux/amd64.
Change-Id: Iefbc25a676242fabf272203a3e845363585bff56
Change diff
diff --git a/src/math/pow10.go b/src/math/pow10.go
index c31ad8d..6f84db0 100644
--- a/src/math/pow10.go
+++ b/src/math/pow10.go
@@ -33,7 +33,7 @@
return pow10postab32[uint(n)/32] * pow10tab[uint(n)%32]
}
- if -323 <= n && n <= 0 {
+ if -323 <= n && n < 0 {
return pow10negtab32[uint(-n)/32] / pow10tab[uint(-n)%32]
}
Change information
Files:
- M src/math/pow10.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wanbiao Ye (Gerrit)
Dec 15, 2025, 10:17:46 PM (16 hours ago) Dec 15
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Robert Griesemer and Russ Cox
Wanbiao Ye uploaded new patchset![]( "Open in Gerrit")
Wanbiao Ye uploaded patch set #2 to this change.
Related details
Attention is currently required from:
- Robert Griesemer
- Russ Cox
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages