[website] cmd/golangorg: fix package link URLs

0 views
Skip to first unread message

Dmitri Shuralyov (Gerrit)

unread,
3:12 PM (6 hours ago) 3:12 PM
to Russ Cox, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Go LUCI, golang-co...@googlegroups.com
Attention needed from Russ Cox

Dmitri Shuralyov voted and added 2 comments

Votes added by Dmitri Shuralyov

Code-Review+2

2 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Dmitri Shuralyov . resolved

Thanks. Glad to see those two sets of identical pages converge.

File cmd/golangorg/testdata/godev.txt
Line 136, Patchset 1 (Latest):body contains href="/cmd/link/internal/loader/?m=old#Loader
Dmitri Shuralyov . resolved

I take it this internal API is expected to be stable enough that it's fine to make this test case depend on it.

Open in Gerrit

Related details

Attention is currently required from:
  • Russ Cox
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: website
Gerrit-Branch: master
Gerrit-Change-Id: Ib5c205b3faf53aff0f0bb6d475fa942a6718e616
Gerrit-Change-Number: 596436
Gerrit-PatchSet: 1
Gerrit-Owner: Russ Cox <r...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Russ Cox <r...@golang.org>
Gerrit-Attention: Russ Cox <r...@golang.org>
Gerrit-Comment-Date: Wed, 03 Jul 2024 19:12:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
3:13 PM (6 hours ago) 3:13 PM
to Russ Cox, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Go LUCI, golang-co...@googlegroups.com
Attention needed from Russ Cox

Dmitri Shuralyov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Russ Cox
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: website
    Gerrit-Branch: master
    Gerrit-Change-Id: Ib5c205b3faf53aff0f0bb6d475fa942a6718e616
    Gerrit-Change-Number: 596436
    Gerrit-PatchSet: 1
    Gerrit-Owner: Russ Cox <r...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Reviewer: Russ Cox <r...@golang.org>
    Gerrit-Attention: Russ Cox <r...@golang.org>
    Gerrit-Comment-Date: Wed, 03 Jul 2024 19:13:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages