[pkgsite-metrics] Makefile: set project ID for docker runs.

1 view
Skip to first unread message

Markus Kusano (Gerrit)

unread,
12:19 PM (10 hours ago) 12:19 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Markus Kusano has uploaded the change for review

Commit message

Makefile: set project ID for docker runs.

Without this, the server fails on startup due to the project being
empty.
Change-Id: I9f06d8d6241264dbb2b7b5eab332c0d09a3505bf

Change diff

diff --git a/Makefile b/Makefile
index 8b87c12..b808169 100644
--- a/Makefile
+++ b/Makefile
@@ -55,6 +55,7 @@
 
 DOCKER_RUN_ARGS := --rm --privileged -p 8080:8080 \
 	--env GO_ECOSYSTEM_BINARY_BUCKET=go-ecosystem \
+	--env GOOGLE_CLOUD_PROJECT=go-ecosystem \
 	$(DOCKER_AUTH_ARGS)
 
 DOCKER_ID_FILE := /tmp/ecosystem-docker-container-id

Change information

Files:
  • M Makefile
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: pkgsite-metrics
Gerrit-Branch: master
Gerrit-Change-Id: I9f06d8d6241264dbb2b7b5eab332c0d09a3505bf
Gerrit-Change-Number: 708376
Gerrit-PatchSet: 1
Gerrit-Owner: Markus Kusano <kus...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Markus Kusano (Gerrit)

unread,
12:29 PM (10 hours ago) 12:29 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Markus Kusano voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pkgsite-metrics
Gerrit-Branch: master
Gerrit-Change-Id: I9f06d8d6241264dbb2b7b5eab332c0d09a3505bf
Gerrit-Change-Number: 708376
Gerrit-PatchSet: 1
Gerrit-Owner: Markus Kusano <kus...@google.com>
Gerrit-Reviewer: Markus Kusano <kus...@google.com>
Gerrit-Comment-Date: Wed, 01 Oct 2025 16:29:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Ethan Lee (Gerrit)

unread,
1:41 PM (9 hours ago) 1:41 PM
to Markus Kusano, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Markus Kusano

Ethan Lee voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Markus Kusano
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: pkgsite-metrics
Gerrit-Branch: master
Gerrit-Change-Id: I9f06d8d6241264dbb2b7b5eab332c0d09a3505bf
Gerrit-Change-Number: 708376
Gerrit-PatchSet: 1
Gerrit-Owner: Markus Kusano <kus...@google.com>
Gerrit-Reviewer: Ethan Lee <etha...@google.com>
Gerrit-Reviewer: Markus Kusano <kus...@google.com>
Gerrit-Attention: Markus Kusano <kus...@google.com>
Gerrit-Comment-Date: Wed, 01 Oct 2025 17:41:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages