[tools] internal/pkgbits: sync version.go with goroot

0 views
Skip to first unread message

Robert Griesemer (Gerrit)

unread,
Mar 19, 2026, 3:56:42 PM (14 hours ago) Mar 19
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Robert Griesemer has uploaded the change for review

Commit message

internal/pkgbits: sync version.go with goroot

This updates the format version to V3 to support CompactCompLiterals
in export data, fixing tests that fail due to an unsupported version
when importing packages built with Go 1.25.
Change-Id: I0ca56cb1af14e9aa357523d77222f266290c4d84

Change diff

diff --git a/internal/pkgbits/version.go b/internal/pkgbits/version.go
index 53af9df..beebb22 100644
--- a/internal/pkgbits/version.go
+++ b/internal/pkgbits/version.go
@@ -1,4 +1,4 @@
-// Copyright 2024 The Go Authors. All rights reserved.
+// Copyright 2021 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
@@ -28,6 +28,12 @@
 	// - remove derived info "needed" bool
 	V2
 
+	// V3: introduces a more compact format for composite literal element lists
+	// - negative lengths indicate that (some) elements may have keys
+	// - positive lengths indicate that no element has a key
+	// - a negative struct field index indicates an embedded field
+	V3
+
 	numVersions = iota
 )
 
@@ -61,6 +67,9 @@
 	// whether a type was a derived type.
 	DerivedInfoNeeded
 
+	// Composite literals use a more compact format for element lists.
+	CompactCompLiterals
+
 	numFields = iota
 )
 
@@ -68,6 +77,7 @@
 var introduced = [numFields]Version{
 	Flags:               V1,
 	AliasTypeParamNames: V2,
+	CompactCompLiterals: V3,
 }
 
 // removed is the version a field was removed in or 0 for fields

Change information

Files:
  • M internal/pkgbits/version.go
Change size: S
Delta: 1 file changed, 11 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I0ca56cb1af14e9aa357523d77222f266290c4d84
Gerrit-Change-Number: 757060
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Griesemer <g...@google.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Robert Griesemer (Gerrit)

unread,
Mar 19, 2026, 3:58:46 PM (14 hours ago) Mar 19
to goph...@pubsubhelper.golang.org, Alan Donovan, golang-co...@googlegroups.com
Attention needed from Alan Donovan

Robert Griesemer voted

Code-Review+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I0ca56cb1af14e9aa357523d77222f266290c4d84
Gerrit-Change-Number: 757060
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Griesemer <g...@google.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Robert Griesemer <g...@google.com>
Gerrit-Attention: Alan Donovan <adon...@google.com>
Gerrit-Comment-Date: Thu, 19 Mar 2026 19:58:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Mark Freeman (Gerrit)

unread,
Mar 19, 2026, 4:04:27 PM (14 hours ago) Mar 19
to Robert Griesemer, goph...@pubsubhelper.golang.org, Go LUCI, Alan Donovan, golang-co...@googlegroups.com
Attention needed from Alan Donovan and Robert Griesemer

Mark Freeman voted and added 1 comment

Votes added by Mark Freeman

Code-Review+2

1 comment

File internal/pkgbits/version.go
Line 1, Patchset 1 (Latest):// Copyright 2021 The Go Authors. All rights reserved.
Mark Freeman . unresolved

Intentional?

Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
  • Robert Griesemer
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I0ca56cb1af14e9aa357523d77222f266290c4d84
Gerrit-Change-Number: 757060
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Griesemer <g...@google.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Robert Griesemer <g...@google.com>
Gerrit-Attention: Robert Griesemer <g...@google.com>
Gerrit-Attention: Alan Donovan <adon...@google.com>
Gerrit-Comment-Date: Thu, 19 Mar 2026 20:04:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Robert Griesemer (Gerrit)

unread,
Mar 19, 2026, 4:08:51 PM (13 hours ago) Mar 19
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Alan Donovan and Robert Griesemer

Robert Griesemer uploaded new patchset

Robert Griesemer uploaded patch set #2 to this change.
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
  • Robert Griesemer
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newpatchset
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I0ca56cb1af14e9aa357523d77222f266290c4d84
Gerrit-Change-Number: 757060
Gerrit-PatchSet: 2
satisfied_requirement
unsatisfied_requirement
open
diffy

Robert Griesemer (Gerrit)

unread,
Mar 19, 2026, 4:09:43 PM (13 hours ago) Mar 19
to goph...@pubsubhelper.golang.org, Go LUCI, Mark Freeman, Alan Donovan, golang-co...@googlegroups.com
Attention needed from Alan Donovan

Robert Griesemer voted and added 1 comment

Votes added by Robert Griesemer

Code-Review+1
Commit-Queue+1

1 comment

File internal/pkgbits/version.go
Line 1, Patchset 1:// Copyright 2021 The Go Authors. All rights reserved.
Mark Freeman . resolved

Intentional?

Robert Griesemer

copy&paste error - fixed

Open in Gerrit

Related details

Attention is currently required from:
  • Alan Donovan
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I0ca56cb1af14e9aa357523d77222f266290c4d84
Gerrit-Change-Number: 757060
Gerrit-PatchSet: 2
Gerrit-Owner: Robert Griesemer <g...@google.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Robert Griesemer <g...@google.com>
Gerrit-Attention: Alan Donovan <adon...@google.com>
Gerrit-Comment-Date: Thu, 19 Mar 2026 20:09:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Mark Freeman <markf...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Robert Griesemer (Gerrit)

unread,
Mar 19, 2026, 5:32:50 PM (12 hours ago) Mar 19
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Mark Freeman, Alan Donovan, golang-co...@googlegroups.com

Robert Griesemer submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: internal/pkgbits/version.go
Insertions: 1, Deletions: 1.

@@ -1,4 +1,4 @@
-// Copyright 2021 The Go Authors. All rights reserved.
+// Copyright 2024 The Go Authors. All rights reserved.

 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
```

Change information

Commit message:
internal/pkgbits: sync version.go with goroot

This updates the format version to V3 to support CompactCompLiterals
in export data, fixing tests that fail due to an unsupported version
when importing packages built with Go 1.25.
Change-Id: I0ca56cb1af14e9aa357523d77222f266290c4d84
Reviewed-by: Mark Freeman <markf...@google.com>
Reviewed-by: Robert Griesemer <g...@google.com>
Files:
  • M internal/pkgbits/version.go
Change size: S
Delta: 1 file changed, 10 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Robert Griesemer, +2 by Mark Freeman
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I0ca56cb1af14e9aa357523d77222f266290c4d84
Gerrit-Change-Number: 757060
Gerrit-PatchSet: 3
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages