[go] time: add DateTime, DateOnly, and TimeOnly
Joseph Tsai (Gerrit)
Joseph Tsai has uploaded this change for review.
time: add DateTime, DateOnly, and TimeOnly
Add named constants for the 3rd, 4th, and 13th most popular formats.
Fixes #52746
Change-Id: I7ce92e44dcae18c089124f1d6f5bc2d6359d436c
---
M src/time/format.go
1 file changed, 16 insertions(+), 0 deletions(-)
diff --git a/src/time/format.go b/src/time/format.go
index 5f69618..f7cdade 100644
--- a/src/time/format.go
+++ b/src/time/format.go
@@ -116,6 +116,9 @@
StampMilli = "Jan _2 15:04:05.000"
StampMicro = "Jan _2 15:04:05.000000"
StampNano = "Jan _2 15:04:05.000000000"
+ DateTime = "2006-01-02 15:04:05"
+ DateOnly = "2006-01-02"
+ TimeOnly = "15:04:05"
)
const (
To view, visit change 412495. To unsubscribe, or for help writing mail filters, visit settings.
Joseph Tsai (Gerrit)
Joseph Tsai uploaded patch set #2 to this change.
time: add DateTime, DateOnly, and TimeOnly
Add named constants for the 3rd, 4th, and 13th most popular formats.
Fixes #52746
Change-Id: I7ce92e44dcae18c089124f1d6f5bc2d6359d436c
---
M src/time/format.go
M src/time/format_test.go
2 files changed, 19 insertions(+), 0 deletions(-)
To view, visit change 412495. To unsubscribe, or for help writing mail filters, visit settings.
Joseph Tsai (Gerrit)
Patch set 2:Run-TryBot +1Auto-Submit +1
Joseph Tsai (Gerrit)
Attention is currently required from: Joseph Tsai.
Joseph Tsai uploaded patch set #3 to this change.
The following approvals got outdated and were removed: Auto-Submit+1 by Joseph Tsai, Run-TryBot+1 by Joseph Tsai
time: add DateTime, DateOnly, and TimeOnly
Add named constants for the 3rd, 4th, and 13th most popular formats.
Fixes #52746
Change-Id: I7ce92e44dcae18c089124f1d6f5bc2d6359d436c
---
A api/next/52746.txt
M src/time/format.go
M src/time/format_test.go
3 files changed, 22 insertions(+), 0 deletions(-)
To view, visit change 412495. To unsubscribe, or for help writing mail filters, visit settings.
Joseph Tsai (Gerrit)
Patch set 3:Run-TryBot +1Auto-Submit +1
To view, visit change 412495. To unsubscribe, or for help writing mail filters, visit settings.
Joseph Tsai (Gerrit)
Patch set 4:Run-TryBot +1Auto-Submit +1
Ian Lance Taylor (Gerrit)
Attention is currently required from: Joseph Tsai.
1 comment:
File api/next/52746.txt:
Patch Set #4, Line 1:
pkg time, const DateOnly = "2006-01-02"The format is
pkg time, const DateOnly = "2006-01-02" #52746
That is, you are missing the proposal number at the end of the line. It's not currently taken from the file name.
To view, visit change 412495. To unsubscribe, or for help writing mail filters, visit settings.
Joseph Tsai (Gerrit)
Attention is currently required from: Joseph Tsai.
Joseph Tsai uploaded patch set #5 to this change.
The following approvals got outdated and were removed: Auto-Submit+1 by Joseph Tsai, Run-TryBot+1 by Joseph Tsai, TryBot-Result-1 by Gopher Robot
time: add DateTime, DateOnly, and TimeOnly
Add named constants for the 3rd, 4th, and 13th most popular formats.
Fixes #52746
Change-Id: I7ce92e44dcae18c089124f1d6f5bc2d6359d436c
---
A api/next/52746.txt
M src/time/format.go
M src/time/format_test.go
3 files changed, 22 insertions(+), 0 deletions(-)
To view, visit change 412495. To unsubscribe, or for help writing mail filters, visit settings.
Joseph Tsai (Gerrit)
Attention is currently required from: Ian Lance Taylor.
Patch set 5:Run-TryBot +1Auto-Submit +1
1 comment:
File api/next/52746.txt:
Patch Set #4, Line 1:
pkg time, const DateOnly = "2006-01-02"
The format is […]
Ah, thank you.
To view, visit change 412495. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Joseph Tsai.
Patch set 5:Code-Review +2
1 comment:
Patchset:
RELNOTE=yes
To view, visit change 412495. To unsubscribe, or for help writing mail filters, visit settings.
Joseph Tsai (Gerrit)
Attention is currently required from: Joseph Tsai.
Joseph Tsai uploaded patch set #6 to this change.
The following approvals got outdated and were removed: Auto-Submit+1 by Joseph Tsai, Run-TryBot+1 by Joseph Tsai, TryBot-Result-1 by Gopher Robot
time: add DateTime, DateOnly, and TimeOnly
Add named constants for the 3rd, 4th, and 13th most popular formats.
Fixes #52746
Change-Id: I7ce92e44dcae18c089124f1d6f5bc2d6359d436c
---
A api/next/52746.txt
M src/time/format.go
M src/time/format_test.go
3 files changed, 25 insertions(+), 0 deletions(-)
To view, visit change 412495. To unsubscribe, or for help writing mail filters, visit settings.
Joseph Tsai (Gerrit)
Patch set 6:Run-TryBot +1Auto-Submit +1
To view, visit change 412495. To unsubscribe, or for help writing mail filters, visit settings.
Dmitri Shuralyov (Gerrit)
Attention is currently required from: Joseph Tsai.
Patch set 6:Code-Review +1
Gopher Robot (Gerrit)
Gopher Robot submitted this change.
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: api/next/52746.txt
Insertions: 3, Deletions: 0.
@@ -1,3 +1,6 @@
pkg time, const DateOnly = "2006-01-02" #52746
+pkg time, const DateOnly ideal-string #52746
pkg time, const DateTime = "2006-01-02 15:04:05" #52746
+pkg time, const DateTime ideal-string #52746
pkg time, const TimeOnly = "15:04:05" #52746
+pkg time, const TimeOnly ideal-string #52746
```
time: add DateTime, DateOnly, and TimeOnly
Add named constants for the 3rd, 4th, and 13th most popular formats.
Fixes #52746
Change-Id: I7ce92e44dcae18c089124f1d6f5bc2d6359d436c
Reviewed-on: https://go-review.googlesource.com/c/go/+/412495
Reviewed-by: Ian Lance Taylor <ia...@google.com>
Auto-Submit: Joseph Tsai <joe...@digital-static.net>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
TryBot-Result: Gopher Robot <go...@golang.org>
Run-TryBot: Joseph Tsai <joe...@digital-static.net>
---
A api/next/52746.txt
M src/time/format.go
M src/time/format_test.go
3 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/api/next/52746.txt b/api/next/52746.txt
new file mode 100644
index 0000000..d6c3bd2
--- /dev/null
+++ b/api/next/52746.txt
@@ -0,0 +1,6 @@
+pkg time, const DateOnly = "2006-01-02" #52746
+pkg time, const DateOnly ideal-string #52746
+pkg time, const DateTime = "2006-01-02 15:04:05" #52746
+pkg time, const DateTime ideal-string #52746
+pkg time, const TimeOnly = "15:04:05" #52746
+pkg time, const TimeOnly ideal-string #52746
diff --git a/src/time/format.go b/src/time/format.go
index 8431ff8..61a9eb3 100644
--- a/src/time/format.go
+++ b/src/time/format.go
@@ -116,6 +116,9 @@
StampMilli = "Jan _2 15:04:05.000"
StampMicro = "Jan _2 15:04:05.000000"
StampNano = "Jan _2 15:04:05.000000000"
+ DateTime = "2006-01-02 15:04:05"
+ DateOnly = "2006-01-02"
+ TimeOnly = "15:04:05"
)
const (
diff --git a/src/time/format_test.go b/src/time/format_test.go
index 9ae2b80..fa8c846 100644
--- a/src/time/format_test.go
+++ b/src/time/format_test.go
@@ -115,6 +115,9 @@
{"StampMilli", StampMilli, "Feb 4 21:00:57.012"},
{"StampMicro", StampMicro, "Feb 4 21:00:57.012345"},
{"StampNano", StampNano, "Feb 4 21:00:57.012345600"},
+ {"DateTime", DateTime, "2009-02-04 21:00:57"},
+ {"DateOnly", DateOnly, "2009-02-04"},
+ {"TimeOnly", TimeOnly, "21:00:57"},
{"YearDay", "Jan 2 002 __2 2", "Feb 4 035 35 4"},
{"Year", "2006 6 06 _6 __6 ___6", "2009 6 09 _6 __6 ___6"},
{"Month", "Jan January 1 01 _1", "Feb February 2 02 _2"},
To view, visit change 412495. To unsubscribe, or for help writing mail filters, visit settings.