[wiki] Watchflakes: add example for matching all subtests
1 view
Skip to first unread message
Michael Pratt (Gerrit)
5:13 PM (6 hours ago) 5:13 PM
to Michael Pratt, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Dmitri Shuralyov
Michael Pratt voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Cherry Mui
- Dmitri Shuralyov
Submit Requirements:
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dmitri Shuralyov (Gerrit)
5:15 PM (6 hours ago) 5:15 PM
to Michael Pratt, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and Michael Pratt
Dmitri Shuralyov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dmitri Shuralyov
| Code-Review | +2 |
2 comments
Patchset-level comments
File Watchflakes.md
Line 186, Patchset 1 (Latest):
post <- pkg == "net/http" && test ~ `^TestServeIndexHtml/.*`Dmitri Shuralyov . unresolved
Because of the mandatory '/', this will exclude failures in the top-level TestServeIndexHtml test itself. Maybe it's more common to want to match the test and all its subtests too? If so, consider something like:
```suggestion
post <- pkg == "net/http" && test ~ `^TestServeIndexHtml(/.+)?$`
```
Related details
Attention is currently required from:
- Cherry Mui
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
5:33 PM (6 hours ago) 5:33 PM
to Michael Pratt, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, golang-co...@googlegroups.com
Attention needed from Michael Pratt
Cherry Mui voted and added 1 comment![]( "Open in Gerrit")
Votes added by Cherry Mui
| Code-Review | +2 |
1 comment
File Watchflakes.md
Line 186, Patchset 1 (Latest):
post <- pkg == "net/http" && test ~ `^TestServeIndexHtml/.*`Dmitri Shuralyov . unresolved
Because of the mandatory '/', this will exclude failures in the top-level TestServeIndexHtml test itself. Maybe it's more common to want to match the test and all its subtests too? If so, consider something like:
```suggestion
post <- pkg == "net/http" && test ~ `^TestServeIndexHtml(/.+)?$`
```
Cherry Mui
In most cases a test's name is not a prefix of another, so `^TestServeIndexHtml` works just fine, and is what I usually do (and also omit the `^` as it is pretty rare a test has "Test" in the middle). We could be precise here, although it perhaps doesn't really matter much.
Related details
Attention is currently required from:
- Michael Pratt
Submit Requirements:
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages