[go] runtime: add linkname back on `runtime.lastmoduledatap`
Gerrit Bot (Gerrit)
Gerrit Bot has uploaded the change for review![]( "Open in Gerrit")
Commit message
runtime: add linkname back on `runtime.lastmoduledatap`
Fixes #71672
Change diff
diff --git a/src/runtime/symtab.go b/src/runtime/symtab.go
index c3bd510..0419fcc 100644
--- a/src/runtime/symtab.go
+++ b/src/runtime/symtab.go
@@ -480,7 +480,13 @@
// the relocated one.
var aixStaticDataBase uintptr // linker symbol
-var firstmoduledata moduledata // linker symbol
+var firstmoduledata moduledata // linker symbol
+
+// Do not remove or change the type signature.
+// See go.dev/issue/67401.
+// See go.dev/issues/71672.
+//
+//go:linkname lastmoduledatap runtime.lastmoduledatap
var lastmoduledatap *moduledata // linker symbol
var modulesSlice *[]*moduledata // see activeModules
Change information
- M src/runtime/symtab.go
Related details
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Gopher Robot added 1 comment![]( "Open in Gerrit")
I spotted some possible problems.
These findings are based on simple heuristics. If a finding appears wrong, briefly reply here saying so. Otherwise, please address any problems and update the GitHub PR. When complete, mark this comment as 'Done' and click the [blue 'Reply' button](https://go.dev/wiki/GerritBot#i-left-a-reply-to-a-comment-in-gerrit-but-no-one-but-me-can-see-it) above.
Possible problems detected:
1. The commit message body is very brief. That can be OK if the change is trivial like correcting spelling or fixing a broken link, but usually the description should provide context for the change and explain what it does in complete sentences.
The commit title and commit message body come from the GitHub PR title and description, and must be edited in the GitHub web interface (not via git). For instructions, see [here](https://go.dev/wiki/GerritBot/#how-does-gerritbot-determine-the-final-commit-message). For guidelines on commit messages for the Go project, see [here](https://go.dev/doc/contribute#commit_messages).
(In general for Gerrit code reviews, the change author is expected to [log in to Gerrit](https://go-review.googlesource.com/login/) with a Gmail or other Google account and then close out each piece of feedback by marking it as 'Done' if implemented as suggested or otherwise reply to each review comment. See the [Review](https://go.dev/doc/contribute#review) section of the Contributing Guide for details.)
Related details
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Message from Gopher Robot![]( "Open in Gerrit")
Congratulations on opening your first change. Thank you for your contribution!
Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.
Related details
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jorropo (Gerrit)
Jorropo added 1 comment![]( "Open in Gerrit")
// See go.dev/issue/67401.This links to https://github.com/golang/go/issues/created_by/67401 which is wrong.(`s,issue,issues,g`)
Related details
- Keith Randall
- Michael Knyszek
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Lance Taylor (Gerrit)
Ian Lance Taylor added 1 comment![]( "Open in Gerrit")
This needs the full "hall of shame" list of packages that need it. See what it used to look like in https://go.dev/cl/609918.
Related details
- Keith Randall
- Michael Knyszek
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gerrit Bot (Gerrit)
Gerrit Bot uploaded new patchset![]( "Open in Gerrit")
Related details
- Keith Randall
- Michael Knyszek
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gerrit Bot (Gerrit)
Gerrit Bot uploaded new patchset![]( "Open in Gerrit")
Related details
- Keith Randall
- Michael Knyszek
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gerrit Bot (Gerrit)
Gerrit Bot uploaded new patchset![]( "Open in Gerrit")
Related details
- Keith Randall
- Michael Knyszek
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yi Duan (Gerrit)
Yi Duan added 3 comments![]( "Open in Gerrit")
This links to https://github.com/golang/go/issues/created_by/67401 which is wrong.(`s,issue,issues,g`)
Acknowledged
This needs the full "hall of shame" list of packages that need it. See what it used to look like in https://go.dev/cl/609918.
- Ian Lance Taylor
- Jorropo
- Keith Randall
- Michael Knyszek
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Lance Taylor (Gerrit)
Ian Lance Taylor voted Commit-Queue+1![]( "Open in Gerrit")
- Jorropo
- Keith Randall
- Michael Knyszek
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yi Duan (Gerrit)
Yi Duan added 2 comments![]( "Open in Gerrit")
I spotted some possible problems.
These findings are based on simple heuristics. If a finding appears wrong, briefly reply here saying so. Otherwise, please address any problems and update the GitHub PR. When complete, mark this comment as 'Done' and click the [blue 'Reply' button](https://go.dev/wiki/GerritBot#i-left-a-reply-to-a-comment-in-gerrit-but-no-one-but-me-can-see-it) above.
Possible problems detected:
1. The commit message body is very brief. That can be OK if the change is trivial like correcting spelling or fixing a broken link, but usually the description should provide context for the change and explain what it does in complete sentences.The commit title and commit message body come from the GitHub PR title and description, and must be edited in the GitHub web interface (not via git). For instructions, see [here](https://go.dev/wiki/GerritBot/#how-does-gerritbot-determine-the-final-commit-message). For guidelines on commit messages for the Go project, see [here](https://go.dev/doc/contribute#commit_messages).
(In general for Gerrit code reviews, the change author is expected to [log in to Gerrit](https://go-review.googlesource.com/login/) with a Gmail or other Google account and then close out each piece of feedback by marking it as 'Done' if implemented as suggested or otherwise reply to each review comment. See the [Review](https://go.dev/doc/contribute#review) section of the Contributing Guide for details.)
Acknowledged
Yi DuanThis links to https://github.com/golang/go/issues/created_by/67401 which is wrong.(`s,issue,issues,g`)
Acknowledged
resolved
Related details
- Jorropo
- Keith Randall
- Michael Knyszek
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gerrit Bot (Gerrit)
Gerrit Bot uploaded new patchset![]( "Open in Gerrit")
- TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Related details
- Ian Lance Taylor
- Jorropo
- Keith Randall
- Michael Knyszek
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gerrit Bot (Gerrit)
Gerrit Bot uploaded new patchset![]( "Open in Gerrit")
Related details
- Ian Lance Taylor
- Jorropo
- Keith Randall
- Michael Knyszek
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
Michael Pratt added 4 comments![]( "Open in Gerrit")
//go:linkname pluginsMu plugin.pluginsMuWe never had a linkname on pluginsMu. Does sonic need this? If so, how did sonic work with 1.23?
//go:linkname morestack_noctxt runtime.morestack_noctxtThe target name is not necessary.
```suggestion
//go:linkname morestack_noctxt
```
//go:linkname lastmoduledatap runtime.lastmoduledatap```suggestion
//go:linkname lastmoduledatap
```
//go:linkname moduledataverify1 runtime.moduledataverify1```suggestion
//go:linkname moduledataverify1
```
Related details
- Ian Lance Taylor
- Jorropo
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
Michael Pratt voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Gerrit Bot (Gerrit)
Gerrit Bot uploaded new patchset![]( "Open in Gerrit")
- TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Related details
- Ian Lance Taylor
- Jorropo
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yi Duan (Gerrit)
Yi Duan added 4 comments![]( "Open in Gerrit")
//go:linkname pluginsMu plugin.pluginsMuWe never had a linkname on pluginsMu. Does sonic need this? If so, how did sonic work with 1.23?
It can work before. But we found it may cause data-race when using go/pluing and sonic together recently...That's why we want to use this lock to avoid the concurrently-register-moduledata problem
//go:linkname morestack_noctxt runtime.morestack_noctxtThe target name is not necessary.
```suggestion
//go:linkname morestack_noctxt
```
Acknowledged
//go:linkname lastmoduledatap runtime.lastmoduledatapYi Duan```suggestion
//go:linkname lastmoduledatap
```
Acknowledged
//go:linkname moduledataverify1 runtime.moduledataverify1Yi Duan```suggestion
//go:linkname moduledataverify1
```
Acknowledged
Related details
- Ian Lance Taylor
- Jorropo
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yi Duan (Gerrit)
Yi Duan added 1 comment![]( "Open in Gerrit")
//go:linkname pluginsMu plugin.pluginsMuYi DuanWe never had a linkname on pluginsMu. Does sonic need this? If so, how did sonic work with 1.23?
It can work before. But we found it may cause data-race when using go/pluing and sonic together recently...That's why we want to use this lock to avoid the concurrently-register-moduledata problem
Done
Related details
- Ian Lance Taylor
- Jorropo
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gerrit Bot (Gerrit)
Gerrit Bot uploaded new patchset![]( "Open in Gerrit")
Related details
- Ian Lance Taylor
- Jorropo
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
Michael Pratt added 1 comment![]( "Open in Gerrit")
//go:linkname pluginsMu plugin.pluginsMuYi DuanWe never had a linkname on pluginsMu. Does sonic need this? If so, how did sonic work with 1.23?
Yi DuanIt can work before. But we found it may cause data-race when using go/pluing and sonic together recently...That's why we want to use this lock to avoid the concurrently-register-moduledata problem
Done
Please open a new issue to discuss this and remove from this CL. Since this is a completely new linkname it is out of scope for this CL, which is just restoring linknames that existed previously.
Related details
- Ian Lance Taylor
- Jorropo
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gerrit Bot (Gerrit)
Gerrit Bot uploaded new patchset![]( "Open in Gerrit")
- Ian Lance Taylor
- Jorropo
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yi Duan (Gerrit)
Yi Duan added 1 comment![]( "Open in Gerrit")
//go:linkname pluginsMu plugin.pluginsMuYi DuanWe never had a linkname on pluginsMu. Does sonic need this? If so, how did sonic work with 1.23?
Yi DuanIt can work before. But we found it may cause data-race when using go/pluing and sonic together recently...That's why we want to use this lock to avoid the concurrently-register-moduledata problem
Michael PrattDone
Please open a new issue to discuss this and remove from this CL. Since this is a completely new linkname it is out of scope for this CL, which is just restoring linknames that existed previously.
Acknowledged
Related details
- Ian Lance Taylor
- Jorropo
- Michael Pratt
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Pratt (Gerrit)
Michael Pratt voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
- Ian Lance Taylor
- Jorropo
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Lance Taylor (Gerrit)
Ian Lance Taylor voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ian Lance Taylor
| Auto-Submit | +1 |
| Code-Review | +2 |
| Commit-Queue | +1 |
Thanks.
Related details
- Ian Lance Taylor
- Jorropo
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Gopher Robot submitted the change![]( "Open in Gerrit")
Unreviewed changes
9 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
runtime: add some linknames back for `github.com/bytedance/sonic`
Add some linknames back, therefore sonic (github.com/bytedance/sonic) can work correctly.
Fixes #71672
- M src/runtime/stubs.go
- M src/runtime/symtab.go
Code-Review: +2 by Ian Lance Taylor, +2 by Michael Pratt
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |