[net] route: add //go:build line to empty.s

6 views
Skip to first unread message

Tobias Klauser (Gerrit)

unread,
May 10, 2021, 5:14:50 AM5/10/21
to Ian Lance Taylor, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention is currently required from: Ian Lance Taylor.

Tobias Klauser would like Ian Lance Taylor to review this change.

View Change

route: add //go:build line to empty.s

Change-Id: Ife7553d7c9a91e498f87175c147b18c529c89d01
---
M route/empty.s
1 file changed, 1 insertion(+), 0 deletions(-)

diff --git a/route/empty.s b/route/empty.s
index bff0231..90ab4ca 100644
--- a/route/empty.s
+++ b/route/empty.s
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

+//go:build darwin && go1.12
// +build darwin,go1.12

// This exists solely so we can linkname in symbols from syscall.

To view, visit change 318309. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: net
Gerrit-Branch: master
Gerrit-Change-Id: Ife7553d7c9a91e498f87175c147b18c529c89d01
Gerrit-Change-Number: 318309
Gerrit-PatchSet: 1
Gerrit-Owner: Tobias Klauser <tobias....@gmail.com>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Tobias Klauser <tobias....@gmail.com>
Gerrit-Attention: Ian Lance Taylor <ia...@golang.org>
Gerrit-MessageType: newchange

Ian Lance Taylor (Gerrit)

unread,
May 10, 2021, 7:27:06 AM5/10/21
to Tobias Klauser, goph...@pubsubhelper.golang.org, Go Bot, golang-co...@googlegroups.com

Attention is currently required from: Tobias Klauser.

Patch set 1:Code-Review +2

View Change

    To view, visit change 318309. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: net
    Gerrit-Branch: master
    Gerrit-Change-Id: Ife7553d7c9a91e498f87175c147b18c529c89d01
    Gerrit-Change-Number: 318309
    Gerrit-PatchSet: 1
    Gerrit-Owner: Tobias Klauser <tobias....@gmail.com>
    Gerrit-Reviewer: Go Bot <go...@golang.org>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Reviewer: Tobias Klauser <tobias....@gmail.com>
    Gerrit-Attention: Tobias Klauser <tobias....@gmail.com>
    Gerrit-Comment-Date: Mon, 10 May 2021 11:27:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Tobias Klauser (Gerrit)

    unread,
    May 10, 2021, 8:01:57 AM5/10/21
    to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Ian Lance Taylor, Go Bot, golang-co...@googlegroups.com

    Tobias Klauser submitted this change.

    View Change

    Approvals: Ian Lance Taylor: Looks good to me, approved Tobias Klauser: Trusted; Run TryBots Go Bot: TryBots succeeded
    route: add //go:build line to empty.s

    Change-Id: Ife7553d7c9a91e498f87175c147b18c529c89d01
    Reviewed-on: https://go-review.googlesource.com/c/net/+/318309
    Trust: Tobias Klauser <tobias....@gmail.com>
    Run-TryBot: Tobias Klauser <tobias....@gmail.com>
    TryBot-Result: Go Bot <go...@golang.org>
    Reviewed-by: Ian Lance Taylor <ia...@golang.org>

    ---
    M route/empty.s
    1 file changed, 1 insertion(+), 0 deletions(-)

    diff --git a/route/empty.s b/route/empty.s
    index bff0231..90ab4ca 100644
    --- a/route/empty.s
    +++ b/route/empty.s
    @@ -2,6 +2,7 @@
    // Use of this source code is governed by a BSD-style
    // license that can be found in the LICENSE file.

    +//go:build darwin && go1.12
    // +build darwin,go1.12

    // This exists solely so we can linkname in symbols from syscall.

    To view, visit change 318309. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: net
    Gerrit-Branch: master
    Gerrit-Change-Id: Ife7553d7c9a91e498f87175c147b18c529c89d01
    Gerrit-Change-Number: 318309
    Gerrit-PatchSet: 2
    Gerrit-Owner: Tobias Klauser <tobias....@gmail.com>
    Gerrit-Reviewer: Go Bot <go...@golang.org>
    Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
    Gerrit-Reviewer: Tobias Klauser <tobias....@gmail.com>
    Gerrit-MessageType: merged
    Reply all
    Reply to author
    Forward
    0 new messages