[go] test/codegen: test negation on add/sub on riscv64

7 views
Skip to first unread message

Meng Zhuo (Gerrit)

unread,
Sep 15, 2025, 6:06:20 AMSep 15
to goph...@pubsubhelper.golang.org, Meng Zhuo, golang-co...@googlegroups.com

Meng Zhuo has uploaded the change for review

Commit message

test/codegen: test negation on add/sub on riscv64
Change-Id: Ic0eca86d3c93707ebd7c716e774ebda55af4f196

Change diff

diff --git a/test/codegen/arithmetic.go b/test/codegen/arithmetic.go
index 7055db3..b88da3a 100644
--- a/test/codegen/arithmetic.go
+++ b/test/codegen/arithmetic.go
@@ -176,20 +176,26 @@
 	// mips:"SUB",-"ADD"
 	// mips64:"SUBV",-"ADDV"
 	// loong64:"SUBV",-"ADDV"
+	// riscv64:"SUB",-"ADD"
 	r := (a + b) - (a + c)
 	// amd64:-"ADDQ"
+	// riscv64:-"ADD"
 	r1 := (a + b) - (c + a)
 	// amd64:-"ADDQ"
+	// riscv64:-"ADD"
 	r2 := (b + a) - (a + c)
 	// amd64:-"ADDQ"
+	// riscv64:-"ADD"
 	r3 := (b + a) - (c + a)
 	// amd64:-"SUBQ"
 	// arm64:-"SUB"
 	// mips:"ADD",-"SUB"
 	// mips64:"ADDV",-"SUBV"
 	// loong64:"ADDV",-"SUBV"
+	// riscv64:"ADD",-"SUB"
 	r4 := (a - c) + (c + b)
 	// amd64:-"SUBQ"
+	// riscv64:-"SUB"
 	r5 := (a - c) + (b + c)
 	return r, r1, r2, r3, r4, r5
 }

Change information

Files:
  • M test/codegen/arithmetic.go
Change size: XS
Delta: 1 file changed, 6 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ic0eca86d3c93707ebd7c716e774ebda55af4f196
Gerrit-Change-Number: 703755
Gerrit-PatchSet: 1
Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Meng Zhuo (Gerrit)

unread,
Sep 15, 2025, 6:06:41 AMSep 15
to Meng Zhuo, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Meng Zhuo voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ic0eca86d3c93707ebd7c716e774ebda55af4f196
Gerrit-Change-Number: 703755
Gerrit-PatchSet: 1
Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Comment-Date: Mon, 15 Sep 2025 10:06:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Joel Sing (Gerrit)

unread,
Oct 20, 2025, 1:25:31 AMOct 20
to Meng Zhuo, goph...@pubsubhelper.golang.org, Mark Ryan, Pengcheng Wang, Go LUCI, golang-co...@googlegroups.com
Attention needed from Mark Ryan, Meng Zhuo and Pengcheng Wang

Joel Sing added 2 comments

File test/codegen/arithmetic.go
Line 182, Patchset 1 (Latest): // riscv64:-"ADD"
Joel Sing . unresolved

Seems like this (and the next two) should be `"SUB",-"ADD"` (or just `-"ADD"` above).

Line 198, Patchset 1 (Latest): // riscv64:-"SUB"
Joel Sing . unresolved

Same here with `"ADD","-SUB"` (or just `-"SUB"` above).

Open in Gerrit

Related details

Attention is currently required from:
  • Mark Ryan
  • Meng Zhuo
  • Pengcheng Wang
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ic0eca86d3c93707ebd7c716e774ebda55af4f196
    Gerrit-Change-Number: 703755
    Gerrit-PatchSet: 1
    Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
    Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
    Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
    Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
    Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Attention: Mark Ryan <mark...@rivosinc.com>
    Gerrit-Comment-Date: Mon, 20 Oct 2025 05:25:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Meng Zhuo (Gerrit)

    unread,
    Nov 13, 2025, 3:14:47 AMNov 13
    to Meng Zhuo, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Mark Ryan, Meng Zhuo and Pengcheng Wang

    Meng Zhuo uploaded new patchset

    Meng Zhuo uploaded patch set #2 to this change.
    Following approvals got outdated and were removed:
    • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mark Ryan
    • Meng Zhuo
    • Pengcheng Wang
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Ic0eca86d3c93707ebd7c716e774ebda55af4f196
      Gerrit-Change-Number: 703755
      Gerrit-PatchSet: 2
      unsatisfied_requirement
      open
      diffy

      Meng Zhuo (Gerrit)

      unread,
      Nov 13, 2025, 3:15:33 AMNov 13
      to Meng Zhuo, goph...@pubsubhelper.golang.org, Joel Sing, Mark Ryan, Pengcheng Wang, Go LUCI, golang-co...@googlegroups.com
      Attention needed from Joel Sing, Mark Ryan and Pengcheng Wang

      Meng Zhuo voted and added 3 comments

      Votes added by Meng Zhuo

      Commit-Queue+1

      3 comments

      Patchset-level comments
      File-level comment, Patchset 2 (Latest):
      Meng Zhuo . resolved

      Thanks, all done

      File test/codegen/arithmetic.go
      Line 182, Patchset 1: // riscv64:-"ADD"
      Joel Sing . resolved

      Seems like this (and the next two) should be `"SUB",-"ADD"` (or just `-"ADD"` above).

      Meng Zhuo

      Done

      Line 198, Patchset 1: // riscv64:-"SUB"
      Joel Sing . resolved

      Same here with `"ADD","-SUB"` (or just `-"SUB"` above).

      Meng Zhuo

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Joel Sing
      • Mark Ryan
      • Pengcheng Wang
      Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: Ic0eca86d3c93707ebd7c716e774ebda55af4f196
        Gerrit-Change-Number: 703755
        Gerrit-PatchSet: 2
        Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
        Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Attention: Joel Sing <jo...@sing.id.au>
        Gerrit-Attention: Mark Ryan <mark...@rivosinc.com>
        Gerrit-Comment-Date: Thu, 13 Nov 2025 08:15:27 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Joel Sing <jo...@sing.id.au>
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Joel Sing (Gerrit)

        unread,
        Nov 13, 2025, 8:48:05 AMNov 13
        to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Mark Ryan, Pengcheng Wang, golang-co...@googlegroups.com
        Attention needed from Mark Ryan, Meng Zhuo and Pengcheng Wang

        Joel Sing voted and added 2 comments

        Votes added by Joel Sing

        Code-Review+2

        2 comments

        Commit Message
        Line 7, Patchset 2 (Latest):test/codegen: test negation on add/sub on riscv64
        Joel Sing . unresolved

        ```suggestion
        test/codegen: test negation with add/sub on riscv64
        ```

        File test/codegen/arithmetic.go
        Line 175, Patchset 2 (Latest): // riscv64:"SUB" -"ADD"
        Joel Sing . unresolved

        Still an extra SUB here - this should just be `-"ADD"` if we're matching what is done for amd64/arm64.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Mark Ryan
        • Meng Zhuo
        • Pengcheng Wang
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: Ic0eca86d3c93707ebd7c716e774ebda55af4f196
        Gerrit-Change-Number: 703755
        Gerrit-PatchSet: 2
        Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
        Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Attention: Mark Ryan <mark...@rivosinc.com>
        Gerrit-Comment-Date: Thu, 13 Nov 2025 13:47:57 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Meng Zhuo (Gerrit)

        unread,
        Nov 26, 2025, 9:02:29 PM (6 days ago) Nov 26
        to Meng Zhuo, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
        Attention needed from Mark Ryan, Meng Zhuo and Pengcheng Wang

        Meng Zhuo uploaded new patchset

        Meng Zhuo uploaded patch set #3 to this change.
        Following approvals got outdated and were removed:
        • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

        Related details

        Attention is currently required from:
        • Mark Ryan
        • Meng Zhuo
        • Pengcheng Wang
        Submit Requirements:
          • requirement satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement is not satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: newpatchset
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: Ic0eca86d3c93707ebd7c716e774ebda55af4f196
          Gerrit-Change-Number: 703755
          Gerrit-PatchSet: 3
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Meng Zhuo (Gerrit)

          unread,
          Nov 26, 2025, 9:02:51 PM (6 days ago) Nov 26
          to Meng Zhuo, goph...@pubsubhelper.golang.org, Joel Sing, Go LUCI, Mark Ryan, Pengcheng Wang, golang-co...@googlegroups.com
          Attention needed from Mark Ryan and Pengcheng Wang

          Meng Zhuo voted and added 3 comments

          Votes added by Meng Zhuo

          Commit-Queue+1

          3 comments

          Patchset-level comments
          File-level comment, Patchset 3 (Latest):
          Meng Zhuo . resolved

          All done, thanks

          Commit Message
          Line 7, Patchset 2:test/codegen: test negation on add/sub on riscv64
          Joel Sing . resolved

          ```suggestion
          test/codegen: test negation with add/sub on riscv64
          ```

          Meng Zhuo

          Done

          File test/codegen/arithmetic.go
          Line 175, Patchset 2: // riscv64:"SUB" -"ADD"
          Joel Sing . resolved

          Still an extra SUB here - this should just be `-"ADD"` if we're matching what is done for amd64/arm64.

          Meng Zhuo

          Done

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Mark Ryan
          • Pengcheng Wang
          Submit Requirements:
          • requirement satisfiedCode-Review
          • requirement satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement is not satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: Ic0eca86d3c93707ebd7c716e774ebda55af4f196
          Gerrit-Change-Number: 703755
          Gerrit-PatchSet: 3
          Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
          Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
          Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
          Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
          Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
          Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
          Gerrit-Attention: Mark Ryan <mark...@rivosinc.com>
          Gerrit-Comment-Date: Thu, 27 Nov 2025 02:02:45 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          Comment-In-Reply-To: Joel Sing <jo...@sing.id.au>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Meng Zhuo (Gerrit)

          unread,
          Nov 26, 2025, 9:04:12 PM (6 days ago) Nov 26
          to Meng Zhuo, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
          Attention needed from Mark Ryan, Meng Zhuo and Pengcheng Wang

          Meng Zhuo uploaded new patchset

          Meng Zhuo uploaded patch set #4 to this change.
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Mark Ryan
          • Meng Zhuo
          • Pengcheng Wang
          Submit Requirements:
          • requirement satisfiedCode-Review
          • requirement satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement is not satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: newpatchset
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: Ic0eca86d3c93707ebd7c716e774ebda55af4f196
          Gerrit-Change-Number: 703755
          Gerrit-PatchSet: 4
          Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
          Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
          Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
          Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
          Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
          Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Meng Zhuo (Gerrit)

          unread,
          Nov 26, 2025, 9:04:40 PM (6 days ago) Nov 26
          to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Joel Sing, Mark Ryan, Pengcheng Wang, golang-co...@googlegroups.com
          Attention needed from Mark Ryan and Pengcheng Wang

          Meng Zhuo voted Commit-Queue+1

          Commit-Queue+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Mark Ryan
          • Pengcheng Wang
          Submit Requirements:
          • requirement satisfiedCode-Review
          • requirement satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement is not satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: Ic0eca86d3c93707ebd7c716e774ebda55af4f196
          Gerrit-Change-Number: 703755
          Gerrit-PatchSet: 4
          Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
          Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
          Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
          Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
          Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
          Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
          Gerrit-Attention: Mark Ryan <mark...@rivosinc.com>
          Gerrit-Comment-Date: Thu, 27 Nov 2025 02:04:33 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Meng Zhuo (Gerrit)

          unread,
          Dec 2, 2025, 9:58:53 PM (6 hours ago) Dec 2
          to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Joel Sing, Mark Ryan, Pengcheng Wang, golang-co...@googlegroups.com
          Attention needed from Mark Ryan and Pengcheng Wang

          Meng Zhuo voted Commit-Queue+1

          Commit-Queue+1
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Mark Ryan
          • Pengcheng Wang
          Submit Requirements:
          • requirement satisfiedCode-Review
          • requirement satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement is not satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: Ic0eca86d3c93707ebd7c716e774ebda55af4f196
          Gerrit-Change-Number: 703755
          Gerrit-PatchSet: 5
          Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
          Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
          Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
          Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
          Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
          Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
          Gerrit-Attention: Mark Ryan <mark...@rivosinc.com>
          Gerrit-Comment-Date: Wed, 03 Dec 2025 02:58:46 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy
          Reply all
          Reply to author
          Forward
          0 new messages