[go] cmd/link: generate proper attributes for riscv profile

23 views
Skip to first unread message

Meng Zhuo (Gerrit)

unread,
Mar 19, 2025, 8:48:46 AM3/19/25
to goph...@pubsubhelper.golang.org, Meng Zhuo, golang-co...@googlegroups.com

Meng Zhuo has uploaded the change for review

Commit message

cmd/link: generate proper attributes for riscv profile

This CL adds `.riscv.attributes` to riscv64 link target
according to the profile setting which helps other
tools like gdb to identify vector/compress intrinsics
Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa

Change diff

diff --git a/src/cmd/link/internal/ld/elf.go b/src/cmd/link/internal/ld/elf.go
index 6ff1d94..55ed539 100644
--- a/src/cmd/link/internal/ld/elf.go
+++ b/src/cmd/link/internal/ld/elf.go
@@ -19,6 +19,7 @@
 	"path/filepath"
 	"runtime"
 	"slices"
+	"sort"
 	"strings"
 )
 
@@ -1442,6 +1443,9 @@
 		shstrtabAddstring(".MIPS.abiflags")
 		shstrtabAddstring(".gnu.attributes")
 	}
+	if ctxt.IsRISCV64() {
+		shstrtabAddstring(".riscv.attributes")
+	}
 
 	// generate .tbss section for dynamic internal linker or external
 	// linking, so that various binutils could correctly calculate
@@ -1500,6 +1504,9 @@
 			shstrtabAddstring(elfRelType + ".MIPS.abiflags")
 			shstrtabAddstring(elfRelType + ".gnu.attributes")
 		}
+		if ctxt.IsRISCV64() {
+			shstrtabAddstring(elfRelType + ".riscv.attributes")
+		}
 
 		// add a .note.GNU-stack section to mark the stack as non-executable
 		shstrtabAddstring(".note.GNU-stack")
@@ -1739,6 +1746,101 @@
 			gnuattributes.AddUint8(MIPS_FPABI_ANY)
 		}
 	}
+	if ctxt.IsRISCV64() {
+		attrs := ldr.CreateSymForUpdate(".riscv.attributes", 0)
+		attrs.SetType(sym.SELFROSECT)
+		attrs.SetReachable(true)
+		attrs.AddUint8('A')                      // version 'A'
+		secOff := attrs.AddUint32(ctxt.Arch, 0)  // for sub-section length
+		attrs.Addstring("riscv")                 // sub-section vendor name
+		subOff := attrs.AddUint8(1)              // Tag_file
+		subSize := attrs.AddUint32(ctxt.Arch, 0) // for sub-sub section size
+
+		attrs.AddUleb(4)  // Tag_RISCV_stack_align
+		attrs.AddUleb(16) // default to profile 16 bytes alignment
+
+		attrs.AddUleb(5) // Tag_RISCV_arch
+		attrs.Addstring(genRISCVAttributes())
+
+		attrs.AddUleb(6) // Tag_RISCV_unaligned_access
+		attrs.AddUleb(1) // enable unaligned access
+
+		end := uint32(attrs.Size())
+		attrs.SetUint32(ctxt.Arch, subSize, end-uint32(subOff))
+		attrs.SetUint32(ctxt.Arch, secOff, end-uint32(secOff))
+	}
+}
+
+func genRISCVAttributes() string {
+	// According to RISC-V Instruction Set Manual Volume I, Chapter 39. ISA Extension Naming Conventions:
+	// ISA name strings are case-insensitive, but we use lower letter for alignment to gcc and clang
+	const (
+		extOrder = "imafdqlcbkjtpvh" + "zs" // the rest letters for sorting
+		errmsg   = "invalid RISC-V ISA name: %s"
+	)
+	var extMap [256]int
+	for i, c := range extOrder {
+		extMap[c] = i + 1
+	}
+
+	extLess := func(a, b string, off int) bool {
+		ao := extMap[a[off]]
+		if ao == 0 {
+			Errorf(errmsg, a)
+		}
+
+		bo := extMap[b[off]]
+		if bo == 0 {
+			Errorf(errmsg, b)
+		}
+		return ao < bo
+	}
+
+	ns := []string{"i2", "m2", "a2", "f2", "d2", "c2", "zicclsm1"}
+	v := buildcfg.GORISCV64
+
+	if v == 20 {
+		ns = append(ns, "za128rs1")
+	}
+	if v >= 22 {
+		ns = append(ns, "b1", "zic64b1", "zihintpause1", "zba1", "zbb1",
+			"zbs1", "zicbom1", "zicbop1", "zicboz1", "zfhmin1", "zkt1")
+	}
+	if v >= 23 {
+		ns = append(ns, "v1", "zvfhmin1", "zvbb1", "zvkt1", "zihintntl1", "zicond1",
+			"zimop1", "zcmop1", "zcb1", "zfa1", "zawrs1")
+	}
+
+	sort.Slice(ns, func(i, j int) bool {
+		si, sj := ns[i], ns[j]
+		// The ABI spec require: ordered first by category, then alphabetically
+		// within a category.
+		if si[0] != sj[0] {
+			return extLess(si, sj, 0)
+		}
+
+		if si[1] != sj[1] { // Z* category
+			return extLess(si, sj, 1)
+		}
+
+		if len(si) < 4 {
+			Errorf(errmsg, si)
+		}
+
+		if len(sj) < 4 {
+			Errorf(errmsg, sj)
+		}
+
+		ml := min(len(si)-1, len(sj)-1) // compare without major version
+		for k := 2; k < ml; k++ {
+			if si[k] != sj[k] {
+				return si[k] < sj[k]
+			}
+		}
+		return si < sj // prefix are same
+	})
+
+	return fmt.Sprintf("rv64%s", strings.Join(ns, "_"))
 }
 
 // Do not write DT_NULL.  elfdynhash will finish it.
@@ -2232,6 +2334,16 @@
 		shsym(sh, ldr, ldr.Lookup(".gnu.attributes", 0))
 	}
 
+	if ctxt.IsRISCV64() {
+		sh = elfshname(".riscv.attributes")
+		sh.Type = uint32(elf.SHT_RISCV_ATTRIBUTES)
+		sh.Flags = 0
+		sh.Addralign = 1
+
+		// RISC-V ABIs Specification deprecated PT_RISCV_ATTRIBUTES
+		shsym(sh, ctxt.loader, ctxt.loader.Lookup(".riscv.attributes", 0))
+	}
+
 	// put these sections early in the list
 	if !*FlagS {
 		elfshname(".symtab")

Change information

Files:
  • M src/cmd/link/internal/ld/elf.go
Change size: M
Delta: 1 file changed, 112 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
Gerrit-Change-Number: 659175
Gerrit-PatchSet: 1
Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Meng Zhuo (Gerrit)

unread,
Mar 19, 2025, 8:50:55 AM3/19/25
to Meng Zhuo, goph...@pubsubhelper.golang.org, Joel Sing, Mark Ryan, Pengcheng Wang, golang-co...@googlegroups.com
Attention needed from Joel Sing, Mark Ryan and Pengcheng Wang

Meng Zhuo voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joel Sing
  • Mark Ryan
  • Pengcheng Wang
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
Gerrit-Change-Number: 659175
Gerrit-PatchSet: 1
Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
Gerrit-Attention: Mark Ryan <mark...@rivosinc.com>
Gerrit-Attention: Joel Sing <jo...@sing.id.au>
Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
Gerrit-Comment-Date: Wed, 19 Mar 2025 12:50:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Pengcheng Wang (Gerrit)

unread,
Mar 20, 2025, 5:12:06 AM3/20/25
to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Joel Sing, Mark Ryan, golang-co...@googlegroups.com
Attention needed from Joel Sing, Mark Ryan and Meng Zhuo

Pengcheng Wang added 3 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Pengcheng Wang . resolved

Great! I am suprised that we didn't add this attribute before! Besides debugging, this attribute is useful when using objdump.
I don't know if we can test it in Golang source tree. We should be able to read this attribute via `readelf -A` and compare the output.

File src/cmd/link/internal/ld/elf.go
Line 1768, Patchset 1 (Latest): end := uint32(attrs.Size())
Pengcheng Wang . unresolved

And also add `ATOMIC_ABI`?

Line 1774, Patchset 1 (Latest):func genRISCVAttributes() string {
Pengcheng Wang . unresolved

The profile won't change after ratification, here I think we can just query a map from profile to arch string. :-)

Open in Gerrit

Related details

Attention is currently required from:
  • Joel Sing
  • Mark Ryan
  • Meng Zhuo
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
    Gerrit-Change-Number: 659175
    Gerrit-PatchSet: 1
    Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
    Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
    Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
    Gerrit-Attention: Mark Ryan <mark...@rivosinc.com>
    Gerrit-Attention: Joel Sing <jo...@sing.id.au>
    Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Comment-Date: Thu, 20 Mar 2025 09:11:56 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Meng Zhuo (Gerrit)

    unread,
    Mar 25, 2025, 5:21:38 AM3/25/25
    to Meng Zhuo, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Joel Sing, Mark Ryan and Meng Zhuo

    Meng Zhuo uploaded new patchset

    Meng Zhuo uploaded patch set #2 to this change.
    Following approvals got outdated and were removed:
    • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Joel Sing
    • Mark Ryan
    • Meng Zhuo
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
      Gerrit-Change-Number: 659175
      Gerrit-PatchSet: 2
      unsatisfied_requirement
      open
      diffy

      Mark Ryan (Gerrit)

      unread,
      May 21, 2025, 7:39:51 AM5/21/25
      to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Joel Sing, Pengcheng Wang, golang-co...@googlegroups.com
      Attention needed from Joel Sing and Meng Zhuo

      Mark Ryan added 4 comments

      Patchset-level comments
      File-level comment, Patchset 2 (Latest):
      Mark Ryan . resolved

      I had a play with this. With the patch applied I was able to get binutils objdump to disassemble a Go program containing vector instructions.

      File src/cmd/link/internal/ld/elf.go
      Line 1800, Patchset 2 (Latest): ns := []string{"i2", "m2", "a2", "f2", "d2", "c2", "zicclsm1"}
      Mark Ryan . unresolved

      Should this be "i2p1", "a2p1","f2p2","d2p2" as we're working from version 20240411 of the ISA spec, or are we assuming outdated versions of these extensions?

      Line 1801, Patchset 2 (Latest): v := buildcfg.GORISCV64
      Mark Ryan . unresolved

      We should also add zicsr2 as the runtime calls RDTIME.

      Line 1806, Patchset 2 (Latest): if v >= 22 {
      Mark Ryan . unresolved

      Go binaries compiled with GORISCV64=RVA20U64 can still contain Vector and Zbb (used by OnesCount64) instructions. A runtime check is required before the instructions can be used but the instructions are still in the binary and may be executed. How should we handle this?

      Perhaps we could always add 'v1' and 'zbb1' regardless of what profile is chosen and remember to update the base value of ns next time we use an new extension in this way, e.g,, when we add vector crypto support.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Joel Sing
      • Meng Zhuo
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
      Gerrit-Change-Number: 659175
      Gerrit-PatchSet: 2
      Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
      Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
      Gerrit-Attention: Joel Sing <jo...@sing.id.au>
      Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Comment-Date: Wed, 21 May 2025 11:39:42 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      unsatisfied_requirement
      open
      diffy

      Pengcheng Wang (Gerrit)

      unread,
      May 21, 2025, 10:59:15 AM5/21/25
      to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Joel Sing, Mark Ryan, golang-co...@googlegroups.com
      Attention needed from Joel Sing and Meng Zhuo

      Pengcheng Wang added 1 comment

      File src/cmd/link/internal/ld/elf.go
      Mark Ryan . unresolved

      Go binaries compiled with GORISCV64=RVA20U64 can still contain Vector and Zbb (used by OnesCount64) instructions. A runtime check is required before the instructions can be used but the instructions are still in the binary and may be executed. How should we handle this?

      Perhaps we could always add 'v1' and 'zbb1' regardless of what profile is chosen and remember to update the base value of ns next time we use an new extension in this way, e.g,, when we add vector crypto support.

      Pengcheng Wang

      It is the same for ELFs with ifuncs when compiling C/C++. The ELF attribute contains only the baseline.

      Gerrit-Comment-Date: Wed, 21 May 2025 14:59:08 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Mark Ryan <mark...@rivosinc.com>
      unsatisfied_requirement
      open
      diffy

      Mark Ryan (Gerrit)

      unread,
      May 21, 2025, 11:14:19 AM5/21/25
      to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Joel Sing, Pengcheng Wang, golang-co...@googlegroups.com
      Attention needed from Joel Sing, Meng Zhuo and Pengcheng Wang

      Mark Ryan added 1 comment

      File src/cmd/link/internal/ld/elf.go
      Mark Ryan . resolved

      Go binaries compiled with GORISCV64=RVA20U64 can still contain Vector and Zbb (used by OnesCount64) instructions. A runtime check is required before the instructions can be used but the instructions are still in the binary and may be executed. How should we handle this?

      Perhaps we could always add 'v1' and 'zbb1' regardless of what profile is chosen and remember to update the base value of ns next time we use an new extension in this way, e.g,, when we add vector crypto support.

      Pengcheng Wang

      It is the same for ELFs with ifuncs when compiling C/C++. The ELF attribute contains only the baseline.

      Mark Ryan

      Acknowledged

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Joel Sing
      • Meng Zhuo
      • Pengcheng Wang
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
      Gerrit-Change-Number: 659175
      Gerrit-PatchSet: 2
      Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
      Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
      Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
      Gerrit-Attention: Joel Sing <jo...@sing.id.au>
      Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
      Gerrit-Comment-Date: Wed, 21 May 2025 15:14:11 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Mark Ryan <mark...@rivosinc.com>
      Comment-In-Reply-To: Pengcheng Wang <wangpeng...@bytedance.com>
      unsatisfied_requirement
      open
      diffy

      Meng Zhuo (Gerrit)

      unread,
      May 26, 2025, 4:56:16 AM5/26/25
      to Meng Zhuo, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Joel Sing, Meng Zhuo and Pengcheng Wang

      Meng Zhuo uploaded new patchset

      Meng Zhuo uploaded patch set #3 to this change.
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Joel Sing
      • Meng Zhuo
      • Pengcheng Wang
      Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: newpatchset
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
      Gerrit-Change-Number: 659175
      Gerrit-PatchSet: 3
      unsatisfied_requirement
      open
      diffy

      Meng Zhuo (Gerrit)

      unread,
      May 26, 2025, 4:57:06 AM5/26/25
      to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Joel Sing, Mark Ryan, Pengcheng Wang, golang-co...@googlegroups.com
      Attention needed from Joel Sing, Mark Ryan and Pengcheng Wang

      Meng Zhuo voted and added 5 comments

      Votes added by Meng Zhuo

      Commit-Queue+1

      5 comments

      Patchset-level comments
      File-level comment, Patchset 3 (Latest):
      Meng Zhuo . resolved

      Thanks!

      File src/cmd/link/internal/ld/elf.go
      Line 1768, Patchset 1: end := uint32(attrs.Size())
      Pengcheng Wang . resolved

      And also add `ATOMIC_ABI`?

      Meng Zhuo

      Done

      Line 1774, Patchset 1:func genRISCVAttributes() string {
      Pengcheng Wang . resolved

      The profile won't change after ratification, here I think we can just query a map from profile to arch string. :-)

      Meng Zhuo

      The problem is optional extensions, (i.e. `v` for rva22u64)
      I think we easily can add vector into attribution after runtime do compiled vector instructions.

      Line 1800, Patchset 2: ns := []string{"i2", "m2", "a2", "f2", "d2", "c2", "zicclsm1"}
      Mark Ryan . resolved

      Should this be "i2p1", "a2p1","f2p2","d2p2" as we're working from version 20240411 of the ISA spec, or are we assuming outdated versions of these extensions?

      Meng Zhuo

      Done, Thanks

      Line 1801, Patchset 2: v := buildcfg.GORISCV64
      Mark Ryan . resolved

      We should also add zicsr2 as the runtime calls RDTIME.

      Meng Zhuo

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Joel Sing
      • Mark Ryan
      • Pengcheng Wang
      Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
        Gerrit-Change-Number: 659175
        Gerrit-PatchSet: 3
        Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
        Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Attention: Mark Ryan <mark...@rivosinc.com>
        Gerrit-Attention: Joel Sing <jo...@sing.id.au>
        Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Comment-Date: Mon, 26 May 2025 08:56:59 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Meng Zhuo (Gerrit)

        unread,
        May 26, 2025, 10:10:44 AM5/26/25
        to Meng Zhuo, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
        Attention needed from Joel Sing, Mark Ryan and Pengcheng Wang

        Meng Zhuo uploaded new patchset

        Meng Zhuo uploaded patch set #4 to this change.
        Following approvals got outdated and were removed:
        • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Joel Sing
        • Mark Ryan
        • Pengcheng Wang
        Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: newpatchset
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
        Gerrit-Change-Number: 659175
        Gerrit-PatchSet: 4
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Meng Zhuo (Gerrit)

        unread,
        May 26, 2025, 10:12:42 AM5/26/25
        to Meng Zhuo, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
        Attention needed from Joel Sing, Mark Ryan and Pengcheng Wang

        Meng Zhuo uploaded new patchset

        Meng Zhuo uploaded patch set #5 to this change.
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Joel Sing
        • Mark Ryan
        • Pengcheng Wang
        Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: newpatchset
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
        Gerrit-Change-Number: 659175
        Gerrit-PatchSet: 5
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Meng Zhuo (Gerrit)

        unread,
        May 26, 2025, 10:12:55 AM5/26/25
        to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Joel Sing, Mark Ryan, Pengcheng Wang, golang-co...@googlegroups.com
        Attention needed from Joel Sing, Mark Ryan and Pengcheng Wang

        Meng Zhuo voted Commit-Queue+1

        Commit-Queue+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Joel Sing
        • Mark Ryan
        • Pengcheng Wang
        Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
        Gerrit-Change-Number: 659175
        Gerrit-PatchSet: 5
        Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
        Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Attention: Mark Ryan <mark...@rivosinc.com>
        Gerrit-Attention: Joel Sing <jo...@sing.id.au>
        Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Comment-Date: Mon, 26 May 2025 14:12:48 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Meng Zhuo (Gerrit)

        unread,
        Aug 18, 2025, 3:16:26 AM8/18/25
        to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Joel Sing, Mark Ryan, Pengcheng Wang, golang-co...@googlegroups.com
        Attention needed from Joel Sing, Mark Ryan and Pengcheng Wang

        Meng Zhuo voted Commit-Queue+1

        Commit-Queue+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Joel Sing
        • Mark Ryan
        • Pengcheng Wang
        Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
        Gerrit-Change-Number: 659175
        Gerrit-PatchSet: 6
        Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
        Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Attention: Mark Ryan <mark...@rivosinc.com>
        Gerrit-Attention: Joel Sing <jo...@sing.id.au>
        Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Comment-Date: Mon, 18 Aug 2025 07:16:17 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Meng Zhuo (Gerrit)

        unread,
        Sep 16, 2025, 9:55:08 AM9/16/25
        to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Joel Sing, Mark Ryan, Pengcheng Wang, golang-co...@googlegroups.com
        Attention needed from Joel Sing, Mark Ryan and Pengcheng Wang

        Meng Zhuo voted Commit-Queue+1

        Commit-Queue+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Joel Sing
        • Mark Ryan
        • Pengcheng Wang
        Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
        Gerrit-Change-Number: 659175
        Gerrit-PatchSet: 7
        Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
        Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Attention: Mark Ryan <mark...@rivosinc.com>
        Gerrit-Attention: Joel Sing <jo...@sing.id.au>
        Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Comment-Date: Tue, 16 Sep 2025 13:54:59 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Mark Ryan (Gerrit)

        unread,
        Oct 14, 2025, 4:57:38 AM10/14/25
        to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Joel Sing, Pengcheng Wang, golang-co...@googlegroups.com
        Attention needed from Joel Sing, Meng Zhuo and Pengcheng Wang

        Mark Ryan voted and added 1 comment

        Votes added by Mark Ryan

        Code-Review+1

        1 comment

        Patchset-level comments
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Joel Sing
        • Meng Zhuo
        • Pengcheng Wang
        Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
        Gerrit-Change-Number: 659175
        Gerrit-PatchSet: 8
        Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
        Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Attention: Joel Sing <jo...@sing.id.au>
        Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Comment-Date: Tue, 14 Oct 2025 08:57:27 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Meng Zhuo (Gerrit)

        unread,
        Oct 15, 2025, 11:53:53 PM10/15/25
        to Meng Zhuo, goph...@pubsubhelper.golang.org, Mark Ryan, Go LUCI, Joel Sing, Pengcheng Wang, golang-co...@googlegroups.com
        Attention needed from Joel Sing and Pengcheng Wang

        Meng Zhuo voted Commit-Queue+1

        Commit-Queue+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Joel Sing
        • Pengcheng Wang
        Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
        Gerrit-Change-Number: 659175
        Gerrit-PatchSet: 9
        Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
        Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
        Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
        Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
        Gerrit-Attention: Joel Sing <jo...@sing.id.au>
        Gerrit-Comment-Date: Thu, 16 Oct 2025 03:53:46 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Meng Zhuo (Gerrit)

        unread,
        Oct 16, 2025, 12:12:59 AM10/16/25
        to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Mark Ryan, Joel Sing, Pengcheng Wang, golang-co...@googlegroups.com
        Attention needed from Joel Sing and Pengcheng Wang

        Meng Zhuo added 1 comment

        Patchset-level comments
        File-level comment, Patchset 9 (Latest):
        Meng Zhuo . resolved

        I'm confused by luci's settings that go1.25 using go1.22 to build. as gotip-riscv64 runs fine, I think it's OK to by pass. @jo...@sing.id.au @mark...@rivosinc.com

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Joel Sing
        • Pengcheng Wang
        Submit Requirements:
          • requirement is not satisfiedCode-Review
          • requirement satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
          Gerrit-Change-Number: 659175
          Gerrit-PatchSet: 9
          Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
          Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
          Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
          Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
          Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
          Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
          Gerrit-Attention: Joel Sing <jo...@sing.id.au>
          Gerrit-Comment-Date: Thu, 16 Oct 2025 04:12:52 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          unsatisfied_requirement
          satisfied_requirement
          open
          diffy

          Meng Zhuo (Gerrit)

          unread,
          Oct 28, 2025, 9:03:31 PM10/28/25
          to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Mark Ryan, Joel Sing, Pengcheng Wang, golang-co...@googlegroups.com
          Attention needed from Joel Sing and Pengcheng Wang

          Meng Zhuo voted and added 1 comment

          Votes added by Meng Zhuo

          TryBot-Bypass+1

          1 comment

          Patchset-level comments
          Meng Zhuo . resolved

          According to https://github.com/golang/go/issues/76091, the tip code should not run with go1.25 , we can bypass the 1.25 failures.

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Joel Sing
          • Pengcheng Wang
          Submit Requirements:
          • requirement is not satisfiedCode-Review
          • requirement satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          • requirement satisfiedTryBots-Pass
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: go
          Gerrit-Branch: master
          Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
          Gerrit-Change-Number: 659175
          Gerrit-PatchSet: 9
          Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
          Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
          Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
          Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
          Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
          Gerrit-CC: Michael Knyszek <mkny...@google.com>
          Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
          Gerrit-Attention: Joel Sing <jo...@sing.id.au>
          Gerrit-Comment-Date: Wed, 29 Oct 2025 01:03:22 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          unsatisfied_requirement
          satisfied_requirement
          open
          diffy

          Meng Zhuo (Gerrit)

          unread,
          Dec 12, 2025, 4:55:32 AM12/12/25
          to Meng Zhuo, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
          Attention needed from Joel Sing, Meng Zhuo and Pengcheng Wang

          Meng Zhuo uploaded new patchset

          Meng Zhuo uploaded patch set #10 to this change.
          Following approvals got outdated and were removed:
          • TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI, TryBot-Bypass+1 by Meng Zhuo
          Open in Gerrit

          Related details

          Attention is currently required from:
          • Joel Sing
          • Meng Zhuo
          • Pengcheng Wang
          Submit Requirements:
            • requirement is not satisfiedCode-Review
            • requirement satisfiedNo-Unresolved-Comments
            • requirement is not satisfiedReview-Enforcement
            • requirement is not satisfiedTryBots-Pass
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: newpatchset
            Gerrit-Project: go
            Gerrit-Branch: master
            Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
            Gerrit-Change-Number: 659175
            Gerrit-PatchSet: 10
            Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
            Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
            Gerrit-Reviewer: Mark Ryan <mark...@rivosinc.com>
            Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
            Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
            Gerrit-CC: Michael Knyszek <mkny...@google.com>
            Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
            Gerrit-Attention: Joel Sing <jo...@sing.id.au>
            Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
            unsatisfied_requirement
            satisfied_requirement
            open
            diffy

            Meng Zhuo (Gerrit)

            unread,
            Feb 23, 2026, 11:27:57 PMFeb 23
            to Meng Zhuo, goph...@pubsubhelper.golang.org, Go LUCI, Mark Ryan, Joel Sing, Pengcheng Wang, golang-co...@googlegroups.com
            Attention needed from Joel Sing and Pengcheng Wang

            Meng Zhuo voted Commit-Queue+1

            Commit-Queue+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Joel Sing
            • Pengcheng Wang
            Submit Requirements:
            • requirement is not satisfiedCode-Review
            • requirement satisfiedNo-Unresolved-Comments
            • requirement is not satisfiedReview-Enforcement
            • requirement is not satisfiedTryBots-Pass
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: go
            Gerrit-Branch: master
            Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
            Gerrit-Change-Number: 659175
            Gerrit-PatchSet: 11
            Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
            Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
            Gerrit-Reviewer: Mark Ryan <mark...@meta.com>
            Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
            Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
            Gerrit-CC: Michael Knyszek <mkny...@google.com>
            Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
            Gerrit-Attention: Joel Sing <jo...@sing.id.au>
            Gerrit-Comment-Date: Tue, 24 Feb 2026 04:27:50 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            unsatisfied_requirement
            satisfied_requirement
            open
            diffy

            Meng Zhuo (Gerrit)

            unread,
            Aug 6, 2026, 4:20:38 AM (4 days ago) Aug 6
            to Meng Zhuo, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Mark Ryan, Joel Sing, Pengcheng Wang, golang-co...@googlegroups.com
            Attention needed from Joel Sing and Pengcheng Wang

            Meng Zhuo added 1 comment

            Patchset-level comments
            File-level comment, Patchset 11 (Latest):
            Meng Zhuo . resolved

            Hi, @jo...@sing.id.au Could you take a look? Thanks

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Joel Sing
            • Pengcheng Wang
            Submit Requirements:
              • requirement is not satisfiedCode-Review
              • requirement satisfiedNo-Unresolved-Comments
              • requirement is not satisfiedReview-Enforcement
              • requirement satisfiedTryBots-Pass
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: go
              Gerrit-Branch: master
              Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
              Gerrit-Change-Number: 659175
              Gerrit-PatchSet: 11
              Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
              Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
              Gerrit-Reviewer: Mark Ryan <mark...@meta.com>
              Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
              Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
              Gerrit-CC: Michael Knyszek <mkny...@google.com>
              Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
              Gerrit-Attention: Joel Sing <jo...@sing.id.au>
              Gerrit-Comment-Date: Thu, 06 Aug 2026 08:20:32 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: No
              unsatisfied_requirement
              satisfied_requirement
              open
              diffy

              Julian Zhu (Gerrit)

              unread,
              Aug 8, 2026, 3:47:38 AM (2 days ago) Aug 8
              to Meng Zhuo, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Mark Ryan, Joel Sing, Pengcheng Wang, golang-co...@googlegroups.com
              Attention needed from Joel Sing, Meng Zhuo and Pengcheng Wang

              Julian Zhu added 2 comments

              File src/cmd/link/internal/ld/elf.go
              Line 1669, Patchset 11 (Latest): // TODO(mzh): only gcc 14 supports atomic_abi and atomic_abi,
              Julian Zhu . unresolved

              duplicate?

              Line 1707, Patchset 11 (Latest): ns := []string{"i2p1", "m2", "a2p1", "f2p2", "d2p2", "c2", "zicsr2", "zicclsm1"}
              Julian Zhu . unresolved
              ```suggestion
              	ns := []string{"i2p1", "m2p0", "a2p1", "f2p2", "d2p2", "c2p0", "zicsr2p0", "zicclsm1"}
              ```
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Joel Sing
              • Meng Zhuo
              • Pengcheng Wang
              Submit Requirements:
                • requirement is not satisfiedCode-Review
                • requirement is not satisfiedNo-Unresolved-Comments
                • requirement is not satisfiedReview-Enforcement
                • requirement satisfiedTryBots-Pass
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: go
                Gerrit-Branch: master
                Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
                Gerrit-Change-Number: 659175
                Gerrit-PatchSet: 11
                Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
                Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
                Gerrit-Reviewer: Mark Ryan <mark...@meta.com>
                Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
                Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
                Gerrit-CC: Julian Zhu <jz53...@gmail.com>
                Gerrit-CC: Michael Knyszek <mkny...@google.com>
                Gerrit-Attention: Pengcheng Wang <wangpeng...@bytedance.com>
                Gerrit-Attention: Joel Sing <jo...@sing.id.au>
                Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
                Gerrit-Comment-Date: Sat, 08 Aug 2026 07:47:33 +0000
                Gerrit-HasComments: Yes
                Gerrit-Has-Labels: No
                unsatisfied_requirement
                satisfied_requirement
                open
                diffy

                Meng Zhuo (Gerrit)

                unread,
                3:05 AM (3 hours ago) 3:05 AM
                to Meng Zhuo, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
                Attention needed from Joel Sing, Meng Zhuo and Pengcheng Wang

                Meng Zhuo uploaded new patchset

                Meng Zhuo uploaded patch set #12 to this change.
                Following approvals got outdated and were removed:

                Related details

                Attention is currently required from:
                • Joel Sing
                • Meng Zhuo
                • Pengcheng Wang
                Submit Requirements:
                  • requirement is not satisfiedCode-Review
                  • requirement is not satisfiedNo-Unresolved-Comments
                  • requirement is not satisfiedReview-Enforcement
                  • requirement is not satisfiedTryBots-Pass
                  Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                  Gerrit-MessageType: newpatchset
                  Gerrit-Project: go
                  Gerrit-Branch: master
                  Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
                  Gerrit-Change-Number: 659175
                  Gerrit-PatchSet: 12
                  unsatisfied_requirement
                  open
                  diffy

                  Meng Zhuo (Gerrit)

                  unread,
                  3:05 AM (3 hours ago) 3:05 AM
                  to Meng Zhuo, goph...@pubsubhelper.golang.org, Julian Zhu, golang...@luci-project-accounts.iam.gserviceaccount.com, Mark Ryan, Joel Sing, Pengcheng Wang, golang-co...@googlegroups.com
                  Attention needed from Julian Zhu

                  Meng Zhuo voted and added 3 comments

                  Votes added by Meng Zhuo

                  Commit-Queue+1

                  3 comments

                  Patchset-level comments
                  File-level comment, Patchset 12 (Latest):
                  Meng Zhuo . resolved

                  Done, Thanks

                  File src/cmd/link/internal/ld/elf.go
                  Line 1669, Patchset 11: // TODO(mzh): only gcc 14 supports atomic_abi and atomic_abi,
                  Julian Zhu . resolved

                  duplicate?

                  Meng Zhuo

                  Done

                  Line 1707, Patchset 11: ns := []string{"i2p1", "m2", "a2p1", "f2p2", "d2p2", "c2", "zicsr2", "zicclsm1"}
                  Julian Zhu . resolved
                  ```suggestion
                  	ns := []string{"i2p1", "m2p0", "a2p1", "f2p2", "d2p2", "c2p0", "zicsr2p0", "zicclsm1"}
                  ```
                  Meng Zhuo

                  Done

                  Open in Gerrit

                  Related details

                  Attention is currently required from:
                  • Julian Zhu
                  Submit Requirements:
                    • requirement is not satisfiedCode-Review
                    • requirement satisfiedNo-Unresolved-Comments
                    • requirement is not satisfiedReview-Enforcement
                    • requirement is not satisfiedTryBots-Pass
                    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                    Gerrit-MessageType: comment
                    Gerrit-Project: go
                    Gerrit-Branch: master
                    Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
                    Gerrit-Change-Number: 659175
                    Gerrit-PatchSet: 12
                    Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
                    Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
                    Gerrit-Reviewer: Mark Ryan <mark...@meta.com>
                    Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
                    Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
                    Gerrit-CC: Julian Zhu <jz53...@gmail.com>
                    Gerrit-CC: Michael Knyszek <mkny...@google.com>
                    Gerrit-Attention: Julian Zhu <jz53...@gmail.com>
                    Gerrit-Comment-Date: Mon, 10 Aug 2026 07:05:21 +0000
                    Gerrit-HasComments: Yes
                    Gerrit-Has-Labels: Yes
                    Comment-In-Reply-To: Julian Zhu <jz53...@gmail.com>
                    unsatisfied_requirement
                    satisfied_requirement
                    open
                    diffy

                    Meng Zhuo (Gerrit)

                    unread,
                    4:15 AM (2 hours ago) 4:15 AM
                    to Meng Zhuo, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
                    Attention needed from Julian Zhu and Meng Zhuo

                    Meng Zhuo uploaded new patchset

                    Meng Zhuo uploaded patch set #13 to this change.
                    Following approvals got outdated and were removed:
                    Open in Gerrit

                    Related details

                    Attention is currently required from:
                    • Julian Zhu
                    • Meng Zhuo
                    Submit Requirements:
                    • requirement is not satisfiedCode-Review
                    • requirement satisfiedNo-Unresolved-Comments
                    • requirement is not satisfiedReview-Enforcement
                    • requirement is not satisfiedTryBots-Pass
                    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                    Gerrit-MessageType: newpatchset
                    Gerrit-Project: go
                    Gerrit-Branch: master
                    Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
                    Gerrit-Change-Number: 659175
                    Gerrit-PatchSet: 13
                    Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
                    Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
                    Gerrit-Reviewer: Mark Ryan <mark...@meta.com>
                    Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
                    Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
                    Gerrit-CC: Julian Zhu <jz53...@gmail.com>
                    Gerrit-CC: Michael Knyszek <mkny...@google.com>
                    Gerrit-Attention: Julian Zhu <jz53...@gmail.com>
                    Gerrit-Attention: Meng Zhuo <mengzh...@gmail.com>
                    unsatisfied_requirement
                    satisfied_requirement
                    open
                    diffy

                    Meng Zhuo (Gerrit)

                    unread,
                    4:15 AM (2 hours ago) 4:15 AM
                    to Meng Zhuo, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Julian Zhu, Mark Ryan, Joel Sing, Pengcheng Wang, golang-co...@googlegroups.com
                    Attention needed from Julian Zhu

                    Meng Zhuo voted Commit-Queue+1

                    Commit-Queue+1
                    Open in Gerrit

                    Related details

                    Attention is currently required from:
                    • Julian Zhu
                    Submit Requirements:
                    • requirement is not satisfiedCode-Review
                    • requirement satisfiedNo-Unresolved-Comments
                    • requirement is not satisfiedReview-Enforcement
                    • requirement is not satisfiedTryBots-Pass
                    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                    Gerrit-MessageType: comment
                    Gerrit-Project: go
                    Gerrit-Branch: master
                    Gerrit-Change-Id: I2a47c7b139f6650504ae154a9dbac2d0be2a45fa
                    Gerrit-Change-Number: 659175
                    Gerrit-PatchSet: 13
                    Gerrit-Owner: Meng Zhuo <mengzh...@gmail.com>
                    Gerrit-Reviewer: Joel Sing <jo...@sing.id.au>
                    Gerrit-Reviewer: Mark Ryan <mark...@meta.com>
                    Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
                    Gerrit-Reviewer: Pengcheng Wang <wangpeng...@bytedance.com>
                    Gerrit-CC: Julian Zhu <jz53...@gmail.com>
                    Gerrit-CC: Michael Knyszek <mkny...@google.com>
                    Gerrit-Attention: Julian Zhu <jz53...@gmail.com>
                    Gerrit-Comment-Date: Mon, 10 Aug 2026 08:15:53 +0000
                    Gerrit-HasComments: No
                    Gerrit-Has-Labels: Yes
                    unsatisfied_requirement
                    satisfied_requirement
                    open
                    diffy
                    Reply all
                    Reply to author
                    Forward
                    0 new messages