[sys] windows: document safe usage of TrusteeValue

1 view
Skip to first unread message

Damien Neil (Gerrit)

unread,
Jun 9, 2026, 7:04:14 PM (10 hours ago) Jun 9
to goph...@pubsubhelper.golang.org, Quim Muntal, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Quim Muntal

Damien Neil added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Damien Neil . unresolved

Since (as I understand it) our policy is that Windows maintainers can add new API to x/sys/windows without going through proposal review, I think it's reasonable to say that we can deprecate an unsafe API without a proposal as well.

Open in Gerrit

Related details

Attention is currently required from:
  • Quim Muntal
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sys
Gerrit-Branch: master
Gerrit-Change-Id: Ie28884856298cd60693c903843be6aa06a6a6964
Gerrit-Change-Number: 789000
Gerrit-PatchSet: 1
Gerrit-Owner: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Quim Muntal <quimm...@gmail.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 23:04:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Quim Muntal (Gerrit)

unread,
4:29 AM (1 hour ago) 4:29 AM
to Damien Neil, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Damien Neil

Quim Muntal voted and added 1 comment

Votes added by Quim Muntal

Code-Review+2

1 comment

Patchset-level comments
Quim Muntal . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Damien Neil
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: sys
Gerrit-Branch: master
Gerrit-Change-Id: Ie28884856298cd60693c903843be6aa06a6a6964
Gerrit-Change-Number: 789000
Gerrit-PatchSet: 1
Gerrit-Owner: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-Attention: Damien Neil <dn...@google.com>
Gerrit-Comment-Date: Wed, 10 Jun 2026 08:29:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages