[tools] gopls/internal/licenses: use //go:embed rather than a hand-embedded string
0 views
Skip to first unread message
Damien Neil (Gerrit)
Jun 30, 2026, 6:23:29 PM (6 hours ago) Jun 30
to goph...@pubsubhelper.golang.org, Alan Donovan, golang-co...@googlegroups.com
Attention needed from Alan Donovan
Damien Neil voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Alan Donovan
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alan Donovan (Gerrit)
Jun 30, 2026, 6:27:31 PM (6 hours ago) Jun 30
to Damien Neil, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Damien Neil
Alan Donovan voted and added 2 comments![]( "Open in Gerrit")
Votes added by Alan Donovan
| Auto-Submit | +1 |
| Code-Review | +2 |
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File gopls/internal/licenses/gen-licenses.sh
Line 21, Patchset 1 (Parent):
const Text = \`
END
Alan Donovan . resolved
Yeah, even before //go:embed, this should have been a small Go program that used strconv.Quote.
Related details
Attention is currently required from:
- Damien Neil
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gopher Robot (Gerrit)
Jun 30, 2026, 6:48:03 PM (5 hours ago) Jun 30
to Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Alan Donovan, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
gopls/internal/licenses: use //go:embed rather than a hand-embedded string
Avoid surprising errors (and a not-very-useful code injection mechanism)
when processing a license containing a back-quote.
Change-Id: I6295a98ba4a037b3ea05e58599befc116a6a6964
Reviewed-on: https://go-review.googlesource.com/c/tools/+/795880
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adon...@google.com>
Reviewed-by: Alan Donovan <adon...@google.com>
Files:
- M gopls/internal/licenses/gen-licenses.sh
- M gopls/internal/licenses/licenses.go
- A gopls/internal/licenses/licenses.txt
- M gopls/internal/licenses/licenses_test.go
Change size: XL
Delta: 4 files changed, 572 insertions(+), 583 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages