[go] cmd/dist: build one more toolchain when GOEXPERIMENT is set

0 views
Skip to first unread message

Michael Matloob (Gerrit)

unread,
Aug 11, 2026, 3:49:57 PM (12 hours ago) Aug 11
to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Michael Pratt, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Dmitri Shuralyov and Michael Pratt

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Dmitri Shuralyov
  • Michael Pratt
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I47aed66bc30fda86366042cbf8fcc32e6a6a6964
Gerrit-Change-Number: 813380
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Attention: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Tue, 11 Aug 2026 19:49:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
Aug 11, 2026, 6:29:03 PM (9 hours ago) Aug 11
to Michael Matloob, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Robert Griesemer, golang...@luci-project-accounts.iam.gserviceaccount.com, Russ Cox, Michael Pratt, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Michael Pratt

Dmitri Shuralyov voted and added 3 comments

Votes added by Dmitri Shuralyov

Code-Review+2

3 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Dmitri Shuralyov . resolved

Thanks.

Commit Message
Line 24, Patchset 1 (Latest):Change-Id: I47aed66bc30fda86366042cbf8fcc32e6a6a6964
Dmitri Shuralyov . unresolved

Consider requiring at least one builder that's running into this, e.g.:

```suggestion
Change-Id: I47aed66bc30fda86366042cbf8fcc32e6a6a6964
Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-runtimefreegc
```

File src/cmd/dist/build.go
Line 1471, Patchset 1 (Latest): // Disable GOEXPERIMENT when building toolchain1 and
// go_bootstrap. We don't need any experiments for the
// bootstrap toolchain, and this lets us avoid duplicating the
// GOEXPERIMENT-related build logic from cmd/go here. If the
// bootstrap toolchain is < Go 1.17, it will ignore this
// anyway since GOEXPERIMENT is baked in; otherwise it will
// pick it up from the environment we set here. Once we're
// using toolchain1 with dist as the build system, we need to
// override this to keep the experiments assumed by the
// toolchain and by dist consistent. Once go_bootstrap takes
// over the build process, we'll set this back to the original
// GOEXPERIMENT.
os.Setenv("GOEXPERIMENT", "none")
Dmitri Shuralyov . resolved

I understand this is fixing the case of actually building a target toolchain with some GOEXPERIMENT set. This comment was useful for me to confirm that.

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Matloob
  • Michael Pratt
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I47aed66bc30fda86366042cbf8fcc32e6a6a6964
Gerrit-Change-Number: 813380
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-CC: Robert Griesemer <g...@golang.org>
Gerrit-CC: Russ Cox <r...@golang.org>
Gerrit-Attention: Michael Matloob <mat...@golang.org>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Tue, 11 Aug 2026 22:28:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dmitri Shuralyov (Gerrit)

unread,
Aug 11, 2026, 6:29:21 PM (9 hours ago) Aug 11
to Michael Matloob, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Robert Griesemer, golang...@luci-project-accounts.iam.gserviceaccount.com, Russ Cox, Michael Pratt, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Michael Pratt

Dmitri Shuralyov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Matloob
  • Michael Pratt
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I47aed66bc30fda86366042cbf8fcc32e6a6a6964
Gerrit-Change-Number: 813380
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-CC: Robert Griesemer <g...@golang.org>
Gerrit-CC: Russ Cox <r...@golang.org>
Gerrit-Attention: Michael Matloob <mat...@golang.org>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Tue, 11 Aug 2026 22:29:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Matloob (Gerrit)

unread,
Aug 11, 2026, 10:01:09 PM (5 hours ago) Aug 11
to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Dmitri Shuralyov, Robert Griesemer, golang...@luci-project-accounts.iam.gserviceaccount.com, Russ Cox, Michael Pratt, golang-co...@googlegroups.com
Attention needed from Michael Pratt

Michael Matloob voted and added 1 comment

Votes added by Michael Matloob

Commit-Queue+1

1 comment

Commit Message
Line 24, Patchset 1 (Latest):Change-Id: I47aed66bc30fda86366042cbf8fcc32e6a6a6964
Dmitri Shuralyov . resolved

Consider requiring at least one builder that's running into this, e.g.:

```suggestion
Change-Id: I47aed66bc30fda86366042cbf8fcc32e6a6a6964
Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-runtimefreegc
```

Michael Matloob

Fix applied.

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Pratt
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I47aed66bc30fda86366042cbf8fcc32e6a6a6964
Gerrit-Change-Number: 813380
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-CC: Robert Griesemer <g...@golang.org>
Gerrit-CC: Russ Cox <r...@golang.org>
Gerrit-Attention: Michael Pratt <mpr...@google.com>
Gerrit-Comment-Date: Wed, 12 Aug 2026 02:01:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Dmitri Shuralyov <dmit...@golang.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Matloob (Gerrit)

unread,
Aug 11, 2026, 10:02:08 PM (5 hours ago) Aug 11
to goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Dmitri Shuralyov, Robert Griesemer, golang...@luci-project-accounts.iam.gserviceaccount.com, Russ Cox, Michael Pratt, golang-co...@googlegroups.com
Attention needed from Michael Matloob and Michael Pratt

Michael Matloob voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Matloob
  • Michael Pratt
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I47aed66bc30fda86366042cbf8fcc32e6a6a6964
    Gerrit-Change-Number: 813380
    Gerrit-PatchSet: 2
    Gerrit-Owner: Michael Matloob <mat...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
    Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
    Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: Robert Griesemer <g...@golang.org>
    Gerrit-CC: Russ Cox <r...@golang.org>
    Gerrit-Attention: Michael Matloob <mat...@golang.org>
    Gerrit-Attention: Michael Pratt <mpr...@google.com>
    Gerrit-Comment-Date: Wed, 12 Aug 2026 02:02:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Michael Matloob (Gerrit)

    unread,
    Aug 11, 2026, 10:18:22 PM (5 hours ago) Aug 11
    to Michael Matloob, goph...@pubsubhelper.golang.org, Dmitri Shuralyov, Dmitri Shuralyov, Robert Griesemer, golang...@luci-project-accounts.iam.gserviceaccount.com, Russ Cox, Michael Pratt, golang-co...@googlegroups.com
    Attention needed from Michael Matloob and Michael Pratt

    Michael Matloob voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Matloob
    • Michael Pratt
    Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      • requirement is not satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I47aed66bc30fda86366042cbf8fcc32e6a6a6964
      Gerrit-Change-Number: 813380
      Gerrit-PatchSet: 2
      Gerrit-Owner: Michael Matloob <mat...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
      Gerrit-Reviewer: Michael Matloob <mat...@google.com>
      Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
      Gerrit-CC: Robert Griesemer <g...@golang.org>
      Gerrit-CC: Russ Cox <r...@golang.org>
      Gerrit-Attention: Michael Matloob <mat...@golang.org>
      Gerrit-Attention: Michael Pratt <mpr...@google.com>
      Gerrit-Comment-Date: Wed, 12 Aug 2026 02:18:17 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Gopher Robot (Gerrit)

      unread,
      Aug 11, 2026, 10:34:07 PM (5 hours ago) Aug 11
      to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Matloob, Dmitri Shuralyov, Dmitri Shuralyov, Robert Griesemer, golang...@luci-project-accounts.iam.gserviceaccount.com, Russ Cox, Michael Pratt, golang-co...@googlegroups.com

      Gopher Robot submitted the change

      Unreviewed changes

      1 is the latest approved patch-set.
      No files were changed between the latest approved patch-set and the submitted one.

      Change information

      Commit message:
      cmd/dist: build one more toolchain when GOEXPERIMENT is set

      When GOEXPERIMENT is set, toolchain1, which is built with
      GOEXPERIMENT=none, may not be semantically the same as toolchain2. That
      in turn means that toolchain2 (built with toolchain1) might have
      different bytes than toolchain3 (built with toolchain2). And that means
      that the toolchain2 tool hash will be different that toolchain3's tool
      hash. And in turn that means that the cache keys used to cache the
      packages in toolchain3's build, which include toolchain2's tool hash,
      would be different than those used to build the toolchain using
      toolchain3, which means that the build hasn't converged.

      We need to build one more toolchain using toolchain3 to converge in that
      case.

      For #80773
      Change-Id: I47aed66bc30fda86366042cbf8fcc32e6a6a6964
      Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-runtimefreegc
      Auto-Submit: Michael Matloob <mat...@golang.org>
      Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
      Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>
      Reviewed-by: Michael Matloob <mat...@google.com>
      Files:
      • M src/cmd/dist/build.go
      Change size: S
      Delta: 1 file changed, 13 insertions(+), 3 deletions(-)
      Branch: refs/heads/master
      Submit Requirements:
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I47aed66bc30fda86366042cbf8fcc32e6a6a6964
      Gerrit-Change-Number: 813380
      Gerrit-PatchSet: 3
      Gerrit-Owner: Michael Matloob <mat...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
      Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
      Gerrit-Reviewer: Gopher Robot <go...@golang.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages