[go/release-branch.go1.25] [release-branch.go1.25] runtime/race: set missing argument frame for ppc64x atomic And/Or wrappers
5 views
Skip to first unread message
Jayanth Krishnamurthy (Gerrit)
Dec 10, 2025, 2:42:26 AM (6 days ago) Dec 10
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Jayanth Krishnamurthy has uploaded the change for review![]( "Open in Gerrit")
Commit message
[release-branch.go1.25] runtime/race: set missing argument frame for ppc64x atomic And/Or wrappers
The ppc64x TSAN wrappers for atomic And/Or did not initialize R6 with the Go argument frame before calling racecallatomic. Since racecallatomic expects R6 to point to the argument list and dereferences it unconditionally, this led to a nil-pointer dereference under -race.
Other atomic TSAN wrappers (Load/Store/Add/Swap/CAS) already set up R6 in the expected way. This change aligns the And/Or wrappers with the rest by adding the missing R6 initialisation.
This keeps the behavior consistent across all atomic operations on ppc64x.
Updates #76776.
Change-Id: Iaf578449a6171a0c6f7c33ec6f64c1251297ae6d
Cq-Include-Trybots: luci.golang.try:gotip-linux-ppc64_power10,gotip-linux-ppc64_power8,gotip-linux-ppc64le_power8,gotip-linux-ppc64le_power9,gotip-linux-ppc64le_power10
Reviewed-on: https://go-review.googlesource.com/c/go/+/718560
Reviewed-by: Mark Freeman <markf...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: Paul Murphy <paum...@redhat.com>
(cherry picked from commit 44cb82449e7f24530fe0fe0bf8261ba9e0e4e7d8)
Change diff
diff --git a/src/runtime/race_ppc64le.s b/src/runtime/race_ppc64le.s
index b327e49..41cd232 100644
--- a/src/runtime/race_ppc64le.s
+++ b/src/runtime/race_ppc64le.s
@@ -329,11 +329,13 @@
TEXT sync∕atomic·AndInt32(SB), NOSPLIT, $0-20
GO_ARGS
MOVD $__tsan_go_atomic32_fetch_and(SB), R8
+ ADD $32, R1, R6
BR racecallatomic<>(SB)
TEXT sync∕atomic·AndInt64(SB), NOSPLIT, $0-24
GO_ARGS
MOVD $__tsan_go_atomic64_fetch_and(SB), R8
+ ADD $32, R1, R6
BR racecallatomic<>(SB)
TEXT sync∕atomic·AndUint32(SB), NOSPLIT, $0-20
@@ -352,11 +354,13 @@
TEXT sync∕atomic·OrInt32(SB), NOSPLIT, $0-20
GO_ARGS
MOVD $__tsan_go_atomic32_fetch_or(SB), R8
+ ADD $32, R1, R6
BR racecallatomic<>(SB)
TEXT sync∕atomic·OrInt64(SB), NOSPLIT, $0-24
GO_ARGS
MOVD $__tsan_go_atomic64_fetch_or(SB), R8
+ ADD $32, R1, R6
BR racecallatomic<>(SB)
TEXT sync∕atomic·OrUint32(SB), NOSPLIT, $0-20
Change information
Files:
- M src/runtime/race_ppc64le.s
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jayanth Krishnamurthy (Gerrit)
Dec 10, 2025, 3:49:42 AM (6 days ago) Dec 10
to goph...@pubsubhelper.golang.org, Carlos Amedee, Dmitry Vyukov, Ian Lance Taylor, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Carlos Amedee, Dmitry Vyukov and Ian Lance Taylor
Jayanth Krishnamurthy voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Carlos Amedee
- Dmitry Vyukov
- Ian Lance Taylor
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jayanth Krishnamurthy (Gerrit)
Dec 10, 2025, 3:16:02 PM (6 days ago) Dec 10
to goph...@pubsubhelper.golang.org, Go LUCI, Carlos Amedee, Dmitry Vyukov, Ian Lance Taylor, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Carlos Amedee, Dmitry Vyukov, Ian Lance Taylor and Jayanth Krishnamurthy
Jayanth Krishnamurthy removed a vote from this change![]( "Open in Gerrit")
Removed LUCI-TryBot-Result-1 by Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Related details
Attention is currently required from:
- Carlos Amedee
- Dmitry Vyukov
- Ian Lance Taylor
- Jayanth Krishnamurthy
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jayanth Krishnamurthy (Gerrit)
Dec 11, 2025, 2:39:21 PM (5 days ago) Dec 11
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Jayanth Krishnamurthy has uploaded the change for review![]( "Open in Gerrit")
Commit message
[release-branch.go1.24] runtime/race: set missing argument frame for ppc64x atomic And/Or wrappers
The ppc64x TSAN wrappers for atomic And/Or did not initialize R6 with the Go argument frame before calling racecallatomic. Since racecallatomic expects R6 to point to the argument list and dereferences it unconditionally, this led to a nil-pointer dereference under -race.
Other atomic TSAN wrappers (Load/Store/Add/Swap/CAS) already set up R6 in the expected way. This change aligns the And/Or wrappers with the rest by adding the missing R6 initialisation.
This keeps the behavior consistent across all atomic operations on ppc64x.
Fixes #76796.
Change-Id: Iaf578449a6171a0c6f7c33ec6f64c1251297ae6d
Cq-Include-Trybots: luci.golang.try:gotip-linux-ppc64_power10,gotip-linux-ppc64_power8,gotip-linux-ppc64le_power8,gotip-linux-ppc64le_power9,gotip-linux-ppc64le_power10
Reviewed-on: https://go-review.googlesource.com/c/go/+/718560
Reviewed-by: Mark Freeman <markf...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: Paul Murphy <paum...@redhat.com>
(cherry picked from commit 44cb82449e7f24530fe0fe0bf8261ba9e0e4e7d8)
Change diff
diff --git a/src/runtime/race_ppc64le.s b/src/runtime/race_ppc64le.s
index 4382947..bd168a3 100644
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Chase (Gerrit)
Dec 12, 2025, 5:22:11 PM (4 days ago) Dec 12
to Jayanth Krishnamurthy, goph...@pubsubhelper.golang.org, Go LUCI, Carlos Amedee, Dmitry Vyukov, Ian Lance Taylor, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Carlos Amedee, Dmitry Vyukov, Ian Lance Taylor and Jayanth Krishnamurthy
David Chase voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Carlos Amedee
- Dmitry Vyukov
- Ian Lance Taylor
- Jayanth Krishnamurthy
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Chase (Gerrit)
Dec 12, 2025, 5:22:25 PM (4 days ago) Dec 12
to Jayanth Krishnamurthy, goph...@pubsubhelper.golang.org, Austin Clements, Dmitry Vyukov, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Austin Clements, Dmitry Vyukov, Jayanth Krishnamurthy and Martin Möhrmann
David Chase voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Austin Clements
- Dmitry Vyukov
- Jayanth Krishnamurthy
- Martin Möhrmann
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jayanth Krishnamurthy (Gerrit)
Dec 12, 2025, 7:31:02 PM (4 days ago) Dec 12
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Carlos Amedee, David Chase, Dmitry Vyukov, Ian Lance Taylor and Jayanth Krishnamurthy
Jayanth Krishnamurthy uploaded new patchset![]( "Open in Gerrit")
Attention is currently required from:
- Carlos Amedee
- David Chase
- Dmitry Vyukov
- Ian Lance Taylor
- Jayanth Krishnamurthy
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jayanth Krishnamurthy (Gerrit)
Dec 12, 2025, 7:32:11 PM (4 days ago) Dec 12
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Austin Clements, David Chase, Dmitry Vyukov, Jayanth Krishnamurthy and Martin Möhrmann
Jayanth Krishnamurthy uploaded new patchset![]( "Open in Gerrit")
Jayanth Krishnamurthy uploaded patch set #2 to this change.
Related details
Attention is currently required from:
- Austin Clements
- David Chase
- Dmitry Vyukov
- Jayanth Krishnamurthy
- Martin Möhrmann
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jayanth Krishnamurthy (Gerrit)
Dec 15, 2025, 9:49:38 PM (17 hours ago) Dec 15
to goph...@pubsubhelper.golang.org, Go LUCI, David Chase, Austin Clements, Dmitry Vyukov, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Austin Clements, David Chase, Dmitry Vyukov, Jayanth Krishnamurthy and Martin Möhrmann
Jayanth Krishnamurthy removed a vote from this change![]( "Open in Gerrit")
Removed LUCI-TryBot-Result-1 by Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Related details
Attention is currently required from:
- Austin Clements
- David Chase
- Dmitry Vyukov
- Jayanth Krishnamurthy
- Martin Möhrmann
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jayanth Krishnamurthy (Gerrit)
Dec 15, 2025, 9:49:55 PM (17 hours ago) Dec 15
to goph...@pubsubhelper.golang.org, David Chase, Go LUCI, Carlos Amedee, Dmitry Vyukov, Ian Lance Taylor, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Carlos Amedee, David Chase, Dmitry Vyukov, Ian Lance Taylor and Jayanth Krishnamurthy
Jayanth Krishnamurthy removed a vote from this change![]( "Open in Gerrit")
Removed LUCI-TryBot-Result-1 by Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Related details
Attention is currently required from:
- Carlos Amedee
- David Chase
- Dmitry Vyukov
- Ian Lance Taylor
- Jayanth Krishnamurthy
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages