[go] cmd/compile: teach regalloc how to commute amd64 CMOV

3 views
Skip to first unread message

Jorropo (Gerrit)

unread,
May 17, 2026, 5:18:53 AMMay 17
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Jorropo

Message from Jorropo

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Jorropo
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I31ce7654496c3a068845f48b48618c6ad3fa45c6
Gerrit-Change-Number: 778460
Gerrit-PatchSet: 2
Gerrit-Owner: Jorropo <jorro...@gmail.com>
Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
Gerrit-Attention: Jorropo <jorro...@gmail.com>
Gerrit-Comment-Date: Sun, 17 May 2026 09:18:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Jorropo (Gerrit)

unread,
May 17, 2026, 5:21:37 AMMay 17
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Jorropo added 1 comment

Patchset-level comments
File-level comment, Patchset 1:
Jorropo . resolved

The idea is strong and works well but I don't like the implementation.

I think I'll change things around and add a field inside genops where an instruction can specify it's commuted form like:
```
{name: "CMOVQEQ", argLength: 3, reg: gp21, asm: "CMOVQEQ", resultInArg0: true, commuted: "CMOVQNE"},
```

Jorropo

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I31ce7654496c3a068845f48b48618c6ad3fa45c6
    Gerrit-Change-Number: 778460
    Gerrit-PatchSet: 2
    Gerrit-Owner: Jorropo <jorro...@gmail.com>
    Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
    Gerrit-Comment-Date: Sun, 17 May 2026 09:21:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Jorropo <jorro...@gmail.com>
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Jorropo (Gerrit)

    unread,
    May 17, 2026, 6:20:27 AMMay 17
    to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
    Attention needed from Jorropo, Keith Randall and Martin Möhrmann

    Jorropo uploaded new patchset

    Jorropo uploaded patch set #5 to this change.
    Following approvals got outdated and were removed:
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jorropo
    • Keith Randall
    • Martin Möhrmann
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement is not satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newpatchset
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I31ce7654496c3a068845f48b48618c6ad3fa45c6
    Gerrit-Change-Number: 778460
    Gerrit-PatchSet: 5
    Gerrit-Owner: Jorropo <jorro...@gmail.com>
    Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
    Gerrit-Reviewer: Keith Randall <k...@golang.org>
    Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Keith Randall <k...@golang.org>
    Gerrit-Attention: Jorropo <jorro...@gmail.com>
    Gerrit-Attention: Martin Möhrmann <moeh...@google.com>
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Jorropo (Gerrit)

    unread,
    May 17, 2026, 6:49:35 AMMay 17
    to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com
    Attention needed from Keith Randall and Martin Möhrmann

    Jorropo voted Auto-Submit+1

    Auto-Submit+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Keith Randall
    • Martin Möhrmann
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I31ce7654496c3a068845f48b48618c6ad3fa45c6
      Gerrit-Change-Number: 778460
      Gerrit-PatchSet: 5
      Gerrit-Owner: Jorropo <jorro...@gmail.com>
      Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
      Gerrit-Reviewer: Keith Randall <k...@golang.org>
      Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
      Gerrit-CC: Gopher Robot <go...@golang.org>
      Gerrit-Attention: Keith Randall <k...@golang.org>
      Gerrit-Attention: Martin Möhrmann <moeh...@google.com>
      Gerrit-Comment-Date: Sun, 17 May 2026 10:49:28 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Jorropo (Gerrit)

      unread,
      Jun 6, 2026, 3:27:56 AM (22 hours ago) Jun 6
      to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
      Attention needed from Jorropo, Keith Randall and Martin Möhrmann

      Jorropo uploaded new patchset

      Jorropo uploaded patch set #6 to this change.
      Following approvals got outdated and were removed:
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Jorropo
      • Keith Randall
      • Martin Möhrmann
      Submit Requirements:
        • requirement is not satisfiedCode-Review
        • requirement satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedNo-Wait-Release
        • requirement is not satisfiedReview-Enforcement
        • requirement is not satisfiedTryBots-Pass
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: newpatchset
        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I31ce7654496c3a068845f48b48618c6ad3fa45c6
        Gerrit-Change-Number: 778460
        Gerrit-PatchSet: 6
        Gerrit-Owner: Jorropo <jorro...@gmail.com>
        Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
        Gerrit-Reviewer: Keith Randall <k...@golang.org>
        Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
        Gerrit-CC: Gopher Robot <go...@golang.org>
        Gerrit-Attention: Keith Randall <k...@golang.org>
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages