[go] doc/go1.17: reword "results" in stack trace printing

9 views
Skip to first unread message

Cherry Mui (Gerrit)

unread,
Jun 14, 2021, 12:43:06 PM6/14/21
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Cherry Mui has uploaded this change for review.

View Change

doc/go1.17: reword "results" in stack trace printing

"Results" may sound like the results from the previous sentence.
Reword to "function return values" for clarity.

Suggested by Tobias Kohlbau.

Change-Id: Ie78df36b5b191b06e98b802f9a46db6d067a8ea0
---
M doc/go1.17.html
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/go1.17.html b/doc/go1.17.html
index 35d0f97..e0856ff 100644
--- a/doc/go1.17.html
+++ b/doc/go1.17.html
@@ -406,7 +406,8 @@
by commas. Aggregate-typed (struct, array, string, slice, interface, and complex)
arguments are delimited by curly braces. A caveat is that the value of an
argument that only lives in a register and is not stored to memory may be
- inaccurate. Results (which were usually inaccurate) are no longer printed.
+ inaccurate. Function return values (which were usually inaccurate) are no longer
+ printed.
</p>

<p><!-- CL 283112, golang.org/issue/28727 -->

To view, visit change 327774. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ie78df36b5b191b06e98b802f9a46db6d067a8ea0
Gerrit-Change-Number: 327774
Gerrit-PatchSet: 1
Gerrit-Owner: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-MessageType: newchange

Michael Knyszek (Gerrit)

unread,
Jun 14, 2021, 12:55:25 PM6/14/21
to Cherry Mui, goph...@pubsubhelper.golang.org, Tobias Kohlbau, Jeremy Faller, golang-co...@googlegroups.com

Attention is currently required from: Tobias Kohlbau, Jeremy Faller, Cherry Mui.

Patch set 1:Code-Review +2

View Change

    To view, visit change 327774. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ie78df36b5b191b06e98b802f9a46db6d067a8ea0
    Gerrit-Change-Number: 327774
    Gerrit-PatchSet: 1
    Gerrit-Owner: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Jeremy Faller <jer...@golang.org>
    Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
    Gerrit-Reviewer: Tobias Kohlbau <tob...@kohlbau.de>
    Gerrit-Attention: Tobias Kohlbau <tob...@kohlbau.de>
    Gerrit-Attention: Jeremy Faller <jer...@golang.org>
    Gerrit-Attention: Cherry Mui <cher...@google.com>
    Gerrit-Comment-Date: Mon, 14 Jun 2021 16:55:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Tobias Kohlbau (Gerrit)

    unread,
    Jun 14, 2021, 1:20:45 PM6/14/21
    to Cherry Mui, goph...@pubsubhelper.golang.org, Jeremy Faller, golang-co...@googlegroups.com

    Attention is currently required from: Jeremy Faller, Cherry Mui.

    Patch set 1:Code-Review +1

    View Change

      To view, visit change 327774. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Ie78df36b5b191b06e98b802f9a46db6d067a8ea0
      Gerrit-Change-Number: 327774
      Gerrit-PatchSet: 1
      Gerrit-Owner: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Jeremy Faller <jer...@golang.org>
      Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
      Gerrit-Reviewer: Tobias Kohlbau <tob...@kohlbau.de>
      Gerrit-Attention: Jeremy Faller <jer...@golang.org>
      Gerrit-Attention: Cherry Mui <cher...@google.com>
      Gerrit-Comment-Date: Mon, 14 Jun 2021 17:20:38 +0000

      Cherry Mui (Gerrit)

      unread,
      Jun 14, 2021, 3:26:26 PM6/14/21
      to goph...@pubsubhelper.golang.org, Tobias Kohlbau, Jeremy Faller, golang-co...@googlegroups.com

      Attention is currently required from: Jeremy Faller.

      View Change

      1 comment:

      To view, visit change 327774. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Ie78df36b5b191b06e98b802f9a46db6d067a8ea0
      Gerrit-Change-Number: 327774
      Gerrit-PatchSet: 1
      Gerrit-Owner: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Jeremy Faller <jer...@golang.org>
      Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
      Gerrit-Reviewer: Tobias Kohlbau <tob...@kohlbau.de>
      Gerrit-Attention: Jeremy Faller <jer...@golang.org>
      Gerrit-Comment-Date: Mon, 14 Jun 2021 19:26:21 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Gerrit-MessageType: comment

      Cherry Mui (Gerrit)

      unread,
      Jun 14, 2021, 3:26:30 PM6/14/21
      to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Tobias Kohlbau, Michael Knyszek, Jeremy Faller, golang-co...@googlegroups.com

      Cherry Mui submitted this change.

      View Change

      Approvals: Tobias Kohlbau: Looks good to me, but someone else must approve Michael Knyszek: Looks good to me, approved Cherry Mui: Trusted
      doc/go1.17: reword "results" in stack trace printing

      "Results" may sound like the results from the previous sentence.
      Reword to "function return values" for clarity.

      Suggested by Tobias Kohlbau.

      Change-Id: Ie78df36b5b191b06e98b802f9a46db6d067a8ea0
      Reviewed-on: https://go-review.googlesource.com/c/go/+/327774
      Trust: Cherry Mui <cher...@google.com>
      Reviewed-by: Michael Knyszek <mkny...@google.com>
      Reviewed-by: Tobias Kohlbau <tob...@kohlbau.de>

      ---
      M doc/go1.17.html
      1 file changed, 2 insertions(+), 1 deletion(-)

      diff --git a/doc/go1.17.html b/doc/go1.17.html
      index 35d0f97..e0856ff 100644
      --- a/doc/go1.17.html
      +++ b/doc/go1.17.html
      @@ -406,7 +406,8 @@
      by commas. Aggregate-typed (struct, array, string, slice, interface, and complex)
      arguments are delimited by curly braces. A caveat is that the value of an
      argument that only lives in a register and is not stored to memory may be
      - inaccurate. Results (which were usually inaccurate) are no longer printed.
      + inaccurate. Function return values (which were usually inaccurate) are no longer
      + printed.
      </p>

      <p><!-- CL 283112, golang.org/issue/28727 -->

      To view, visit change 327774. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: Ie78df36b5b191b06e98b802f9a46db6d067a8ea0
      Gerrit-Change-Number: 327774
      Gerrit-PatchSet: 2
      Gerrit-Owner: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Cherry Mui <cher...@google.com>
      Gerrit-Reviewer: Jeremy Faller <jer...@golang.org>
      Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
      Gerrit-Reviewer: Tobias Kohlbau <tob...@kohlbau.de>
      Gerrit-MessageType: merged
      Reply all
      Reply to author
      Forward
      0 new messages