[go] types2: implement arbitrary field selectors for struct literals
4 views
Skip to first unread message
Robert Griesemer (Gerrit)
Mar 6, 2026, 12:47:29 AM (14 days ago) Mar 6
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Robert Griesemer uploaded new patchset![]( "Open in Gerrit")
Robert Griesemer uploaded patch set #3 to this change.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
Mar 6, 2026, 12:51:20 AM (14 days ago) Mar 6
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Robert Griesemer voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
Mar 7, 2026, 12:21:49 AM (13 days ago) Mar 7
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Robert Griesemer
Robert Griesemer uploaded new patchset![]( "Open in Gerrit")
Robert Griesemer uploaded patch set #4 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
Related details
Attention is currently required from:
- Robert Griesemer
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
Mar 7, 2026, 12:40:51 AM (13 days ago) Mar 7
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Robert Griesemer
Robert Griesemer uploaded new patchset![]( "Open in Gerrit")
Robert Griesemer uploaded patch set #5 to this change.
Related details
Attention is currently required from:
- Robert Griesemer
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
Mar 7, 2026, 12:43:30 AM (13 days ago) Mar 7
to goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Robert Griesemer voted Commit-Queue+1![]( "Open in Gerrit")
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
Mar 9, 2026, 5:15:19 PM (10 days ago) Mar 9
to goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Robert Griesemer voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
Mar 9, 2026, 5:51:35 PM (10 days ago) Mar 9
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Robert Griesemer
Robert Griesemer uploaded new patchset![]( "Open in Gerrit")
Robert Griesemer uploaded patch set #7 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
Related details
Attention is currently required from:
- Robert Griesemer
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
Mar 9, 2026, 5:54:17 PM (10 days ago) Mar 9
to goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Robert Griesemer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Robert Griesemer
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Robert Griesemer . resolved
Failure is unrelated. Trying trybots once more.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
Mar 16, 2026, 7:00:56 PM (3 days ago) Mar 16
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Robert Griesemer
Robert Griesemer uploaded new patchset![]( "Open in Gerrit")
Attention is currently required from:
- Robert Griesemer
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
Mar 16, 2026, 7:03:42 PM (3 days ago) Mar 16
to goph...@pubsubhelper.golang.org, Mark Freeman, Go LUCI, golang-co...@googlegroups.com
Attention needed from Mark Freeman
Robert Griesemer voted![]( "Open in Gerrit")
Attention is currently required from:
- Mark Freeman
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mark Freeman (Gerrit)
Mar 18, 2026, 3:01:07 PM (yesterday) Mar 18
to Robert Griesemer, goph...@pubsubhelper.golang.org, Go LUCI, golang-co...@googlegroups.com
Attention needed from Robert Griesemer
Mark Freeman voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mark Freeman
| Code-Review | +2 |
1 comment
File src/internal/types/testdata/spec/structLits.go
Line 34, Patchset 10 (Latest):
_ = A{B: B{}, b /* ERROR "" */ : 0}Mark Freeman . unresolved
Is this intentional? Should it be moved closer to the case on the bottom? They are somewhat inverses of each other.
Related details
Attention is currently required from:
- Robert Griesemer
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
5:08 PM (5 hours ago) 5:08 PM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Robert Griesemer
Robert Griesemer uploaded new patchset![]( "Open in Gerrit")
Robert Griesemer uploaded patch set #11 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI
Related details
Attention is currently required from:
- Robert Griesemer
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
5:09 PM (5 hours ago) 5:09 PM
to goph...@pubsubhelper.golang.org, Mark Freeman, Go LUCI, golang-co...@googlegroups.com
Robert Griesemer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Robert Griesemer
| Code-Review | +1 |
| Commit-Queue | +1 |
1 comment
File src/internal/types/testdata/spec/structLits.go
Is this intentional? Should it be moved closer to the case on the bottom? They are somewhat inverses of each other.
Robert Griesemer
Good catch - oversight. Fixed.
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Griesemer (Gerrit)
5:32 PM (5 hours ago) 5:32 PM
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Mark Freeman, golang-co...@googlegroups.com
Robert Griesemer submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
10 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/internal/types/testdata/spec/structLits.go
Insertions: 1, Deletions: 1.
@@ -31,9 +31,9 @@
_ = A{A /* ERROR "unknown field A in struct literal of type A, but does have a" */ : 0}
_ = A{X /* ERROR "unknown field X in struct literal of type A, but does have x" */ : 0}
_ = A{a: 0, b: 0, c: 0}
- _ = A{B: B{}, b /* ERROR "" */ : 0}
_ = A{x /* ERROR "pointer indirection" */ : 0}
_ = B{b: 0, c: 0, x: 0, y: 0, z: 0}
_ = B{C: C{}, x /* ERROR "cannot specify promoted field x and enclosing embedded field C" */ : 0}
_ = A{b: 0, B /* ERROR "cannot specify embedded field B and enclosed promoted field b" */ : B{}}
+ _ = A{B: B{}, b /* ERROR "cannot specify promoted field b and enclosing embedded field B" */ : 0}
)
```
Change information
Commit message:
go/types, types2: allow promoted field names as keys in struct literals
For #9859.
Change-Id: Ie4823e726ab43fe2ce1e96c279f63dad6c1f9873
Reviewed-on: https://go-review.googlesource.com/c/go/+/751702
Reviewed-by: Mark Freeman <markf...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Griesemer <g...@google.com>
Files:
- M src/cmd/compile/internal/types2/literals.go
- M src/cmd/compile/internal/types2/lookup.go
- M src/go/types/literals.go
- M src/go/types/lookup.go
- M src/internal/types/testdata/check/expr3.go
- A src/internal/types/testdata/spec/structLits.go
- M test/fixedbugs/issue23609.go
- M test/fixedbugs/issue26416.go
Change size: M
Delta: 8 files changed, 144 insertions(+), 57 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Mark Freeman, +1 by Robert Griesemer
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages