[go] test/codegen: add riscv64 checks for conditional subtractions

4 views
Skip to first unread message

Kinson Nee (Gerrit)

unread,
Jul 15, 2026, 10:07:05 PM (6 days ago) Jul 15
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Kinson Nee has uploaded the change for review

Commit message

test/codegen: add riscv64 checks for conditional subtractions

Add riscv64 asmcheck coverage for the conditional subtraction cases in condmove.go.

Verify that rva20u64 and rva22u64 keep using the existing SNEZ/NEG/AND/OR sequence. Verify that rva23u64 uses CZERONEZ/CZEROEQZ/OR without the older fallback sequence.
Co-authored-by: YuanSheng <yuan...@isrc.iscas.ac.cn>
Change-Id: I7df5c57e36e57c6309ce0fb0efd2d53bd9e06b76

Change diff

diff --git a/test/codegen/condmove.go b/test/codegen/condmove.go
index 8366961..17d0f99 100644
--- a/test/codegen/condmove.go
+++ b/test/codegen/condmove.go
@@ -857,6 +857,8 @@
 	const q = 8380417 // 2²³ - 2¹³ + 1
 	// FIXME: the compiler struggles with Sub32 since it's not intriscified.
 	x, b := bits.Sub32(a, q, 0)
+	// riscv64/rva20u64,riscv64/rva22u64:"SNEZ" "NEG" "AND" "OR"
+	// riscv64/rva23u64:"CZERONEZ" "CZEROEQZ" "OR" -"SNEZ" -"NEG" -"AND"
 	return uint32(subtle.ConstantTimeSelect(int(b), int(a), int(x)))
 }
 
@@ -872,5 +874,7 @@
 	// amd64:"SUB" -"TEST" -"SBB"
 	x, b := bits.Sub64(uint64(a), q, 0)
 	// amd64:"CMOV" -"TEST" -"SBB"
+	// riscv64/rva20u64,riscv64/rva22u64:"SNEZ" "NEG" "AND" "OR"
+	// riscv64/rva23u64:"CZERONEZ" "CZEROEQZ" "OR" -"SNEZ" -"NEG" -"AND"
 	return uint32(subtle.ConstantTimeSelect(int(b), int(a), int(x)))
 }

Change information

Files:
  • M test/codegen/condmove.go
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I7df5c57e36e57c6309ce0fb0efd2d53bd9e06b76
Gerrit-Change-Number: 801360
Gerrit-PatchSet: 1
Gerrit-Owner: Kinson Nee <kins...@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Jorropo (Gerrit)

unread,
Jul 15, 2026, 10:47:15 PM (6 days ago) Jul 15
to Kinson Nee, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Kinson Nee

Jorropo voted

Auto-Submit+1
Code-Review+2
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kinson Nee
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I7df5c57e36e57c6309ce0fb0efd2d53bd9e06b76
Gerrit-Change-Number: 801360
Gerrit-PatchSet: 1
Gerrit-Owner: Kinson Nee <kins...@gmail.com>
Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
Gerrit-Attention: Kinson Nee <kins...@gmail.com>
Gerrit-Comment-Date: Thu, 16 Jul 2026 02:47:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Meng Zhuo (Gerrit)

unread,
Jul 16, 2026, 5:52:45 AM (6 days ago) Jul 16
to Kinson Nee, goph...@pubsubhelper.golang.org, Joel Sing, Mark Ryan, Meng Zhuo, golang...@luci-project-accounts.iam.gserviceaccount.com, Jorropo, golang-co...@googlegroups.com
Attention needed from Kinson Nee

Related details

Attention is currently required from:
  • Kinson Nee
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I7df5c57e36e57c6309ce0fb0efd2d53bd9e06b76
    Gerrit-Change-Number: 801360
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kinson Nee <kins...@gmail.com>
    Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
    Gerrit-CC: Joel Sing <jo...@sing.id.au>
    Gerrit-CC: Mark Ryan <mark...@meta.com>
    Gerrit-CC: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Attention: Kinson Nee <kins...@gmail.com>
    Gerrit-Comment-Date: Thu, 16 Jul 2026 09:52:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Meng Zhuo (Gerrit)

    unread,
    Jul 16, 2026, 5:55:46 AM (6 days ago) Jul 16
    to Kinson Nee, goph...@pubsubhelper.golang.org, Joel Sing, Mark Ryan, Meng Zhuo, golang...@luci-project-accounts.iam.gserviceaccount.com, Jorropo, golang-co...@googlegroups.com
    Attention needed from Jorropo and Kinson Nee

    Meng Zhuo removed a vote from this change

    Removed Auto-Submit+1 by Jorropo <jorro...@gmail.com>
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jorropo
    • Kinson Nee
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: deleteVote
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I7df5c57e36e57c6309ce0fb0efd2d53bd9e06b76
    Gerrit-Change-Number: 801360
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kinson Nee <kins...@gmail.com>
    Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
    Gerrit-CC: Joel Sing <jo...@sing.id.au>
    Gerrit-CC: Mark Ryan <mark...@meta.com>
    Gerrit-CC: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Attention: Jorropo <jorro...@gmail.com>
    Gerrit-Attention: Kinson Nee <kins...@gmail.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Michael Pratt (Gerrit)

    unread,
    Jul 17, 2026, 2:57:19 PM (4 days ago) Jul 17
    to Kinson Nee, goph...@pubsubhelper.golang.org, Michael Pratt, Joel Sing, Mark Ryan, Meng Zhuo, golang...@luci-project-accounts.iam.gserviceaccount.com, Jorropo, golang-co...@googlegroups.com
    Attention needed from Jorropo and Kinson Nee

    Michael Pratt voted and added 1 comment

    Votes added by Michael Pratt

    Code-Review+1

    1 comment

    Patchset-level comments
    Meng Zhuo . unresolved
    Michael Pratt

    Is this meant to be a blocking comment?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jorropo
    • Kinson Nee
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I7df5c57e36e57c6309ce0fb0efd2d53bd9e06b76
    Gerrit-Change-Number: 801360
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kinson Nee <kins...@gmail.com>
    Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: Joel Sing <jo...@sing.id.au>
    Gerrit-CC: Mark Ryan <mark...@meta.com>
    Gerrit-CC: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Attention: Jorropo <jorro...@gmail.com>
    Gerrit-Attention: Kinson Nee <kins...@gmail.com>
    Gerrit-Comment-Date: Fri, 17 Jul 2026 18:57:15 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Meng Zhuo <mengzh...@gmail.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Meng Zhuo (Gerrit)

    unread,
    Jul 17, 2026, 9:20:51 PM (4 days ago) Jul 17
    to Kinson Nee, goph...@pubsubhelper.golang.org, Meng Zhuo, Michael Pratt, Joel Sing, Mark Ryan, golang...@luci-project-accounts.iam.gserviceaccount.com, Jorropo, golang-co...@googlegroups.com
    Attention needed from Jorropo and Kinson Nee

    Meng Zhuo voted and added 1 comment

    Votes added by Meng Zhuo

    Code-Review+2

    1 comment

    Patchset-level comments
    Meng Zhuo

    Yes, I've already drop the auto submit label.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jorropo
    • Kinson Nee
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I7df5c57e36e57c6309ce0fb0efd2d53bd9e06b76
    Gerrit-Change-Number: 801360
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kinson Nee <kins...@gmail.com>
    Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
    Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Attention: Kinson Nee <kins...@gmail.com>
    Gerrit-Attention: Jorropo <jorro...@gmail.com>
    Gerrit-Comment-Date: Sat, 18 Jul 2026 01:20:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Michael Pratt <mpr...@google.com>
    Comment-In-Reply-To: Meng Zhuo <mengzh...@gmail.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Meng Zhuo (Gerrit)

    unread,
    Jul 17, 2026, 9:21:18 PM (4 days ago) Jul 17
    to Kinson Nee, goph...@pubsubhelper.golang.org, Meng Zhuo, Michael Pratt, Joel Sing, Mark Ryan, golang...@luci-project-accounts.iam.gserviceaccount.com, Jorropo, golang-co...@googlegroups.com
    Attention needed from Jorropo and Kinson Nee

    Meng Zhuo voted

    Code-Review+0
    Hold+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jorropo
    • Kinson Nee
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Holds
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I7df5c57e36e57c6309ce0fb0efd2d53bd9e06b76
    Gerrit-Change-Number: 801360
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kinson Nee <kins...@gmail.com>
    Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
    Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: Joel Sing <jo...@sing.id.au>
    Gerrit-CC: Mark Ryan <mark...@meta.com>
    Gerrit-Attention: Kinson Nee <kins...@gmail.com>
    Gerrit-Attention: Jorropo <jorro...@gmail.com>
    Gerrit-Comment-Date: Sat, 18 Jul 2026 01:21:13 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kinson Nee (Gerrit)

    unread,
    Jul 20, 2026, 2:05:00 AM (yesterday) Jul 20
    to goph...@pubsubhelper.golang.org, Meng Zhuo, Michael Pratt, Joel Sing, Mark Ryan, golang...@luci-project-accounts.iam.gserviceaccount.com, Jorropo, golang-co...@googlegroups.com
    Attention needed from Jorropo

    Message from Kinson Nee

    Thanks. I think this is OK for the rva23u64 asmcheck because RVA23U64 mandates both Zkt and Zicond. The Zicond spec gives data-independent timing for CZERO.* when Zkt is implemented, and this test only expects CZERO.* for rva23u64; rva20u64/rva22u64 still check the non-Zicond sequence.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jorropo
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Holds
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I7df5c57e36e57c6309ce0fb0efd2d53bd9e06b76
    Gerrit-Change-Number: 801360
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kinson Nee <kins...@gmail.com>
    Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
    Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: Joel Sing <jo...@sing.id.au>
    Gerrit-CC: Mark Ryan <mark...@meta.com>
    Gerrit-Attention: Jorropo <jorro...@gmail.com>
    Gerrit-Comment-Date: Mon, 20 Jul 2026 06:04:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Meng Zhuo (Gerrit)

    unread,
    Jul 20, 2026, 3:44:39 AM (yesterday) Jul 20
    to Kinson Nee, goph...@pubsubhelper.golang.org, Meng Zhuo, Michael Pratt, Joel Sing, Mark Ryan, golang...@luci-project-accounts.iam.gserviceaccount.com, Jorropo, golang-co...@googlegroups.com
    Attention needed from Jorropo and Kinson Nee

    Meng Zhuo voted

    Code-Review+2
    Commit-Queue+1
    Hold+0
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jorropo
    • Kinson Nee
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I7df5c57e36e57c6309ce0fb0efd2d53bd9e06b76
    Gerrit-Change-Number: 801360
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kinson Nee <kins...@gmail.com>
    Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
    Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: Joel Sing <jo...@sing.id.au>
    Gerrit-CC: Mark Ryan <mark...@meta.com>
    Gerrit-Attention: Kinson Nee <kins...@gmail.com>
    Gerrit-Attention: Jorropo <jorro...@gmail.com>
    Gerrit-Comment-Date: Mon, 20 Jul 2026 07:44:34 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Meng Zhuo (Gerrit)

    unread,
    Jul 20, 2026, 3:44:52 AM (yesterday) Jul 20
    to Kinson Nee, goph...@pubsubhelper.golang.org, Meng Zhuo, Michael Pratt, Joel Sing, Mark Ryan, golang...@luci-project-accounts.iam.gserviceaccount.com, Jorropo, golang-co...@googlegroups.com
    Attention needed from Jorropo, Kinson Nee and Michael Pratt

    Meng Zhuo added 1 comment

    Patchset-level comments
    Meng Zhuo . resolved

    I think zicond requires zkt to be const time

    Michael Pratt

    Is this meant to be a blocking comment?

    Meng Zhuo

    Yes, I've already drop the auto submit label.

    Meng Zhuo

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jorropo
    • Kinson Nee
    • Michael Pratt
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I7df5c57e36e57c6309ce0fb0efd2d53bd9e06b76
    Gerrit-Change-Number: 801360
    Gerrit-PatchSet: 1
    Gerrit-Owner: Kinson Nee <kins...@gmail.com>
    Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
    Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
    Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
    Gerrit-CC: Joel Sing <jo...@sing.id.au>
    Gerrit-CC: Mark Ryan <mark...@meta.com>
    Gerrit-Attention: Kinson Nee <kins...@gmail.com>
    Gerrit-Attention: Jorropo <jorro...@gmail.com>
    Gerrit-Attention: Michael Pratt <mpr...@google.com>
    Gerrit-Comment-Date: Mon, 20 Jul 2026 07:44:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Carlos Amedee (Gerrit)

    unread,
    5:39 PM (5 hours ago) 5:39 PM
    to Kinson Nee, goph...@pubsubhelper.golang.org, Meng Zhuo, Michael Pratt, Joel Sing, Mark Ryan, golang...@luci-project-accounts.iam.gserviceaccount.com, Jorropo, golang-co...@googlegroups.com
    Attention needed from Jorropo, Kinson Nee and Michael Pratt

    Carlos Amedee voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jorropo
    • Kinson Nee
    • Michael Pratt
    Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      • requirement satisfiedTryBots-Pass
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I7df5c57e36e57c6309ce0fb0efd2d53bd9e06b76
      Gerrit-Change-Number: 801360
      Gerrit-PatchSet: 1
      Gerrit-Owner: Kinson Nee <kins...@gmail.com>
      Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
      Gerrit-Reviewer: Jorropo <jorro...@gmail.com>
      Gerrit-Reviewer: Meng Zhuo <mengzh...@gmail.com>
      Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
      Gerrit-CC: Joel Sing <jo...@sing.id.au>
      Gerrit-CC: Mark Ryan <mark...@meta.com>
      Gerrit-Attention: Kinson Nee <kins...@gmail.com>
      Gerrit-Attention: Jorropo <jorro...@gmail.com>
      Gerrit-Attention: Michael Pratt <mpr...@google.com>
      Gerrit-Comment-Date: Tue, 21 Jul 2026 21:39:45 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Meng Zhuo (Gerrit)

      unread,
      8:36 PM (2 hours ago) 8:36 PM
      to Kinson Nee, Meng Zhuo, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Carlos Amedee, Michael Pratt, Joel Sing, Mark Ryan, golang...@luci-project-accounts.iam.gserviceaccount.com, Jorropo, golang-co...@googlegroups.com

      Meng Zhuo submitted the change

      Change information

      Commit message:
      test/codegen: add riscv64 checks for conditional subtractions

      Add riscv64 asmcheck coverage for the conditional subtraction cases in condmove.go.

      Verify that rva20u64 and rva22u64 keep using the existing SNEZ/NEG/AND/OR sequence. Verify that rva23u64 uses CZERONEZ/CZEROEQZ/OR without the older fallback sequence.
      Co-authored-by: YuanSheng <yuan...@isrc.iscas.ac.cn>
      Change-Id: I7df5c57e36e57c6309ce0fb0efd2d53bd9e06b76
      Files:
      • M test/codegen/condmove.go
      Change size: XS
      Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
      Branch: refs/heads/master
      Submit Requirements:
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I7df5c57e36e57c6309ce0fb0efd2d53bd9e06b76
      Gerrit-Change-Number: 801360
      Gerrit-PatchSet: 2
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages