[go] net/http: fix link to ResponseWriter trailer example
Reilly Watson (Gerrit)
Reilly Watson has uploaded this change for review.
net/http: fix link to ResponseWriter trailer example
The links to this example were using an underscore separator
instead of a hyphen, and incorrect casing.
Fixes #50279
Change-Id: I35d76a8a78cd708b7505ff1a70f7dacddaf43efd
---
M src/net/http/server.go
M src/net/http/h2_bundle.go
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/src/net/http/h2_bundle.go b/src/net/http/h2_bundle.go
index bb82f24..0a1a2a9 100644
--- a/src/net/http/h2_bundle.go
+++ b/src/net/http/h2_bundle.go
@@ -6266,7 +6266,7 @@
// or known before the header is written, the normal Go trailers mechanism
// is preferred:
// https://golang.org/pkg/net/http/#ResponseWriter
-// https://golang.org/pkg/net/http/#example_ResponseWriter_trailers
+// https://golang.org/pkg/net/http/#example-ResponseWriter-Trailers
const http2TrailerPrefix = "Trailer:"
// promoteUndeclaredTrailers permits http.Handlers to set trailers
diff --git a/src/net/http/server.go b/src/net/http/server.go
index ddc799b..30eab49 100644
--- a/src/net/http/server.go
+++ b/src/net/http/server.go
@@ -495,7 +495,7 @@
// or known before the header is written, the normal Go trailers mechanism
// is preferred:
// https://golang.org/pkg/net/http/#ResponseWriter
-// https://golang.org/pkg/net/http/#example_ResponseWriter_trailers
+// https://golang.org/pkg/net/http/#example-ResponseWriter-Trailers
const TrailerPrefix = "Trailer:"
// finalTrailers is called after the Handler exits and returns a non-nil
To view, visit change 373514. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Reilly Watson, Damien Neil.
1 comment:
Patchset:
Thanks. As long as we are touching these lines, let's switch them to go.dev rather than golang.org. Thanks.
To view, visit change 373514. To unsubscribe, or for help writing mail filters, visit settings.
Reilly Watson (Gerrit)
Attention is currently required from: Reilly Watson, Damien Neil.
Reilly Watson uploaded patch set #2 to this change.
net/http: fix link to ResponseWriter trailer example
The links to this example were using an underscore separator
instead of a hyphen, and incorrect casing.
Fixes #50279
Change-Id: I35d76a8a78cd708b7505ff1a70f7dacddaf43efd
---
M src/net/http/server.go
M src/net/http/h2_bundle.go
2 files changed, 18 insertions(+), 4 deletions(-)
To view, visit change 373514. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Reilly Watson, Damien Neil.
1 comment:
Patchset:
Sorry, just noticed that you are changing h2_bundle.go. As it says at the top of the file, that file is generated and should not be edited directly.
To view, visit change 373514. To unsubscribe, or for help writing mail filters, visit settings.
Reilly Watson (Gerrit)
Attention is currently required from: Reilly Watson, Damien Neil.
Reilly Watson uploaded patch set #3 to this change.
net/http: fix link to ResponseWriter trailer example
The links to this example were using an underscore separator
instead of a hyphen, and incorrect casing.
Fixes #50279
Change-Id: I35d76a8a78cd708b7505ff1a70f7dacddaf43efd
---
M src/net/http/server.go
M src/net/http/h2_bundle.go
2 files changed, 17 insertions(+), 3 deletions(-)
To view, visit change 373514. To unsubscribe, or for help writing mail filters, visit settings.
Reilly Watson (Gerrit)
Attention is currently required from: Reilly Watson, Damien Neil.
Reilly Watson uploaded patch set #4 to this change.
net/http: fix link to ResponseWriter trailer example
The links to this example were using an underscore separator
instead of a hyphen, and incorrect casing.
Fixes #50279
Change-Id: I35d76a8a78cd708b7505ff1a70f7dacddaf43efd
---
M src/net/http/server.go
1 file changed, 16 insertions(+), 2 deletions(-)
To view, visit change 373514. To unsubscribe, or for help writing mail filters, visit settings.
Brad Fitzpatrick (Gerrit)
Attention is currently required from: Reilly Watson, Damien Neil.
1 comment:
File src/net/http/server.go:
Patch Set #4, Line 497:
// https://pkg.go.dev/net/http/#ResponseWriterremove the final /? I notice that https://pkg.go.dev/net/http/#ResponseWriter redirects to https://pkg.go.dev/net/http#ResponseWriter
To view, visit change 373514. To unsubscribe, or for help writing mail filters, visit settings.
Reilly Watson (Gerrit)
Attention is currently required from: Reilly Watson, Damien Neil.
Reilly Watson uploaded patch set #5 to this change.
net/http: fix link to ResponseWriter trailer example
The links to this example were using an underscore separator
instead of a hyphen, and incorrect casing.
Fixes #50279
Change-Id: I35d76a8a78cd708b7505ff1a70f7dacddaf43efd
---
M src/net/http/server.go
1 file changed, 16 insertions(+), 2 deletions(-)
To view, visit change 373514. To unsubscribe, or for help writing mail filters, visit settings.
Reilly Watson (Gerrit)
Attention is currently required from: Reilly Watson, Damien Neil.
Reilly Watson uploaded patch set #6 to this change.
net/http: fix link to ResponseWriter trailer example
The links to this example were using an underscore separator
instead of a hyphen, and incorrect casing.
Fixes #50279
Change-Id: I35d76a8a78cd708b7505ff1a70f7dacddaf43efd
---
M src/net/http/server.go
1 file changed, 16 insertions(+), 2 deletions(-)
To view, visit change 373514. To unsubscribe, or for help writing mail filters, visit settings.
Ian Lance Taylor (Gerrit)
Attention is currently required from: Reilly Watson, Brad Fitzpatrick, Damien Neil.
Patch set 6:Code-Review +2
2 comments:
Patchset:
Thanks.
File src/net/http/server.go:
remove the final /? I notice that https://pkg.go. […]
Done
To view, visit change 373514. To unsubscribe, or for help writing mail filters, visit settings.
Reilly Watson (Gerrit)
Attention is currently required from: Brad Fitzpatrick, Damien Neil.
3 comments:
Patchset:
Thanks. As long as we are touching these lines, let's switch them to go.dev rather than golang.org. […]
Makes sense, thanks! Updated.
Patchset:
Sorry, just noticed that you are changing h2_bundle.go. […]
Ah geez you're right, sorry about that! Good catch, updated.
File src/net/http/server.go:
Patch Set #4, Line 497:
// https://pkg.go.dev/net/http/#ResponseWriterremove the final /? I notice that https://pkg.go. […]
Ah so it does! Updated, thanks :)
To view, visit change 373514. To unsubscribe, or for help writing mail filters, visit settings.
Emmanuel Odeke (Gerrit)
Attention is currently required from: Reilly Watson, Brad Fitzpatrick, Damien Neil.
Patch set 6:Code-Review +2
1 comment:
Patchset:
Thank you for the fix Reilly! Thank you for the co-review, Ian!
To view, visit change 373514. To unsubscribe, or for help writing mail filters, visit settings.
Emmanuel Odeke (Gerrit)
Emmanuel Odeke submitted this change.
net/http: fix link to ResponseWriter trailer example
The links to this example were using an underscore separator
instead of a hyphen, and incorrect casing.
Fixes #50279
Change-Id: I35d76a8a78cd708b7505ff1a70f7dacddaf43efd
Reviewed-on: https://go-review.googlesource.com/c/go/+/373514
Reviewed-by: Ian Lance Taylor <ia...@golang.org>
Reviewed-by: Emmanuel Odeke <emma...@orijtech.com>
---
M src/net/http/server.go
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/src/net/http/server.go b/src/net/http/server.go
index ddc799b..ffb742b 100644
--- a/src/net/http/server.go
+++ b/src/net/http/server.go
@@ -494,8 +494,8 @@
// prior to the headers being written. If the set of trailers is fixed
// or known before the header is written, the normal Go trailers mechanism
// is preferred:
-// https://golang.org/pkg/net/http/#ResponseWriter
-// https://golang.org/pkg/net/http/#example_ResponseWriter_trailers
+// https://pkg.go.dev/net/http#ResponseWriter
+// https://pkg.go.dev/net/http#example-ResponseWriter-Trailers
const TrailerPrefix = "Trailer:"
// finalTrailers is called after the Handler exits and returns a non-nil
To view, visit change 373514. To unsubscribe, or for help writing mail filters, visit settings.