[go] os/exec: include Cmd.Start in the list of methods that run Cmd

2 views
Skip to first unread message

Sean Liao (Gerrit)

unread,
Nov 11, 2025, 4:09:22 PM (2 days ago) Nov 11
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Sean Liao has uploaded the change for review

Commit message

os/exec: include Cmd.Start in the list of methods that run Cmd

Fixes #76265
Change-Id: I451271c5662dd3bcdeec07b55761b15f64c00dcd

Change diff

diff --git a/src/os/exec/exec.go b/src/os/exec/exec.go
index 38354a5..e84ebfc 100644
--- a/src/os/exec/exec.go
+++ b/src/os/exec/exec.go
@@ -142,8 +142,8 @@
 
 // Cmd represents an external command being prepared or run.
 //
-// A Cmd cannot be reused after calling its [Cmd.Run], [Cmd.Output] or [Cmd.CombinedOutput]
-// methods.
+// A Cmd cannot be reused after calling its [Cmd.Start], [Cmd.Run],
+// [Cmd.Output], or [Cmd.CombinedOutput] methods.
 type Cmd struct {
 	// Path is the path of the command to run.
 	//

Change information

Files:
  • M src/os/exec/exec.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I451271c5662dd3bcdeec07b55761b15f64c00dcd
Gerrit-Change-Number: 719860
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Liao <se...@liao.dev>
Gerrit-Reviewer: Sean Liao <se...@liao.dev>
unsatisfied_requirement
satisfied_requirement
open
diffy

Keith Randall (Gerrit)

unread,
Nov 11, 2025, 4:17:40 PM (2 days ago) Nov 11
to goph...@pubsubhelper.golang.org, Keith Randall, Go LUCI, golang-co...@googlegroups.com
Attention needed from Sean Liao

Keith Randall voted

Auto-Submit+1
Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Sean Liao
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I451271c5662dd3bcdeec07b55761b15f64c00dcd
Gerrit-Change-Number: 719860
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Liao <se...@liao.dev>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Sean Liao <se...@liao.dev>
Gerrit-Attention: Sean Liao <se...@liao.dev>
Gerrit-Comment-Date: Tue, 11 Nov 2025 21:17:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Keith Randall (Gerrit)

unread,
Nov 11, 2025, 4:18:01 PM (2 days ago) Nov 11
to goph...@pubsubhelper.golang.org, Keith Randall, Go LUCI, golang-co...@googlegroups.com
Attention needed from Sean Liao

Keith Randall voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Sean Liao
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I451271c5662dd3bcdeec07b55761b15f64c00dcd
Gerrit-Change-Number: 719860
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Liao <se...@liao.dev>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@google.com>
Gerrit-Reviewer: Sean Liao <se...@liao.dev>
Gerrit-Attention: Sean Liao <se...@liao.dev>
Gerrit-Comment-Date: Tue, 11 Nov 2025 21:17:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alan Donovan (Gerrit)

unread,
Nov 12, 2025, 10:27:58 AM (16 hours ago) Nov 12
to goph...@pubsubhelper.golang.org, Go LUCI, Keith Randall, Keith Randall, golang-co...@googlegroups.com
Attention needed from Sean Liao

Alan Donovan voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Sean Liao
Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I451271c5662dd3bcdeec07b55761b15f64c00dcd
    Gerrit-Change-Number: 719860
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sean Liao <se...@liao.dev>
    Gerrit-Reviewer: Alan Donovan <adon...@google.com>
    Gerrit-Reviewer: Keith Randall <k...@golang.org>
    Gerrit-Reviewer: Keith Randall <k...@google.com>
    Gerrit-Reviewer: Sean Liao <se...@liao.dev>
    Gerrit-Attention: Sean Liao <se...@liao.dev>
    Gerrit-Comment-Date: Wed, 12 Nov 2025 15:27:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Alan Donovan (Gerrit)

    unread,
    Nov 12, 2025, 10:28:03 AM (16 hours ago) Nov 12
    to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Keith Randall, Keith Randall, golang-co...@googlegroups.com

    Alan Donovan submitted the change

    Change information

    Commit message:
    os/exec: include Cmd.Start in the list of methods that run Cmd

    Fixes #76265
    Change-Id: I451271c5662dd3bcdeec07b55761b15f64c00dcd
    Reviewed-by: Keith Randall <k...@golang.org>
    Reviewed-by: Alan Donovan <adon...@google.com>
    Auto-Submit: Keith Randall <k...@golang.org>
    Reviewed-by: Keith Randall <k...@google.com>
    Files:
    • M src/os/exec/exec.go
    Change size: XS
    Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
    Branch: refs/heads/master
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Keith Randall, +2 by Alan Donovan, +2 by Keith Randall
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I451271c5662dd3bcdeec07b55761b15f64c00dcd
    Gerrit-Change-Number: 719860
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages