[go] cmd/compile/ssa/_gen: add prep code for split op
10 views
Skip to first unread message
Michael Matloob (Gerrit)
Jul 21, 2026, 3:46:46 PMJul 21
to goph...@pubsubhelper.golang.org, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Keith Randall
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 21, 2026, 3:55:58 PMJul 21
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Keith Randall and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Attention is currently required from:
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 21, 2026, 4:20:46 PMJul 21
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Keith Randall and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #7 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 21, 2026, 10:39:46 PMJul 21
to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, golang-co...@googlegroups.com
Attention needed from Keith Randall and Michael Matloob
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 23, 2026, 9:05:43 AMJul 23
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Keith Randall, Michael Matloob and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #8 to this change.
Following approvals got outdated and were removed:
- Code-Review: +1 by Michael Matloob
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Keith Randall
- Michael Matloob
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 23, 2026, 12:21:09 PMJul 23
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Keith Randall, Michael Matloob and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #9 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Keith Randall
- Michael Matloob
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 23, 2026, 12:31:32 PMJul 23
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, Keith Randall, golang-co...@googlegroups.com
Attention needed from Keith Randall and Michael Matloob
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 23, 2026, 1:44:36 PMJul 23
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Keith Randall and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #10 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 23, 2026, 1:45:06 PMJul 23
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, Keith Randall, golang-co...@googlegroups.com
Attention needed from Keith Randall and Michael Matloob
Michael Matloob voted Code-Review+0![]( "Open in Gerrit")
| Code-Review | +0 |
Related details
Attention is currently required from:
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 23, 2026, 2:46:16 PMJul 23
to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, golang-co...@googlegroups.com
Attention needed from Keith Randall and Michael Matloob
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 26, 2026, 7:27:49 PMJul 26
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Keith Randall, Michael Matloob and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #11 to this change.
Following approvals got outdated and were removed:
- Code-Review: +1 by Michael Matloob
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Keith Randall
- Michael Matloob
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 27, 2026, 11:13:13 AMJul 27
to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, golang-co...@googlegroups.com
Attention needed from Keith Randall and Michael Matloob
Michael Matloob voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 27, 2026, 12:49:20 PMJul 27
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Keith Randall and Michael Matloob
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #12 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Keith Randall
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keith Randall (Gerrit)
Jul 27, 2026, 5:15:12 PMJul 27
to Michael Matloob, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, Keith Randall, golang-co...@googlegroups.com
Attention needed from Michael Matloob
Keith Randall added 2 comments![]( "Open in Gerrit")
File src/cmd/compile/internal/ssa/_gen/main.go
Line 47, Patchset 12 (Latest):
func simpleTitle(s string) string { return strings.ToUpper(s[:1]) + s[1:] } // Unlike title, only title the first letter of the string.Keith Randall . unresolved
Can't we just do this unconditionally as a prep step?
This is in cmd/compile/internal, so we're not exposing anything.
File src/cmd/compile/internal/ssa/_gen/rulegen.go
Line 1094, Patchset 12 (Latest):
eName := e.nameKeith Randall . unresolved
Why is something like this necessary?
Related details
Attention is currently required from:
- Michael Matloob
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 27, 2026, 5:24:31 PMJul 27
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, Keith Randall, golang-co...@googlegroups.com
Attention needed from Keith Randall
Michael Matloob added 2 comments![]( "Open in Gerrit")
File src/cmd/compile/internal/ssa/_gen/main.go
Line 47, Patchset 12:
func simpleTitle(s string) string { return strings.ToUpper(s[:1]) + s[1:] } // Unlike title, only title the first letter of the string.Keith Randall . unresolved
Can't we just do this unconditionally as a prep step?
This is in cmd/compile/internal, so we're not exposing anything.
Michael Matloob
We need to update all the users
File src/cmd/compile/internal/ssa/_gen/rulegen.go
Line 1094, Patchset 12:
eName := e.nameKeith Randall . unresolved
Why is something like this necessary?
Michael Matloob
Oh I think this was left over from something that I removed earlier. (I made some more changes to this during the weekend and must have missed this in the cleanup)
Related details
Attention is currently required from:
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 27, 2026, 5:24:32 PMJul 27
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Keith Randall
Michael Matloob uploaded new patchset![]( "Open in Gerrit")
Michael Matloob uploaded patch set #13 to this change.
Following approvals got outdated and were removed:
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michael Matloob (Gerrit)
Jul 27, 2026, 5:28:25 PMJul 27
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, Keith Randall, golang-co...@googlegroups.com
Attention needed from Keith Randall
Michael Matloob added 1 comment![]( "Open in Gerrit")
File src/cmd/compile/internal/ssa/_gen/main.go
Line 47, Patchset 12:
func simpleTitle(s string) string { return strings.ToUpper(s[:1]) + s[1:] } // Unlike title, only title the first letter of the string.Keith Randall . unresolved
Michael MatloobCan't we just do this unconditionally as a prep step?
This is in cmd/compile/internal, so we're not exposing anything.
We need to update all the users
Michael Matloob
(Incomplete comment was posted when I mailed)
Do you mean to unconditionally export everything that we need to export? We could do that but that would mean adding another rf change to export the identifiers that's separate from the changes that move them to different package.
Related details
Attention is currently required from:
- Keith Randall
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages