[go] cmd/compile: allow halt flag to run concurrently

0 views
Skip to first unread message

Daniel Morsing (Gerrit)

unread,
5:38 AM (8 hours ago) 5:38 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Daniel Morsing has uploaded the change for review

Commit message

cmd/compile: allow halt flag to run concurrently

During the investigation for #78081, I found it helpful to use the -h
flag to get a compiler core dump. I don't see any reason why it would
need to clamp concurrency down. We have pretty good support for not
interleaving log lines and if people really need it, they can always
pass -c=1.
Change-Id: Ic6425fc0da63e7ac42e0821f3d40ec4c6a6a6964

Change diff

diff --git a/src/cmd/compile/internal/base/flag.go b/src/cmd/compile/internal/base/flag.go
index 6898523..c8f1b2d 100644
--- a/src/cmd/compile/internal/base/flag.go
+++ b/src/cmd/compile/internal/base/flag.go
@@ -475,7 +475,6 @@
 		Flag.E == 0 &&
 		Flag.K == 0 &&
 		Flag.L == 0 &&
-		Flag.LowerH == 0 &&
 		Flag.LowerJ == 0 &&
 		Flag.LowerM == 0 &&
 		Flag.LowerR == 0

Change information

Files:
  • M src/cmd/compile/internal/base/flag.go
Change size: XS
Delta: 1 file changed, 0 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ic6425fc0da63e7ac42e0821f3d40ec4c6a6a6964
Gerrit-Change-Number: 756321
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Morsing <daniel....@gmail.com>
unsatisfied_requirement
satisfied_requirement
open
diffy

Daniel Morsing (Gerrit)

unread,
5:40 AM (8 hours ago) 5:40 AM
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Daniel Morsing voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
  • requirement is not satisfiedTryBots-Pass
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ic6425fc0da63e7ac42e0821f3d40ec4c6a6a6964
Gerrit-Change-Number: 756321
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Morsing <daniel....@gmail.com>
Gerrit-Reviewer: Daniel Morsing <daniel....@gmail.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 09:39:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Cherry Mui (Gerrit)

unread,
10:14 AM (4 hours ago) 10:14 AM
to Daniel Morsing, goph...@pubsubhelper.golang.org, David Chase, Go LUCI, Robert Griesemer, Keith Randall, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com
Attention needed from Daniel Morsing, David Chase, Keith Randall, Martin Möhrmann and Robert Griesemer

Cherry Mui voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Morsing
  • David Chase
  • Keith Randall
  • Martin Möhrmann
  • Robert Griesemer
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ic6425fc0da63e7ac42e0821f3d40ec4c6a6a6964
    Gerrit-Change-Number: 756321
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Morsing <daniel....@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Daniel Morsing <daniel....@gmail.com>
    Gerrit-Reviewer: David Chase <drc...@google.com>
    Gerrit-Reviewer: Keith Randall <k...@golang.org>
    Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
    Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Keith Randall <k...@golang.org>
    Gerrit-Attention: David Chase <drc...@google.com>
    Gerrit-Attention: Martin Möhrmann <moeh...@google.com>
    Gerrit-Attention: Robert Griesemer <g...@golang.org>
    Gerrit-Attention: Daniel Morsing <daniel....@gmail.com>
    Gerrit-Comment-Date: Wed, 18 Mar 2026 14:14:37 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Robert Griesemer (Gerrit)

    unread,
    12:14 PM (2 hours ago) 12:14 PM
    to Daniel Morsing, goph...@pubsubhelper.golang.org, David Chase, Cherry Mui, Go LUCI, Robert Griesemer, Keith Randall, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com
    Attention needed from Daniel Morsing, David Chase, Keith Randall, Martin Möhrmann and Robert Griesemer

    Robert Griesemer voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Morsing
    • David Chase
    • Keith Randall
    • Martin Möhrmann
    • Robert Griesemer
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    • requirement satisfiedTryBots-Pass
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ic6425fc0da63e7ac42e0821f3d40ec4c6a6a6964
    Gerrit-Change-Number: 756321
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Morsing <daniel....@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Daniel Morsing <daniel....@gmail.com>
    Gerrit-Reviewer: David Chase <drc...@google.com>
    Gerrit-Reviewer: Keith Randall <k...@golang.org>
    Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
    Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
    Gerrit-Reviewer: Robert Griesemer <g...@google.com>
    Gerrit-CC: Gopher Robot <go...@golang.org>
    Gerrit-Attention: Keith Randall <k...@golang.org>
    Gerrit-Attention: David Chase <drc...@google.com>
    Gerrit-Attention: Martin Möhrmann <moeh...@google.com>
    Gerrit-Attention: Robert Griesemer <g...@golang.org>
    Gerrit-Attention: Daniel Morsing <daniel....@gmail.com>
    Gerrit-Comment-Date: Wed, 18 Mar 2026 16:14:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Gopher Robot (Gerrit)

    unread,
    12:17 PM (2 hours ago) 12:17 PM
    to Daniel Morsing, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Robert Griesemer, David Chase, Cherry Mui, Go LUCI, Robert Griesemer, Keith Randall, Martin Möhrmann, golang-co...@googlegroups.com

    Gopher Robot submitted the change

    Change information

    Commit message:
    cmd/compile: allow halt flag to run concurrently

    During the investigation for #78081, I found it helpful to use the -h
    flag to get a compiler core dump. I don't see any reason why it would
    need to clamp concurrency down. We have pretty good support for not
    interleaving log lines and if people really need it, they can always
    pass -c=1.
    Change-Id: Ic6425fc0da63e7ac42e0821f3d40ec4c6a6a6964
    Reviewed-by: Cherry Mui <cher...@google.com>
    Auto-Submit: Daniel Morsing <daniel....@gmail.com>
    Reviewed-by: Robert Griesemer <g...@google.com>
    Files:
    • M src/cmd/compile/internal/base/flag.go
    Change size: XS
    Delta: 1 file changed, 0 insertions(+), 1 deletion(-)
    Branch: refs/heads/master
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Cherry Mui, +2 by Robert Griesemer
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: Ic6425fc0da63e7ac42e0821f3d40ec4c6a6a6964
    Gerrit-Change-Number: 756321
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Morsing <daniel....@gmail.com>
    Gerrit-Reviewer: Cherry Mui <cher...@google.com>
    Gerrit-Reviewer: Daniel Morsing <daniel....@gmail.com>
    Gerrit-Reviewer: David Chase <drc...@google.com>
    Gerrit-Reviewer: Gopher Robot <go...@golang.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages