[vuln] fix type name in comment
Gerrit Bot (Gerrit)
Gerrit Bot has uploaded this change for review.
fix type name in comment
Change-Id: I348d3c315b69cf6ac2f8536414d41d4b9bf44bd0
GitHub-Last-Rev: a3d8dad6701cbfb35349f1c1e8469a6b1238ecda
GitHub-Pull-Request: golang/vuln#8
---
M internal/osv/osv.go
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/internal/osv/osv.go b/internal/osv/osv.go
index 3fa3a08..5b7e892 100644
--- a/internal/osv/osv.go
+++ b/internal/osv/osv.go
@@ -97,7 +97,7 @@
Events []RangeEvent `json:"events"`
}
-// Reference type is a reference (link) type.
+// ReferenceType is a reference (link) type.
type ReferenceType string
const (
To view, visit change 551135. To unsubscribe, or for help writing mail filters, visit settings.
Gopher Robot (Gerrit)
1 comment:
Patchset:
I spotted some possible problems.
These findings are based on simple heuristics. If a finding appears wrong, briefly reply here saying so. Otherwise, please address any problems and update the GitHub PR. When complete, mark this comment as 'Done' and click the [blue 'Reply' button](https://go.dev/wiki/GerritBot#i-left-a-reply-to-a-comment-in-gerrit-but-no-one-but-me-can-see-it) above.
Possible problems detected:
1. The commit title should start with the primary affected package name followed by a colon, like "net/http: improve [...]".
2. The first word in the commit title after the package should be a lowercase English word (usually a verb).The commit title and commit message body come from the GitHub PR title and description, and must be edited in the GitHub web interface (not via git). For instructions, see [here](https://go.dev/wiki/GerritBot/#how-does-gerritbot-determine-the-final-commit-message). For guidelines on commit messages for the Go project, see [here](https://go.dev/doc/contribute#commit_messages).
(In general for Gerrit code reviews, the change author is expected to [log in to Gerrit](https://go-review.googlesource.com/login/) with a Gmail or other Google account and then close out each piece of feedback by marking it as 'Done' if implemented as suggested or otherwise reply to each review comment. See the [Review](https://go.dev/doc/contribute#review) section of the Contributing Guide for details.)
To view, visit change 551135. To unsubscribe, or for help writing mail filters, visit settings.
Robert Griesemer (Gerrit)
Attention is currently required from: Tatiana Bradley.
1 comment:
Commit Message:
this should be:
internal/osv: fix type name in comment
To view, visit change 551135. To unsubscribe, or for help writing mail filters, visit settings.
Tatiana Bradley (Gerrit)
Patch set 1:Code-Review +2
Gerrit Bot (Gerrit)
Attention is currently required from: Tatiana Bradley, shuang cui.
Gerrit Bot uploaded patch set #2 to this change.
internal/osv: fix type name in comment
Change-Id: I348d3c315b69cf6ac2f8536414d41d4b9bf44bd0
GitHub-Last-Rev: a3d8dad6701cbfb35349f1c1e8469a6b1238ecda
GitHub-Pull-Request: golang/vuln#8
---
M internal/osv/osv.go
1 file changed, 1 insertion(+), 1 deletion(-)
To view, visit change 551135. To unsubscribe, or for help writing mail filters, visit settings.
shuang cui (Gerrit)
Attention is currently required from: Robert Griesemer, Tatiana Bradley.
Patch set 2:Run-TryBot +1
1 comment:
Commit Message:
this should be: […]
fixed, thanks
To view, visit change 551135. To unsubscribe, or for help writing mail filters, visit settings.
shuang cui (Gerrit)
Attention is currently required from: Robert Griesemer, Tatiana Bradley.
To view, visit change 551135. To unsubscribe, or for help writing mail filters, visit settings.
Tim King (Gerrit)
Attention is currently required from: Robert Griesemer, Tatiana Bradley.
Patch set 2:Code-Review +1
Tim King (Gerrit)
Tim King submitted this change.
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
internal/osv: fix type name in comment
Change-Id: I348d3c315b69cf6ac2f8536414d41d4b9bf44bd0
GitHub-Last-Rev: a3d8dad6701cbfb35349f1c1e8469a6b1238ecda
GitHub-Pull-Request: golang/vuln#8
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/551135
Reviewed-by: Tim King <tak...@google.com>
TryBot-Result: Gopher Robot <go...@golang.org>
Reviewed-by: Tatiana Bradley <tatiana...@google.com>
Run-TryBot: shuang cui <imc...@gmail.com>
---
M internal/osv/osv.go
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/internal/osv/osv.go b/internal/osv/osv.go
index 3fa3a08..5b7e892 100644
--- a/internal/osv/osv.go
+++ b/internal/osv/osv.go
@@ -97,7 +97,7 @@
Events []RangeEvent `json:"events"`
}
-// Reference type is a reference (link) type.
+// ReferenceType is a reference (link) type.
type ReferenceType string
const (
To view, visit change 551135. To unsubscribe, or for help writing mail filters, visit settings.