Egon Elbre (Gerrit)

unread,

May 23, 2023, 6:20:58 AM5/23/23

to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Set Ready For Review

View Change

To view, visit change 495878. To unsubscribe, or for help writing mail filters, visit settings.

Egon Elbre (Gerrit)

unread,

May 23, 2023, 6:23:45 AM5/23/23

to goph...@pubsubhelper.golang.org, Keith Randall, Matthew Dempsky, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com

Attention is currently required from: Keith Randall, Martin Möhrmann, Matthew Dempsky.

View Change

2 comments:

Commit Message:
- Patch Set #4, Line 19: Some benchmarks from json, fmt, runtime, strings packages:
  The full benchmark data of the chain is in https://gist.github.com/egonelbre/34efef3f5c4aef2035396a2f0a90cc96
- Patch Set #4, Line 106: SplitNMultiByteSeparator-32 212.9n ± 1% 260.2n ± 1% +22.19% (p=0.000 n=10)
  I'll need to investigate what's going on here. Whether it's code layout, or some other reason.

To view, visit change 495878. To unsubscribe, or for help writing mail filters, visit settings.

Egon Elbre (Gerrit)

unread,

May 23, 2023, 6:31:10 AM5/23/23

to goph...@pubsubhelper.golang.org, Keith Randall, Matthew Dempsky, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com

Attention is currently required from: Keith Randall, Martin Möhrmann, Matthew Dempsky.

View Change

1 comment:

File src/cmd/compile/internal/ssa/_gen/generic.rules:
- Patch Set #4, Line 2621: (SliceLen (SelectN [0] (StaticLECall {sym} _ newLen:(Const(64|32)) _ _ _))) && isSameCall(sym, "runtime.growslicebyte") => newLen
  I was wondering whether it would be use the rules to create the specialization rather than some other approach?
  Something like:
```
```
  (StaticCall {sym} oldPtr newLen oldCap num elemtype)) &&
  	isSameCall(sym, "runtime.growslice") &&
  	elemtype.Size() == 1 &&
  	elemtype.PtrBytes = 0
  	=> (StaticCall ??"runtime.growslicebyte"?? oldPtr newLen oldCap num)
```
```
  Or whether this would be better than doing in `rewritegeneric`.

To view, visit change 495878. To unsubscribe, or for help writing mail filters, visit settings.

Keith Randall (Gerrit)

unread,

May 23, 2023, 1:08:03 PM5/23/23

to Egon Elbre, goph...@pubsubhelper.golang.org, Keith Randall, Matthew Dempsky, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com

Attention is currently required from: Egon Elbre, Martin Möhrmann, Matthew Dempsky.

Patch set 4:Code-Review +2

View Change

4 comments:

File src/cmd/compile/internal/ssa/_gen/generic.rules:

- Patch Set #4, Line 2621: (SliceLen (SelectN [0] (StaticLECall {sym} _ newLen:(Const(64|32)) _ _ _))) && isSameCall(sym, "runtime.growslicebyte") => newLen

- I was wondering whether it would be use the rules to create the specialization rather than some othe […]
  I think the way you are doing it is fine. There's no need to do it in rewrite rules if the choice is obvious when originally generating the SSA.
  (It would be different if we were generating calls to growslice as part of some SSA passes, but I don't think that's the case.)
File src/cmd/compile/internal/ssagen/ssa.go:
- Patch Set #4, Line 3467: && !et.HasPointers()
  This is redundant, 1-byte types can't have pointers.
File src/cmd/compile/internal/walk/builtin.go:
- Patch Set #4, Line 133: && !elemtype.HasPointers()
  same here.
File src/runtime/slice.go:
- Patch Set #4, Line 189: case et.Size_ == 1:
  Probably leave a comment here, saying 1-byte grows should be using growslicebyte instead.

To view, visit change 495878. To unsubscribe, or for help writing mail filters, visit settings.

Keith Randall (Gerrit)

unread,

May 23, 2023, 1:12:31 PM5/23/23

to Egon Elbre, goph...@pubsubhelper.golang.org, Keith Randall, Matthew Dempsky, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com

Attention is currently required from: Egon Elbre, Martin Möhrmann, Matthew Dempsky.

Patch set 4:Code-Review +1

View Change

To view, visit change 495878. To unsubscribe, or for help writing mail filters, visit settings.

Matthew Dempsky (Gerrit)

unread,

May 23, 2023, 4:09:25 PM5/23/23

to Egon Elbre, goph...@pubsubhelper.golang.org, Keith Randall, Keith Randall, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com

Attention is currently required from: Egon Elbre, Martin Möhrmann.

Patch set 4:Code-Review +1

View Change

To view, visit change 495878. To unsubscribe, or for help writing mail filters, visit settings.

Egon Elbre (Gerrit)

unread,

Aug 11, 2026, 10:29:58 AM (17 hours ago) Aug 11

to goph...@pubsubhelper.golang.org, Matthew Dempsky, Keith Randall, Keith Randall, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com

Attention needed from Keith Randall, Keith Randall, Martin Möhrmann and Matthew Dempsky

Egon Elbre added 3 comments

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Egon Elbre . resolved

PTAL, based on comments from []string change, I ended up sharing the grow 32 and grow 64 logic here.

Commit Message

Line 19, Patchset 4:Some benchmarks from json, fmt, runtime, strings packages:

Egon Elbre . resolved

The full benchmark data of the chain is in https://gist.github.com/egonelbre/34efef3f5c4aef2035396a2f0a90cc96

Egon Elbre

outdated

Line 106, Patchset 4:SplitNMultiByteSeparator-32 212.9n ± 1% 260.2n ± 1% +22.19% (p=0.000 n=10)

Egon Elbre . resolved

I'll need to investigate what's going on here. Whether it's code layout, or some other reason.

Egon Elbre

outdated

Open in Gerrit

Related details

Attention is currently required from:

Keith Randall
Keith Randall
Martin Möhrmann
Matthew Dempsky

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

t hepudds (Gerrit)

unread,

Aug 11, 2026, 1:16:57 PM (14 hours ago) Aug 11

to Egon Elbre, goph...@pubsubhelper.golang.org, Matthew Dempsky, Keith Randall, Keith Randall, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com

Attention needed from Egon Elbre, Keith Randall, Keith Randall, Martin Möhrmann and Matthew Dempsky

t hepudds voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Egon Elbre

Keith Randall
Keith Randall
Martin Möhrmann
Matthew Dempsky

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Egon Elbre (Gerrit)

unread,

Aug 11, 2026, 2:50:05 PM (13 hours ago) Aug 11

to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention needed from Egon Elbre, Keith Randall, Keith Randall, Martin Möhrmann, Matthew Dempsky and t hepudds

Egon Elbre uploaded new patchset

Egon Elbre uploaded patch set #13 to this change.

Following approvals got outdated and were removed:

TryBots-Pass: LUCI-TryBot-Result-1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Related details

Attention is currently required from:

Egon Elbre
Keith Randall
Keith Randall
Martin Möhrmann
Matthew Dempsky

t hepudds

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Egon Elbre (Gerrit)

unread,

Aug 11, 2026, 2:51:01 PM (13 hours ago) Aug 11

to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, t hepudds, Matthew Dempsky, Keith Randall, Keith Randall, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com

Attention needed from Keith Randall, Keith Randall, Martin Möhrmann, Matthew Dempsky and t hepudds

Egon Elbre voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Keith Randall
Keith Randall
Martin Möhrmann
Matthew Dempsky
t hepudds

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Egon Elbre (Gerrit)

unread,

12:00 AM (3 hours ago) 12:00 AM

to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention needed from Egon Elbre, Keith Randall, Keith Randall, Martin Möhrmann, Matthew Dempsky and t hepudds

Egon Elbre uploaded new patchset

Egon Elbre uploaded patch set #14 to this change.

Following approvals got outdated and were removed:

TryBots-Pass: LUCI-TryBot-Result-1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Related details

Attention is currently required from:

Egon Elbre

Keith Randall
Keith Randall
Martin Möhrmann
Matthew Dempsky
t hepudds

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Egon Elbre (Gerrit)

unread,

12:01 AM (3 hours ago) 12:01 AM

to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, t hepudds, Matthew Dempsky, Keith Randall, Keith Randall, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com

Attention needed from Keith Randall, Keith Randall, Martin Möhrmann, Matthew Dempsky and t hepudds

Egon Elbre voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Keith Randall
Keith Randall
Martin Möhrmann
Matthew Dempsky
t hepudds

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Egon Elbre (Gerrit)

unread,

12:24 AM (3 hours ago) 12:24 AM

to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Attention needed from Egon Elbre, Keith Randall, Keith Randall, Martin Möhrmann, Matthew Dempsky and t hepudds

Egon Elbre uploaded new patchset

Egon Elbre uploaded patch set #15 to this change.

Following approvals got outdated and were removed:

TryBots-Pass: LUCI-TryBot-Result-1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Related details

Attention is currently required from:

Egon Elbre

Keith Randall
Keith Randall
Martin Möhrmann
Matthew Dempsky
t hepudds

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Egon Elbre (Gerrit)

unread,

12:24 AM (3 hours ago) 12:24 AM

to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, t hepudds, Matthew Dempsky, Keith Randall, Keith Randall, Martin Möhrmann, Gopher Robot, golang-co...@googlegroups.com

Attention needed from Keith Randall, Keith Randall, Martin Möhrmann, Matthew Dempsky and t hepudds

Egon Elbre voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Keith Randall
Keith Randall
Martin Möhrmann
Matthew Dempsky
t hepudds

Submit Requirements:

Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

unsatisfied_requirement

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[go] runtime,cmd/compile: specialize growslice for bytes

Egon Elbre (Gerrit)

Egon Elbre (Gerrit)

Egon Elbre (Gerrit)

Keith Randall (Gerrit)

Keith Randall (Gerrit)

Matthew Dempsky (Gerrit)

Egon Elbre (Gerrit)

Egon Elbre added 3 comments

Related details

t hepudds (Gerrit)

t hepudds voted Commit-Queue+1

Related details

Egon Elbre (Gerrit)

Egon Elbre uploaded new patchset

Related details

Egon Elbre (Gerrit)

Egon Elbre voted Commit-Queue+1

Related details

Egon Elbre (Gerrit)

Egon Elbre uploaded new patchset

Related details

Egon Elbre (Gerrit)

Egon Elbre voted Commit-Queue+1

Related details

Egon Elbre (Gerrit)

Egon Elbre uploaded new patchset

Related details

Egon Elbre (Gerrit)

Egon Elbre voted Commit-Queue+1

Related details