[go] simd: make function comment match function name
5 views
Skip to first unread message
shuang cui (Gerrit)
Jul 6, 2026, 10:56:39 AMJul 6
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
shuang cui has uploaded the change for review![]( "Open in Gerrit")
Commit message
simd: make function comment match function name
Change-Id: Ia474eb19df92cfdb4122564a87a9837b4ff03348
Change diff
diff --git a/src/simd/internal/bridge/simd_emulated.go b/src/simd/internal/bridge/simd_emulated.go
index b6d0d72..440446d 100644
--- a/src/simd/internal/bridge/simd_emulated.go
+++ b/src/simd/internal/bridge/simd_emulated.go
@@ -12,7 +12,7 @@
"math/bits"
)
-// VectorSize returns the bit length of the emulated vector (fixed to 128).
+// VectorBitSize returns the bit length of the emulated vector (fixed to 128).
func VectorBitSize() int {
return 128
}
@@ -3210,65 +3210,65 @@
by16 = 0x0001000100010001
)
-// BroadcastInt8 fills the elements of a slice with its argument value.
+// BroadcastInt8s fills the elements of a slice with its argument value.
func BroadcastInt8s(x int8) Int8s {
v := (255 & uint64(x)) * by8
return Int8s{a: v, b: v}
}
-// BroadcastInt16 fills the elements of a slice with its argument value.
+// BroadcastInt16s fills the elements of a slice with its argument value.
func BroadcastInt16s(x int16) Int16s {
v := (65535 & uint64(x)) * by16
return Int16s{a: v, b: v}
}
-// BroadcastInt32 fills the elements of a slice with its argument value.
+// BroadcastInt32s fills the elements of a slice with its argument value.
func BroadcastInt32s(x int32) Int32s {
v := uint64(x) & 0xffffffff
v = v<<32 | v
return Int32s{a: v, b: v}
}
-// BroadcastInt64 fills the elements of a slice with its argument value.
+// BroadcastInt64s fills the elements of a slice with its argument value.
func BroadcastInt64s(x int64) Int64s {
v := uint64(x)
return Int64s{a: v, b: v}
}
-// BroadcastUint8 fills the elements of a slice with its argument value.
+// BroadcastUint8s fills the elements of a slice with its argument value.
func BroadcastUint8s(x uint8) Uint8s {
v := uint64(x) * by8
return Uint8s{a: v, b: v}
}
-// BroadcastUint16 fills the elements of a slice with its argument value.
+// BroadcastUint16s fills the elements of a slice with its argument value.
func BroadcastUint16s(x uint16) Uint16s {
v := uint64(x) * by16
return Uint16s{a: v, b: v}
}
-// BroadcastUint32 fills the elements of a slice with its argument value.
+// BroadcastUint32s fills the elements of a slice with its argument value.
func BroadcastUint32s(x uint32) Uint32s {
v := uint64(x)
v = v<<32 | v
return Uint32s{a: v, b: v}
}
-// BroadcastUint64 fills the elements of a slice with its argument value.
+// BroadcastUint64s fills the elements of a slice with its argument value.
func BroadcastUint64s(x uint64) Uint64s {
return Uint64s{a: x, b: x}
}
-// BroadcastFloat32 fills the elements of a slice with its argument value.
+// BroadcastFloat32s fills the elements of a slice with its argument value.
func BroadcastFloat32s(x float32) Float32s {
v := uint64(math.Float32bits(x))
v = v<<32 | v
return Float32s{a: v, b: v}
}
-// BroadcastFloat64 fills the elements of a slice with its argument value.
+// BroadcastFloat64s fills the elements of a slice with its argument value.
func BroadcastFloat64s(x float64) Float64s {
v := math.Float64bits(x)
return Float64s{a: v, b: v}
diff --git a/src/simd/ip_test.go b/src/simd/ip_test.go
index b88c499..cd16893 100644
--- a/src/simd/ip_test.go
+++ b/src/simd/ip_test.go
@@ -170,7 +170,7 @@
return z
}
-// BenchmarkIPnosimd1 is serial, just a vanilla inner product.
+// BenchmarkIPnosimd0 is serial, just a vanilla inner product.
func BenchmarkIPnosimd0(b *testing.B) {
x := make([]float32, ipBenchLen)
y := make([]float32, ipBenchLen)
diff --git a/src/simd/simd_emulated.go b/src/simd/simd_emulated.go
index 3737297..4bee6a1 100644
--- a/src/simd/simd_emulated.go
+++ b/src/simd/simd_emulated.go
@@ -12,7 +12,7 @@
"math/bits"
)
-// VectorSize returns the bit length of the emulated vector (fixed to 128).
+// VectorBitSize returns the bit length of the emulated vector (fixed to 128).
func VectorBitSize() int {
return 128
}
@@ -3210,65 +3210,65 @@
by16 = 0x0001000100010001
)
-// BroadcastInt8 fills the elements of a slice with its argument value.
+// BroadcastInt8s fills the elements of a slice with its argument value.
func BroadcastInt8s(x int8) Int8s {
v := (255 & uint64(x)) * by8
return Int8s{a: v, b: v}
}
-// BroadcastInt16 fills the elements of a slice with its argument value.
+// BroadcastInt16s fills the elements of a slice with its argument value.
func BroadcastInt16s(x int16) Int16s {
v := (65535 & uint64(x)) * by16
return Int16s{a: v, b: v}
}
-// BroadcastInt32 fills the elements of a slice with its argument value.
+// BroadcastInt32s fills the elements of a slice with its argument value.
func BroadcastInt32s(x int32) Int32s {
v := uint64(x) & 0xffffffff
v = v<<32 | v
return Int32s{a: v, b: v}
}
-// BroadcastInt64 fills the elements of a slice with its argument value.
+// BroadcastInt64s fills the elements of a slice with its argument value.
func BroadcastInt64s(x int64) Int64s {
v := uint64(x)
return Int64s{a: v, b: v}
}
-// BroadcastUint8 fills the elements of a slice with its argument value.
+// BroadcastUint8s fills the elements of a slice with its argument value.
func BroadcastUint8s(x uint8) Uint8s {
v := uint64(x) * by8
return Uint8s{a: v, b: v}
}
-// BroadcastUint16 fills the elements of a slice with its argument value.
+// BroadcastUint16s fills the elements of a slice with its argument value.
func BroadcastUint16s(x uint16) Uint16s {
v := uint64(x) * by16
return Uint16s{a: v, b: v}
}
-// BroadcastUint32 fills the elements of a slice with its argument value.
+// BroadcastUint32s fills the elements of a slice with its argument value.
func BroadcastUint32s(x uint32) Uint32s {
v := uint64(x)
v = v<<32 | v
return Uint32s{a: v, b: v}
}
-// BroadcastUint64 fills the elements of a slice with its argument value.
+// BroadcastUint64s fills the elements of a slice with its argument value.
func BroadcastUint64s(x uint64) Uint64s {
return Uint64s{a: x, b: x}
}
-// BroadcastFloat32 fills the elements of a slice with its argument value.
+// BroadcastFloat32s fills the elements of a slice with its argument value.
func BroadcastFloat32s(x float32) Float32s {
v := uint64(math.Float32bits(x))
v = v<<32 | v
return Float32s{a: v, b: v}
}
-// BroadcastFloat64 fills the elements of a slice with its argument value.
+// BroadcastFloat64s fills the elements of a slice with its argument value.
func BroadcastFloat64s(x float64) Float64s {
v := math.Float64bits(x)
return Float64s{a: v, b: v}
diff --git a/src/simd/simd_stubs.go b/src/simd/simd_stubs.go
index 5206290..25ed1a8 100644
--- a/src/simd/simd_stubs.go
+++ b/src/simd/simd_stubs.go
@@ -833,13 +833,13 @@
// Xor returns the bitwise XOR of x and y.
func (x Uint64s) Xor(y Uint64s) Uint64s
-// LoadFloat32 loads a slice of float32 into an Float32s vector.
+// LoadFloat32s loads a slice of float32 into an Float32s vector.
func LoadFloat32s([]float32) Float32s
-// LoadFloat32Part loads a partial slice of float32 into an Float32s vector, returning the vector and the number of elements loaded.
+// LoadFloat32sPart loads a partial slice of float32 into an Float32s vector, returning the vector and the number of elements loaded.
func LoadFloat32sPart([]float32) (Float32s, int)
-// BroadcastFloat32 fills the elements of a slice with its argument value.
+// BroadcastFloat32s fills the elements of a slice with its argument value.
func BroadcastFloat32s(float32) Float32s
// Abs returns the element-wise absolute value of x.
@@ -914,13 +914,13 @@
// ToBits reinterprets the vector bits as an unsigned integer vector.
func (x Float32s) ToBits() Uint32s
-// LoadFloat64 loads a slice of float64 into an Float64s vector.
+// LoadFloat64s loads a slice of float64 into an Float64s vector.
func LoadFloat64s([]float64) Float64s
-// LoadFloat64Part loads a partial slice of float64 into an Float64s vector, returning the vector and the number of elements loaded.
+// LoadFloat64sPart loads a partial slice of float64 into an Float64s vector, returning the vector and the number of elements loaded.
func LoadFloat64sPart([]float64) (Float64s, int)
-// BroadcastFloat64 fills the elements of a slice with its argument value.
+// BroadcastFloat64s fills the elements of a slice with its argument value.
func BroadcastFloat64s(float64) Float64s
// Abs returns the element-wise absolute value of x.
Change information
Files:
- M src/simd/internal/bridge/simd_emulated.go
- M src/simd/ip_test.go
- M src/simd/simd_emulated.go
- M src/simd/simd_stubs.go
Change size: M
Delta: 4 files changed, 29 insertions(+), 29 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
shuang cui (Gerrit)
Jul 6, 2026, 10:57:06 AMJul 6
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
shuang cui voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Liao (Gerrit)
Jul 20, 2026, 4:26:53 PMJul 20
to shuang cui, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from shuang cui
Sean Liao voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- shuang cui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Liao (Gerrit)
Jul 20, 2026, 4:27:02 PMJul 20
to shuang cui, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from shuang cui
Sean Liao voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- shuang cui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
Jul 21, 2026, 5:35:37 PMJul 21
to shuang cui, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from shuang cui
Carlos Amedee voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- shuang cui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
Jul 21, 2026, 7:24:15 PMJul 21
to shuang cui, goph...@pubsubhelper.golang.org, Carlos Amedee, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from shuang cui
Cherry Mui added 1 comment![]( "Open in Gerrit")
File src/simd/simd_stubs.go
File-level comment, Patchset 1 (Latest):
Cherry Mui . unresolved
This file is generated. We should modify the generator instead.
Related details
Attention is currently required from:
- shuang cui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
Jul 21, 2026, 7:24:26 PMJul 21
to shuang cui, goph...@pubsubhelper.golang.org, Carlos Amedee, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Sean Liao and shuang cui
Cherry Mui removed a vote from this change![]( "Open in Gerrit")
Attention is currently required from:
- Sean Liao
- shuang cui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Liao (Gerrit)
Jul 21, 2026, 7:41:56 PMJul 21
to shuang cui, goph...@pubsubhelper.golang.org, Cherry Mui, Carlos Amedee, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from shuang cui
Sean Liao voted Code-Review+0![]( "Open in Gerrit")
Attention is currently required from:
- shuang cui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
shuang cui (Gerrit)
Jul 22, 2026, 2:50:23 AMJul 22
to goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com
Attention needed from Carlos Amedee and shuang cui
shuang cui uploaded new patchset![]( "Open in Gerrit")
shuang cui uploaded patch set #2 to this change.
Following approvals got outdated and were removed:
- Code-Review: +1 by Carlos Amedee
- TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
Related details
Attention is currently required from:
- Carlos Amedee
- shuang cui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
shuang cui (Gerrit)
Jul 22, 2026, 2:51:09 AMJul 22
to goph...@pubsubhelper.golang.org, Cherry Mui, Carlos Amedee, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from Carlos Amedee and Cherry Mui
shuang cui voted and added 1 comment![]( "Open in Gerrit")
Votes added by shuang cui
| Commit-Queue | +1 |
This file is generated. We should modify the generator instead.
shuang cui
Updated the generator input in archsimd/_gen/midway/comments.yaml and regenerated src/simd/simd_stubs.go.
Please review it again.
Related details
Attention is currently required from:
- Carlos Amedee
- Cherry Mui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
shuang cui (Gerrit)
Jul 22, 2026, 6:03:23 AMJul 22
to goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, Carlos Amedee, golang-co...@googlegroups.com
Attention needed from Carlos Amedee and Cherry Mui
shuang cui voted and added 1 comment![]( "Open in Gerrit")
Votes added by shuang cui
| Commit-Queue | +1 |
Carlos Amedee (Gerrit)
Jul 22, 2026, 10:02:32 AMJul 22
to shuang cui, goph...@pubsubhelper.golang.org, golang...@luci-project-accounts.iam.gserviceaccount.com, Cherry Mui, golang-co...@googlegroups.com
Attention needed from Cherry Mui and shuang cui
Carlos Amedee added 1 comment![]( "Open in Gerrit")
File src/simd/simd_stubs.go
Cherry Mui . resolved
shuang cuiThis file is generated. We should modify the generator instead.
Updated the generator input in archsimd/_gen/midway/comments.yaml and regenerated src/simd/simd_stubs.go.
Please review it again.
Attention is currently required from:
- Cherry Mui
- shuang cui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
Jul 22, 2026, 10:57:53 AMJul 22
to shuang cui, goph...@pubsubhelper.golang.org, David Chase, golang...@luci-project-accounts.iam.gserviceaccount.com, Carlos Amedee, golang-co...@googlegroups.com
Attention needed from shuang cui
Cherry Mui voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- shuang cui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Carlos Amedee (Gerrit)
Jul 23, 2026, 10:45:38 AMJul 23
to shuang cui, goph...@pubsubhelper.golang.org, Cherry Mui, David Chase, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Attention needed from shuang cui
Carlos Amedee voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- shuang cui
Submit Requirements:
Code-Review
No-Unresolved-Comments
Review-Enforcement
TryBots-Pass
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Cherry Mui (Gerrit)
Jul 23, 2026, 10:56:05 AMJul 23
to shuang cui, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Carlos Amedee, David Chase, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Cherry Mui submitted the change![]( "Open in Gerrit")
Change information
Commit message:
simd: make function comment match function name
Change-Id: Ia474eb19df92cfdb4122564a87a9837b4ff03348
Reviewed-on: https://go-review.googlesource.com/c/go/+/797120
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: Carlos Amedee <car...@golang.org>
Files:
- M src/simd/archsimd/_gen/midway/comments.yaml
- M src/simd/internal/bridge/simd_emulated.go
- M src/simd/ip_test.go
- M src/simd/simd_emulated.go
- M src/simd/simd_stubs.go
Change size: M
Delta: 5 files changed, 56 insertions(+), 56 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Carlos Amedee, +2 by Cherry Mui
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages