[go] refactor: lint Markdown for trailing spaces and code blocks

74 views
Skip to first unread message

Gerrit Bot (Gerrit)

unread,
Feb 16, 2021, 5:19:03 AM2/16/21
to goph...@pubsubhelper.golang.org, John Bampton, golang-co...@googlegroups.com

Gerrit Bot has uploaded this change for review.

View Change

refactor: lint Markdown for trailing spaces and code blocks

MD009 Trailing spaces.
MD031 Fenced code blocks should be surrounded by blank lines.

https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

Change-Id: I6a2fff4afa8224442d90b30f84444b4a888fcef2
GitHub-Last-Rev: 02d71d177a5a218125d9172d9e667c09bd0f01d7
GitHub-Pull-Request: golang/go#44285
---
M misc/trace/README.md
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/misc/trace/README.md b/misc/trace/README.md
index 218d728..1fa1431 100644
--- a/misc/trace/README.md
+++ b/misc/trace/README.md
@@ -1,7 +1,7 @@
## Resources for Go's trace viewer

Go execution trace UI (`go tool trace`) embeds
-Chrome's trace viewer (Catapult) following the
+Chrome's trace viewer (Catapult) following the
[instructions](
https://chromium.googlesource.com/catapult/+/refs/heads/master/tracing/docs/embedding-trace-viewer.md). This directory contains
the helper files to embed Chrome's trace viewer.
@@ -13,6 +13,7 @@
### Updating `trace_viewer_full.html`

The file was generated by catapult's `vulcanize_trace_viewer` command.
+
```
$ git clone https://chromium.googlesource.com/catapult
$ cd catapult

To view, visit change 292409. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a2fff4afa8224442d90b30f84444b4a888fcef2
Gerrit-Change-Number: 292409
Gerrit-PatchSet: 1
Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
Gerrit-CC: John Bampton <jbam...@gmail.com>
Gerrit-MessageType: newchange

Gerrit Bot (Gerrit)

unread,
Mar 4, 2021, 9:11:01 PM3/4/21
to John Bampton, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Gerrit Bot uploaded patch set #2 to this change.

View Change

refactor: lint Markdown for trailing spaces and code blocks

MD009 Trailing spaces.
MD031 Fenced code blocks should be surrounded by blank lines.

https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

Change-Id: I6a2fff4afa8224442d90b30f84444b4a888fcef2
GitHub-Last-Rev: bbc05b6b11f56c8c3c6ceac2993b22722aeda27e

GitHub-Pull-Request: golang/go#44285
---
M misc/trace/README.md
1 file changed, 2 insertions(+), 1 deletion(-)

To view, visit change 292409. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a2fff4afa8224442d90b30f84444b4a888fcef2
Gerrit-Change-Number: 292409
Gerrit-PatchSet: 2
Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
Gerrit-CC: John Bampton <jbam...@gmail.com>
Gerrit-MessageType: newpatchset

Gerrit Bot (Gerrit)

unread,
Mar 4, 2021, 9:13:07 PM3/4/21
to John Bampton, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Gerrit Bot uploaded patch set #3 to this change.

View Change

doc: lint Markdown for trailing spaces and code blocks


MD009 Trailing spaces.
MD031 Fenced code blocks should be surrounded by blank lines.

https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

Change-Id: I6a2fff4afa8224442d90b30f84444b4a888fcef2
GitHub-Last-Rev: bbc05b6b11f56c8c3c6ceac2993b22722aeda27e
GitHub-Pull-Request: golang/go#44285
---
M misc/trace/README.md
1 file changed, 2 insertions(+), 1 deletion(-)

To view, visit change 292409. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a2fff4afa8224442d90b30f84444b4a888fcef2
Gerrit-Change-Number: 292409
Gerrit-PatchSet: 3

Gerrit Bot (Gerrit)

unread,
May 17, 2022, 6:33:09 PM5/17/22
to John Bampton, goph...@pubsubhelper.golang.org, golang-co...@googlegroups.com

Gerrit Bot uploaded patch set #4 to this change.

View Change

doc: lint Markdown for trailing spaces and code blocks

MD009 Trailing spaces.
MD031 Fenced code blocks should be surrounded by blank lines.

https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

Change-Id: I6a2fff4afa8224442d90b30f84444b4a888fcef2
GitHub-Last-Rev: 67cf146b8501096949faf0155239770d4f6a73b4
GitHub-Pull-Request: golang/go#44285
---
M src/cmd/compile/internal/ssa/README.md
M src/cmd/trace/static/README.md
2 files changed, 20 insertions(+), 3 deletions(-)

To view, visit change 292409. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a2fff4afa8224442d90b30f84444b4a888fcef2
Gerrit-Change-Number: 292409
Gerrit-PatchSet: 4

Robert Griesemer (Gerrit)

unread,
May 19, 2022, 12:10:00 PM5/19/22
to Gerrit Bot, John Bampton, goph...@pubsubhelper.golang.org, Robert Griesemer, golang-co...@googlegroups.com

Attention is currently required from: Robert Griesemer.

Patch set 4:Code-Review +2

View Change

    To view, visit change 292409. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: go
    Gerrit-Branch: master
    Gerrit-Change-Id: I6a2fff4afa8224442d90b30f84444b4a888fcef2
    Gerrit-Change-Number: 292409
    Gerrit-PatchSet: 4
    Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
    Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
    Gerrit-Reviewer: Robert Griesemer <g...@google.com>
    Gerrit-CC: John Bampton <jbam...@gmail.com>
    Gerrit-Attention: Robert Griesemer <g...@golang.org>
    Gerrit-Comment-Date: Thu, 19 May 2022 16:09:55 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Daniel Martí (Gerrit)

    unread,
    May 27, 2022, 5:11:05 AM5/27/22
    to Gerrit Bot, John Bampton, goph...@pubsubhelper.golang.org, Robert Griesemer, Robert Griesemer, golang-co...@googlegroups.com

    Attention is currently required from: Robert Griesemer.

    Patch set 4:Run-TryBot +1Code-Review +1

    View Change

      To view, visit change 292409. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: go
      Gerrit-Branch: master
      Gerrit-Change-Id: I6a2fff4afa8224442d90b30f84444b4a888fcef2
      Gerrit-Change-Number: 292409
      Gerrit-PatchSet: 4
      Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
      Gerrit-Reviewer: Daniel Martí <mv...@mvdan.cc>
      Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
      Gerrit-Reviewer: Robert Griesemer <g...@google.com>
      Gerrit-CC: John Bampton <jbam...@gmail.com>
      Gerrit-Attention: Robert Griesemer <g...@golang.org>
      Gerrit-Comment-Date: Fri, 27 May 2022 09:10:59 +0000

      Alex Rakoczy (Gerrit)

      unread,
      May 27, 2022, 11:07:14 AM5/27/22
      to Gerrit Bot, John Bampton, goph...@pubsubhelper.golang.org, Gopher Robot, Daniel Martí, Robert Griesemer, Robert Griesemer, golang-co...@googlegroups.com

      Attention is currently required from: Robert Griesemer.

      Patch set 4:Auto-Submit +1Code-Review +1

      View Change

        To view, visit change 292409. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I6a2fff4afa8224442d90b30f84444b4a888fcef2
        Gerrit-Change-Number: 292409
        Gerrit-PatchSet: 4
        Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
        Gerrit-Reviewer: Alex Rakoczy <al...@golang.org>
        Gerrit-Reviewer: Daniel Martí <mv...@mvdan.cc>
        Gerrit-Reviewer: Gopher Robot <go...@golang.org>
        Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
        Gerrit-Reviewer: Robert Griesemer <g...@google.com>
        Gerrit-CC: John Bampton <jbam...@gmail.com>
        Gerrit-Attention: Robert Griesemer <g...@golang.org>
        Gerrit-Comment-Date: Fri, 27 May 2022 15:07:10 +0000

        Gopher Robot (Gerrit)

        unread,
        May 27, 2022, 11:07:47 AM5/27/22
        to Gerrit Bot, John Bampton, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Alex Rakoczy, Daniel Martí, Robert Griesemer, Robert Griesemer, golang-co...@googlegroups.com

        Gopher Robot submitted this change.

        View Change


        Approvals: Robert Griesemer: Looks good to me, approved Alex Rakoczy: Looks good to me, but someone else must approve; Automatically submit change Daniel Martí: Looks good to me, but someone else must approve; Run TryBots Gopher Robot: TryBots succeeded
        doc: lint Markdown for trailing spaces and code blocks

        MD009 Trailing spaces.
        MD031 Fenced code blocks should be surrounded by blank lines.

        https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

        Change-Id: I6a2fff4afa8224442d90b30f84444b4a888fcef2
        GitHub-Last-Rev: 67cf146b8501096949faf0155239770d4f6a73b4
        GitHub-Pull-Request: golang/go#44285
        Reviewed-on: https://go-review.googlesource.com/c/go/+/292409
        Reviewed-by: Robert Griesemer <g...@google.com>
        Auto-Submit: Alex Rakoczy <al...@golang.org>
        Reviewed-by: Daniel Martí <mv...@mvdan.cc>
        Run-TryBot: Daniel Martí <mv...@mvdan.cc>
        Reviewed-by: Alex Rakoczy <al...@golang.org>
        TryBot-Result: Gopher Robot <go...@golang.org>

        ---
        M src/cmd/compile/internal/ssa/README.md
        M src/cmd/trace/static/README.md
        2 files changed, 27 insertions(+), 3 deletions(-)

        diff --git a/src/cmd/compile/internal/ssa/README.md b/src/cmd/compile/internal/ssa/README.md
        index 833bf1d..d695fda 100644
        --- a/src/cmd/compile/internal/ssa/README.md
        +++ b/src/cmd/compile/internal/ssa/README.md
        @@ -185,10 +185,10 @@
        follow the control flow and values.

        The value specified in GOSSAFUNC can also be a package-qualified function
        -name, e.g.
        +name, e.g.

        GOSSAFUNC=blah.Foo go build
        -
        +
        This will match any function named "Foo" within a package whose final
        suffix is "blah" (e.g. something/blah.Foo, anotherthing/extra/blah.Foo).

        diff --git a/src/cmd/trace/static/README.md b/src/cmd/trace/static/README.md
        index f81c59e..b0ca86a 100644
        --- a/src/cmd/trace/static/README.md
        +++ b/src/cmd/trace/static/README.md

        @@ -1,7 +1,7 @@
        ## Resources for Go's trace viewer

        Go execution trace UI (`go tool trace`) embeds
        -Chrome's trace viewer (Catapult) following the
        +Chrome's trace viewer (Catapult) following the
        [instructions](
        https://chromium.googlesource.com/catapult/+/refs/heads/master/tracing/docs/embedding-trace-viewer.md). This directory contains
        the helper files to embed Chrome's trace viewer.
        @@ -13,6 +13,7 @@
        ### Updating `trace_viewer_full.html`

        The file was generated by catapult's `vulcanize_trace_viewer` command.
        +
        ```
        $ git clone https://chromium.googlesource.com/catapult
        $ cd catapult

        To view, visit change 292409. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: go
        Gerrit-Branch: master
        Gerrit-Change-Id: I6a2fff4afa8224442d90b30f84444b4a888fcef2
        Gerrit-Change-Number: 292409
        Gerrit-PatchSet: 5
        Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
        Gerrit-Reviewer: Alex Rakoczy <al...@golang.org>
        Gerrit-Reviewer: Daniel Martí <mv...@mvdan.cc>
        Gerrit-Reviewer: Gopher Robot <go...@golang.org>
        Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
        Gerrit-Reviewer: Robert Griesemer <g...@google.com>
        Gerrit-CC: John Bampton <jbam...@gmail.com>
        Gerrit-MessageType: merged
        Reply all
        Reply to author
        Forward
        0 new messages